Bug 41574 - EDITING: after removing a custom animation I cannot add another
Summary: EDITING: after removing a custom animation I cannot add another
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.5.0 Beta1
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Object-Animations
  Show dependency treegraph
 
Reported: 2011-10-07 14:39 UTC by Reuben Thomas
Modified: 2024-01-17 12:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file to reproduce bug (234.17 KB, application/vnd.oasis.opendocument.presentation)
2013-06-04 10:28 UTC, Reuben Thomas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Reuben Thomas 2011-10-07 14:39:25 UTC
After removing a custom animation from a slide, the Add... button no longer works. I have to select another slide and then go back to the first one in order to be able to add a new custom animation.
Comment 1 Björn Michaelsen 2011-12-23 12:39:29 UTC Comment hidden (obsolete)
Comment 2 Reuben Thomas 2011-12-23 13:57:28 UTC
Confirmed in 3.5.0beta1. Changing back to NEW.
Comment 3 A (Andy) 2013-04-20 22:05:53 UTC
not reproducible with LO 4.0.2.2 (Win7 Home, 64bit)

Does this issue still persist for you with the latest release of LO?  If not, then I would propose to close this bug report.
Comment 4 Reuben Thomas 2013-04-20 22:28:50 UTC
This bug still exists in 4.0.2.2 (Ubuntu 12.10, 64bit), in a weaker form:

Here is what I do step by step:

1. Open an Impress file.

2. Click on a custom animation.

3. Click the Remove button.

At this stage, the Add… button is still active. However, no effect is selected.

4. Click the Add… button.

5. Nothing happens, but the Add… button is now greyed out.

If I select an effect, the Add… button is reactivated, and I can add another animation. If after deleting an effect its parent were selected, then I would not need this extra click. (This is the same sort of bug as if the text caret disappeared when you press Delete; the difference is that the caret marks a place between characters, whereas here the effective position is on a particular (selected) effect, not between two.) But maybe this is just the way that tree widgets work?
Comment 5 ign_christian 2013-06-04 02:41:24 UTC
Please attach your presentation file so anyone here could test using same source.
Comment 6 Reuben Thomas 2013-06-04 10:28:50 UTC
Created attachment 80278 [details]
Example file to reproduce bug
Comment 7 ign_christian 2013-06-05 03:16:57 UTC
> 2. Click on a custom animation.
> 
> 3. Click the Remove button.
> 
> At this stage, the Add… button is still active. However, no effect is
> selected.
I think it's a bug.

> 4. Click the Add… button.
> 
> 5. Nothing happens, but the Add… button is now greyed out.
Confirm same behavior on my testing.

> If I select an effect, the Add… button is reactivated, and I can add another
> animation. If after deleting an effect its parent were selected, then I
> would not need this extra click. (This is the same sort of bug as if the
> text caret disappeared when you press Delete; the difference is that the
> caret marks a place between characters, whereas here the effective position
> is on a particular (selected) effect, not between two.) But maybe this is
> just the way that tree widgets work?
Don't know whether it's a bug or it's designed as is with some consideration.

Tested on LO 4.0.4.1 (Win7 32bit)
Comment 8 Joel Madero 2013-06-21 17:58:28 UTC
Version: 4.2.0.0.alpha0+Build ID: b0a1666f756aa5f5315366eca9d7d02ddd55d2b
Date:   Tue May 28 08:51:01 2013 +0300 
Platform: Bodhi Linux 2.2 x64

I can confirm and believe it isn't working as intended - it should gray out immediately.

The issue is that after you remove it unselects the object so there is nothing to add an event to. 

So one of two solutions are needed:
1. Don't unselect the object so you can add immediately
2. Gray out immediately after selecting remove


New
Minor - doesn't prevent high quality work, can slow it down a tiny bit
Low - default seems appropriate

ProposedEasyHack - seems relatively easy to solve

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
LibreOffice is powered by a team of volunteers, every bug is confirmed (triaged) by human beings who mostly give their time for free. We invite you to join our triaging by checking out this link:
https://wiki.documentfoundation.org/QA/BugTriage and join us on freenode at #libreoffice-qa

There are also other ways to get involved including with marketing, UX, documentation, and of course developing -  http://www.libreoffice.org/get-help/mailing-lists/. 

Lastly, good bug reports help tremendously in making the process go smoother, please always provide reproducible steps (even if it seems easy) and attach any and all relevant material
Comment 9 Joel Madero 2014-02-27 22:55:02 UTC
In order to limit the confusion between ProposedEasyHack and EasyHack and to make queries much easier we are changing ProposedEasyHack to NeedsDevEval.

Thank you and apologies for the noise
Comment 10 Robinson Tryon (qubit) 2015-12-13 11:21:10 UTC Comment hidden (obsolete)
Comment 11 QA Administrators 2017-01-03 19:50:01 UTC Comment hidden (obsolete)
Comment 12 Reuben Thomas 2017-01-03 20:38:28 UTC
This bug still exists in 5.2.3.2 (Ubuntu 16.04, x86_64), in a slightly different form:

Here is what I do step by step:

1. Open an Impress file.

2. Click on a custom animation.

3. Click the Remove button.

If the slide was previously selected, the Add… button remains active. Otherwise, it is now greyed out.

4. If the Add… button was not greyed out by the previous step, Click the Add… button.

5. Nothing happens. (Previously, the Add… button was now greyed out.)

To reactivate the Add… button, I need to click in the slide. Selecting an effect is not sufficient. However, if an Effect is selected, then I need to change to another slide and back to the current one in order to reactivate the Add… button.

In short, the situation in 5.2 is more complicated and confusing than in 4.2, and the basic usability problem still exists.
Comment 13 QA Administrators 2018-01-04 03:35:47 UTC Comment hidden (obsolete)
Comment 14 Reuben Thomas 2018-01-04 14:13:58 UTC
This bug still exists in 5.4.4 (Ubuntu 16.04, x86_64), in the same form as in 5.2.3.2.

As I've commented before, I would be most grateful if the LibreOffice developers could find a way to not auto-expire bugs that are clearly not going away (perhaps that have been confirmed twice already in annual reviews?). In the last few years the bulk of my time interacting with the LO bug tracker has been spent simply confirming that already-reported bugs still exist. This is not a good use of my time, or of the time of developers who have to review this information.
Comment 15 QA Administrators 2019-09-29 03:08:03 UTC Comment hidden (obsolete)
Comment 16 Reuben Thomas 2019-09-29 19:01:43 UTC
This bug still exists in 6.0.7.3 (Ubuntu 18.04, x86_64), in the same form as in 5.2.3.2.
Comment 17 QA Administrators 2021-09-29 04:02:49 UTC Comment hidden (obsolete)
Comment 18 QA Administrators 2023-09-30 03:17:50 UTC Comment hidden (obsolete)
Comment 19 Reuben Thomas 2023-09-30 09:13:45 UTC
I tried reproducing this bug in 7.6.2.1, using the steps I provided in Comment #12.

When I remove the custom animation, the "+ Add" is no longer greyed out. However, when I click on "+ Add", instead of just adding a new effect, it pastes a copy of the entire effects tree the slide originally had. I cannot work out how to simply add an effect. Maybe this even counts as a different bug?
Comment 20 Buovjaga 2024-01-17 12:33:19 UTC
(In reply to Reuben Thomas from comment #19)
> I tried reproducing this bug in 7.6.2.1, using the steps I provided in
> Comment #12.
> 
> When I remove the custom animation, the "+ Add" is no longer greyed out.
> However, when I click on "+ Add", instead of just adding a new effect, it
> pastes a copy of the entire effects tree the slide originally had. I cannot
> work out how to simply add an effect. Maybe this even counts as a different
> bug?

This is normal: it is because you have selected a text box containing multiple paragraphs/bullets. I tested it with slide 2 in attachment 80278 [details].

There is another corner case I found that was introduced in 6.1: bug 159241.

Let's close this one.