Bug 41997 - EasyHack: cleanup vcl enumeration ...
Summary: EasyHack: cleanup vcl enumeration ...
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: Other All
: medium normal
Assignee: Olivier Hallot
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2011-10-19 07:04 UTC by Michael Meeks
Modified: 2015-12-15 16:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
patch to fix fdo 41997 (10.75 KB, patch)
2011-10-21 14:34 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2011-10-19 07:04:59 UTC
Currently vcl/inc/vcl/apptypes.hxx exports some enumeration values that are not namespaced eg. INPUT_MOUSE and INPUT_KEYBOARD.

These conflict with global definitions of the same name on windows causing annoying warnings.

We should add a VCL_ prefix to those types, and replace across the code-base: just do a 'git grep INPUT_MOUSE' (and for each value in there) for those and update them.

sample warning:

windows/solver/wntgcci.pro/inc/vcl/apptypes.hxx:59:0: warning: "INPUT_KEYBOARD" redefined [enabled by default]
/usr/i686-w64-mingw32/sys-root/mingw/include/winuser.h:2471:0: note: this is the location of the previous definition

I look forward to the patch ! :-) thanks ...
Comment 1 Olivier Hallot 2011-10-21 14:34:24 UTC
Created attachment 52621 [details]
patch to fix fdo 41997
Comment 2 Olivier Hallot 2011-10-21 14:35:10 UTC
fixed
Comment 3 Robinson Tryon (qubit) 2015-12-15 16:27:27 UTC
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]