Bug 44635 - EasyHack: trivial whitespace cleanup in presenter console ...
Summary: EasyHack: trivial whitespace cleanup in presenter console ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2012-01-10 06:11 UTC by Michael Meeks
Modified: 2015-12-15 16:27 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
sdext/source/presenter/*: remove extraneous vertical whitespace (287.14 KB, patch)
2012-01-12 04:15 UTC, Rich Wareham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2012-01-10 06:11:04 UTC
The Presenter console code lives in:

sdext/source/presenter/*

It was written by someone with no respect at all for the non-renewable resource that is vertical space :-)

Which means there are five lines of blanks between each method, where there should be only one: so you can see more on the screen at once.

That's quite annoying when editing - it'd be nice to fix :-)
Comment 1 Rich Wareham 2012-01-12 04:15:22 UTC
Created attachment 55487 [details]
sdext/source/presenter/*: remove extraneous vertical whitespace

Patch to collapse multiple vertical lines of whitespace into single lines.

This is my first contribution so I'm not sure of the etiquette. Should I also get git to email the patch to the dev list?
Comment 2 Michael Meeks 2012-01-12 06:46:58 UTC
Hi Rick,

> This is my first contribution

    Welcome ! :-) I pushed the patch; thanks ...

> so I'm not sure of the etiquette. Should I also get git to email
> the patch to the dev list?

    It's by far the best to drop a patch to the dev list with [PATCH]: in the Subject - that gets the most attention and review, but no need for this.

    What we really would need is to have a mail to the developer list with an MPL/LGPLv3+ license statement, so we can add you to the wiki:

    http://wiki.documentfoundation.org/Development/Developers

    Anyhow - great to have a first patch in, and ... nice to see some more Cambridge blood; I was at Downing until 2000 :-)

    Regards,

        Michael (who clearly prefers E-mail ;-)
Comment 3 Robinson Tryon (qubit) 2015-12-15 16:27:27 UTC
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]