Bug 46610 - EasyHack: vcl - remove un-used return values ...
Summary: EasyHack: vcl - remove un-used return values ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Master old -3.6
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2012-02-25 03:58 UTC by Michael Meeks
Modified: 2015-12-15 16:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2012-02-25 03:58:40 UTC 
Poking at vcl, I notice the vcl/inc/vcl/region.hxx class defines several methods:

Union, Intersect, Exclude, XOr etc. which -seem- to return a sal_Bool that is always true :-)

We should investigate if that is so, and if it is, then remove the return value from the signature(s), and check call-sites to ensure that this is not used anywhere. Hopefully that'd make the good, mutating function of those methods more obvious.

Thanks.
Comment 1 Daniel Bankston 2012-04-02 16:20:11 UTC 
Hi, Michael,

I'm looking into this.
Comment 2 Daniel Bankston 2012-04-02 20:10:18 UTC 
Patch submitted to mailing list.

http://nabble.documentfoundation.org/PATCH-EasyHack-Bug-46610-td3879786.html
Comment 3 Michael Meeks 2012-04-03 06:17:14 UTC 
Thanks Daniel ! nice cleanup, and good to find a bug-fix underneath that mess too :-)
Comment 4 Robinson Tryon (qubit) 2015-12-15 16:27:27 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]