Poking at vcl, I notice the vcl/inc/vcl/region.hxx class defines several methods: Union, Intersect, Exclude, XOr etc. which -seem- to return a sal_Bool that is always true :-) We should investigate if that is so, and if it is, then remove the return value from the signature(s), and check call-sites to ensure that this is not used anywhere. Hopefully that'd make the good, mutating function of those methods more obvious. Thanks.
Hi, Michael, I'm looking into this.
Patch submitted to mailing list. http://nabble.documentfoundation.org/PATCH-EasyHack-Bug-46610-td3879786.html
Thanks Daniel ! nice cleanup, and good to find a bug-fix underneath that mess too :-)
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup) [NinjaEdit]