Bug 51162 - FORMATTING: In Format Cells, setting the border's line width does not affect all borders.
Summary: FORMATTING: In Format Cells, setting the border's line width does not affect ...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.5.4 release
Hardware: Other Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-16 15:30 UTC by activatecrap
Modified: 2013-01-18 20:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
A step by step graphic explaining the bug report. (150.70 KB, image/png)
2012-06-17 08:59 UTC, activatecrap
Details

Note You need to log in before you can comment on or make changes to this bug.
Description activatecrap 2012-06-16 15:30:15 UTC
Problem description: 

Steps to reproduce:
1. Fully border a cell in the middle of the sheet.
2. Select that cell and one next to it.
3. Format -> Cells
4. Set Line Width to 2pt.

Current behavior:
Only one side of the border is changed.

Expected behavior:
All sides of the border are changed.

Platform (if different from the browser):
Windows 7 - 64 bit
              
Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0.1
Comment 1 activatecrap 2012-06-16 15:33:54 UTC
Line style and line color behave the same way.
Comment 2 activatecrap 2012-06-16 15:46:53 UTC
Oh, and the weird thing is that setting Line Style or Line Color from the toolbar does affect the whole selection. Though doing that has a bug of its own: it isn't added to the undo list.
Comment 3 Rainer Bielefeld Retired 2012-06-16 22:43:50 UTC
Not a valid bug report, too much info missing. And looks like a user error, of course such a modification does not affect all cell borders, but only the ones selected that the change should be applied

@reporter:
Thank you for your report – unfortunately important information is missing.
May be hints on <http://wiki.documentfoundation.org/BugReport> will help you to find out what information will be useful to reproduce your problem? If you believe that that  is really sophisticated please as for Help on a user mailing list
Please:
- Write a meaningful Summary describing exactly what the problem is
- Attach a sample document (not only screenshot) or refer to an existing 
  sample document in an other Bug with a link.
- Attach screenshots with comments if you believe that that might explain the 
  problem better than a text comment. Best way is to insert your screenshots
  into a DRAW document and to add comments that explain what you want to show
- Contribute a document related step by step instruction containing every 
  key press and every mouse click how to reproduce your problem 
  (similar to example in Bug 43431)
– if possible contribute an instruction how to create a sample document 
  from the scratch
- add information 
  -- what EXACTLY is unexpected
  -- and WHY do you believe it's unexpected (cite Help or Documentation!)
  -- concerning your PC (video card, ...)
  -- concerning your OS (Version, Distribution, Language)
  -- concerning your LibO version (with Build ID if it's not a public release)
     and localization (UI language, Locale setting)
  –- Libo settings that might be related to your problems 
    (video hardware acceleration ...)
  -- how you launch LibO and how you opened the sample document
  -- everything else crossing your mind after you read linked texts

Even if you can not provide all demanded information, every little new information might bring the breakthrough.
Comment 4 activatecrap 2012-06-17 08:59:41 UTC
Created attachment 63139 [details]
A step by step graphic explaining the bug report.

Alright, here's my attempt to supply more information.
Comment 5 activatecrap 2012-06-17 09:04:50 UTC
(In reply to comment #4)
> Created attachment 63139 [details]
> A step by step graphic explaining the bug report.
> 
> Alright, here's my attempt to supply more information.

Where it says "This method sets the color of all borders" it should be "This method sets the color of all borders within the selection".
Comment 6 Rainer Bielefeld Retired 2012-06-29 10:51:42 UTC
> Where it says "This method sets the color of all borders" it should be "This
> method sets the color of all borders within the selection".

What is "It"?
And what ever it is, I currently do not believe that we need that addition. Generally formatting (Character size ...) only will be done for the selection. 

I disagree with the "Final Comment  1" in "A step by step graphic explaining the bug report" (great work, BTW!). These are completely different tools for border formatting, and the different behavior is intended.

And now the subject is concerning something different from Comment 5

@Reporter:
"Final Comment  2" is worth to be discussed, may be an icon "line width for all existing borders" would be useful. I recommend to discuss that on <libreoffice-ux-advise@lists.freedesktop.org>
Comment 7 activatecrap 2012-06-29 19:45:17 UTC
(In reply to comment #6)
> > Where it says "This method sets the color of all borders" it should be "This
> > method sets the color of all borders within the selection".
> 
> What is "It"?
> And what ever it is, I currently do not believe that we need that addition.
> Generally formatting (Character size ...) only will be done for the selection. 

You're right, I was unclear there. "It" refers to my attachment. I was trying to correct one of the lines in it.

> "Final Comment 2" is worth to be discussed, may be an icon "line width for all
> existing borders" would be useful. I recommend to discuss that on
> <libreoffice-ux-advise@lists.freedesktop.org>

I think the addition of a line width icon would be reasonably satisfactory. As long as there's a method to set the line width of all selected borders, and that method is reasonably easy to find, I'm happy.
Comment 8 Rainer Bielefeld Retired 2012-08-18 15:12:19 UTC
For me, in reporter's  explanation the result of the "right path" is plausible: any cell border in the selection will be modified.

With the left path I am not sure, to me selector's (in that dialog) decision to preselect only the top cell border seems a little mysterious. Why only that one and not all ones? It's always the same when I do some research concerning these cell border formatting issues. When I start, way how it works seems absurd to me, the longer I work with it the more plausible it seems to be. May be behavior is different to enable user to act flexible and to solve users needs in a flexible way with few mouse clicks? I still am wishy-washy whether we have a bug or not ...

But definitively more info from reporter will not help.
Comment 9 Michael Stahl (CIB) 2012-08-20 21:08:53 UTC
the way this currently works is that the format->cells dialog operates on a selection of cells, and the borders tab displays only those lines that are consistent in the selection, i.e. it will display the top line because of the selected cells only one is in the top row and that one has a top border; it will not display the bottom line because of the cells in the bottom row of the selection  none have a border, and the left/right border is displayed "grayed out" because there the lines are not consistent i.e. in the first column one cell has a left border and one not and in the last column as well for right border.

because the selection dialog has to allow to set "inner horizontal"/"inner vertical" lines which is by definition top/bottom or left/right border of cells that are not the outermost border (via the middle horizontal line in the attachment screenshot), it is not possible to interpret clicking OK as affecting only the lines that previously had a border; in other words this works "as designed".

maybe a better design is possible :) but it must in any case also allow for the current behavior of explicitly setting all "inner" borders.

btw, nice graphical illustration from the reporter :)
Comment 10 bfoman (inactive) 2013-01-18 11:42:49 UTC
Per comment 9 I will mark this bug report as NOTABUG.
@reporter:
If you think that the way it works should be changed, consider contacting UI experts available at libreoffice-ux-advise@lists.freedesktop.org.

BTW: your STR graphic should be marked as a template for all reporters. Good work!
Comment 11 activatecrap 2013-01-18 18:36:59 UTC
> If you think that the way it works should be changed, consider contacting UI
> experts available at libreoffice-ux-advise@lists.freedesktop.org.
Will do.

> BTW: your STR graphic should be marked as a template for all reporters. Good
> work!
Thanks!
Comment 12 Rainer Bielefeld Retired 2013-01-18 20:37:55 UTC
(In reply to comment #10)
Yes, activatecrap's sketch was really good work, thanks!