Bug 53236 - Make shadow design updates easier
Summary: Make shadow design updates easier
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp, topicUI
Depends on:
Blocks:
 
Reported: 2012-08-08 10:12 UTC by Miklos Vajna
Modified: 2017-02-14 08:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miklos Vajna 2012-08-08 10:12:27 UTC 
This is similar to bug 42779. The method that pains the shadow around a Writer page is SwPageFrm::PaintBorderAndShadow():

http://opengrok.libreoffice.org/xref/core/sw/source/core/layout/paintfrm.cxx#5669

Right now, the code actually uses the entire image as an Alpha only; it would be cleaner to just take the image, and apply the Alpha from the image.

It would be easier for designers to do changes after this is fixed.

More pointers - the image that is parsed there is under icon-themes/galaxy/sw/res/page-shadow-mask.png.
Comment 1 Björn Michaelsen 2014-12-02 10:53:10 UTC 
adding LibreOffice developer list as CC to unresolved Writer EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 2 Robinson Tryon (qubit) 2015-12-14 05:00:14 UTC Comment hidden (obsolete)
Comment 3 Robinson Tryon (qubit) 2016-02-18 14:51:24 UTC Comment hidden (obsolete)
Comment 4 Prashant 2016-05-01 07:26:08 UTC 
(In reply to Miklos Vajna from comment #0)
> This is similar to bug 42779. The method that pains the shadow around a
> Writer page is SwPageFrm::PaintBorderAndShadow():
> 
> http://opengrok.libreoffice.org/xref/core/sw/source/core/layout/paintfrm.
> cxx#5669
> 
> Right now, the code actually uses the entire image as an Alpha only; it
> would be cleaner to just take the image, and apply the Alpha from the image.
> 
> It would be easier for designers to do changes after this is fixed.
> 
> More pointers - the image that is parsed there is under
> icon-themes/galaxy/sw/res/page-shadow-mask.png.

Can you explain following lines more clearly,


> 
> Right now, the code actually uses the entire image as an Alpha only; it
> would be cleaner to just take the image, and apply the Alpha from the image.
>
Comment 5 Miklos Vajna 2017-02-10 09:30:20 UTC 
Honestly, I don't remember exactly how this was supposed to work; let's just close this. Sorry. :-)