Bug Hunting Session
Bug 53505 - LibreOffice icons are larger than other app's icons in GNOME Classic
Summary: LibreOffice icons are larger than other app's icons in GNOME Classic
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
3.5.4 release
Hardware: All Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Desktop-Integration Icon-Themes
  Show dependency treegraph
 
Reported: 2012-08-14 20:23 UTC by Sanchit Gangwar
Modified: 2018-12-21 10:39 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of icons. (83.73 KB, image/png)
2012-08-14 20:23 UTC, Sanchit Gangwar
Details
A proposed patch. (11.05 KB, patch)
2012-08-16 04:08 UTC, Sanchit Gangwar
Details
24x24 icons (53.46 KB, application/x-gzip)
2012-08-16 04:09 UTC, Sanchit Gangwar
Details
24x24 hicolor icons (13.96 KB, application/x-gzip)
2012-09-18 13:06 UTC, Sanchit Gangwar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sanchit Gangwar 2012-08-14 20:23:30 UTC
Created attachment 65566 [details]
Screenshot of icons.

When using gnome-session-fallback (GNOME Classic session / gnome-panel) then LibreOffice icons are much larger image dimensions than the other icons in the menu.
Comment 1 Michael Meeks 2012-08-15 14:01:44 UTC
As I recall you(?) were asking on IRC how to help fix it - by installing smaller icons, or somesuch ?

It's entirely possible that our icons are the same size, and simply fill the surrounding bbox too well - where other icons leave space for shadows / other features (?) Or it could be that they are simple larger.

Thoughts / investigation appreciated.
Comment 2 Stefan Knorr (astron) 2012-08-15 16:09:36 UTC
Can confirm on OpenSUSE 12.1... so probably not a Ubuntu packaging bug. We probably really lack a certain icon size.
It's also a bit odd that the menu doesn't force the icon into place... so, maybe it would be a good idea to file the bug at Gnome additionally.
Comment 3 Sanchit Gangwar 2012-08-15 16:44:05 UTC
(In reply to comment #1)
> As I recall you(?) were asking on IRC how to help fix it - by installing
> smaller icons, or somesuch ?
> 
> It's entirely possible that our icons are the same size, and simply fill the
> surrounding bbox too well - where other icons leave space for shadows / other
> features (?) Or it could be that they are simple larger.
> 
> Thoughts / investigation appreciated.

Yes, I'm the same. In fact, I resized the icons to the appropriate size, but the guys at Ubuntu told me to send this bug upstream.

As for the problem, yes, it is genuine. The icons available are 16x16, 32x32, 48x48, and so on. The 24x24 icons are missing, hence the gnome-panel uses 32x32. You need to include 24x24 icons.
Comment 4 Sanchit Gangwar 2012-08-16 04:08:20 UTC
Created attachment 65624 [details]
A proposed patch.

Here is the patch, I created.
Comment 5 Sanchit Gangwar 2012-08-16 04:09:20 UTC
Created attachment 65625 [details]
24x24 icons

These are the 24x24 icons which are currently missing.
Comment 6 Stefan Knorr (astron) 2012-09-03 12:11:12 UTC
Hi Sanchit,

I am sorry, but your icons are not pixel-aligned -- meaning the horizontal and vertical lines in the icons are rather squishy/fuzzy. It is a better idea to use the official SVG icons from [1], scale the 32*32 icon down and then make sure the everything is aligned neatly. (In Inkscape, you can use the # key to enable the pixel raster. Under View > Icon Preview you can also enable a smaller preview.)
Can you try reworking those icons in this way?

[1] http://wiki.documentfoundation.org/File:LibreOffice_Initial_Icons-pre_final.svg
Comment 7 Sanchit Gangwar 2012-09-03 15:45:51 UTC
Sure I'll submit a patch as soon as possible.
Comment 8 Sanchit Gangwar 2012-09-18 13:06:44 UTC
Created attachment 67327 [details]
24x24 hicolor icons

I've added 24x24 icons again. Please have a look.
Comment 9 Björn Michaelsen 2012-12-20 20:06:25 UTC
Comment on attachment 67327 [details]
24x24 hicolor icons

@Astron: ping? Could you recheck?
Comment 10 Stefan Knorr (astron) 2012-12-21 16:21:20 UTC
Sorry for not commenting on the new icons before. Somehow, this missed me.

In any case, the revised icons are now of apparently arbitrary sizes, like 19*24 or 26*24 and still don't have proper pixel alignment... so, these aren't better.
Comment 11 Stefan Knorr (astron) 2013-04-08 21:18:22 UTC
@Björn: could you tell me where these icons need to go in the repo? By accident I just stumbled upon (almost) fitting icons in
  icon-themes/galaxy/res/lx032[42,45,46,47,49,50,51]

All they need is cutting of two pixel of shadow. Oh, and we'd still need the printer admin icon if that thing still exists.
Comment 12 Stefan Knorr (astron) 2013-04-08 21:19:00 UTC
^cutting of^cutting off
^pixel^pixels
Comment 13 QA Administrators 2015-04-19 03:23:14 UTC Comment hidden (obsolete)
Comment 14 QA Administrators 2016-09-20 09:24:37 UTC Comment hidden (obsolete)
Comment 15 andreas_k 2018-12-21 10:39:23 UTC
can someone verify it bug? all app icons are available in 16, 22, 24, 32, 48, 64, 128, 256, 512, 1024 and scalable so this bug should be closed.