Bug 67405 - Issue with comments in navigator and search, in large .odt file: comments only are 'seen' after scrolling down [with added crashes]
Summary: Issue with comments in navigator and search, in large .odt file: comments onl...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: x86 (IA32) All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-27 16:13 UTC by Marcool
Modified: 2017-02-28 16:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
"Large" odt plain-text with spread out comments (62.24 KB, application/vnd.oasis.opendocument.text)
2013-07-27 16:13 UTC, Marcool
Details
test documents (307.96 KB, application/zip)
2015-06-15 12:57 UTC, Gordo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcool 2013-07-27 16:13:29 UTC
Created attachment 83093 [details]
"Large" odt plain-text with spread out comments

Hi all,

I have been experiencing this minor bug with LibreOffice Writer for some time now (I have listed it on the most recent major release, but it was also present on all versions past 4.0 and on 3.6 also, further back I can not recall).

There is a "two sided" element to the bug, but I am fairly confident both are coming from the same issue so I will put both in this report.

The fist is this: when editing a large .odt file, which has comments spread out throughout, only comments in close proximity in file layout to where the cursor is currently set show up in the navigator until one has scrolled past other comments.

The example file allows me to produce the bug. The content is a plain-text rendering of english Wikipedia's "England" article, as of today.
To reproduce bug, follow these steps:
-Open the example file.
-Place cursor on page 1 (anywhere).
-Press F5, and in the "Comments" section (expand if needed) note how many comments are present, what they are.
-Scroll down to the last page of the document.
-The very last comment I have included in the example file is "Test Comment 2". Note how this does not show in the navigator, nor any of the intermediate comments (which are all "Com") and how, as you scroll down, or if you click in one of the "missing" comments, it appears in the navigator.

The second is this : in similar large odt with coms, when searching for a comment that is not close to the cursor before having scrolled over said comment it is unfindable.
Again, this can be reproduced with the example file:
-Open the example file.
-Open search bar (Cmd + F on a Mac).
-Type the text of the very last comment : "Test Comment 2" (non case sensitive), and hit return.
-Writer reports the text cannot be found, asks if you wish to search from the beginning, and even if you answer yes, cannot find the text despite its presence.
-For the sake of checking that other comments are searchable, search for "Test comment 1", which is on page 1, and should be found with no problem.
-Finally, scroll down to the last page, and search again for "Test Comment 2", which this time, writer succeeds in finding.

I will make one comment right now to save time: I do not think this is related to the file "discovery" operation. A simple answer could be: the comments to not appear in search or navigator because writer has not finished parsing the file. Even when it has been open for hours, the same behaviour can still be noted. In the case of the example file, navigator, after the discovering phase, can still only "see" the comment "Test Comment 1" from page 1, for instance. Likewise, the search for "Test Comment 2" fails even after the file has been open for a long period of time, and CPU usage from writer is idle (showing that the file discovery is done, since otherwise writer uses quite a bit of CPU for this particular task).

I'm available to answer any questions or to perform other checks if needed.
Thanks for a great product guys!
Regards,
Mark.
Comment 1 Marcool 2013-07-27 16:16:46 UTC
Haha... good old bugzilla has make all my "Comment #"s into links... of course, this was unintentional, and has no importance in the bug :)
Comment 2 Cor Nouws 2013-07-27 22:19:21 UTC
Hi Marcool,

thanks for describing this issue.
I can confirm that comments are only 'seen'  after you scroll donw far enough.

(Now it has to be found out when the issue showed up for the first time...)

Best, 
Cor
Comment 3 QA Administrators 2015-04-19 03:22:08 UTC Comment hidden (obsolete)
Comment 4 Gordo 2015-06-15 12:57:09 UTC
Created attachment 116557 [details]
test documents

The comments not showing in Navigator is being caused by the comment at the end of the document.  The same effect can also be achieved with a comment in bullets and numbering, tables, sections, and frames.

Opening a document that was created in 4.4.3.2 does not show the effect in 5.1.  You can beat the clock by scrolling down as soon as the document is open.  There were times that the document opened okay but closing to start centre and opening it again showed the bug.  There might even be something to do with other documents open with Navigator that may prevent the bug from showing.  Regardless, I was able to see the bug in every document that I created in each version.

Additionally, this bug also causes different types of crashes.

If you scroll down to the page with the comment at the end of the document or in one of the other examples and then hover over the comments in the Navigator then it will crash.  Sometimes you can even see a different tooltip for the comment when moving over it.

Another crash happens when placing the cursor in each comment and scrolling down to the next and so on and then placing the cursor in the text that has the naughty comment.

There is another where I just clicked in the naughty comment and into the text and back and forth and eventually it crashed.

They are hard to reproduce.

The backtraces between the two versions are slightly different.  This may be due to code that was moved so the line numbers are different.

Windows Vista 64
Version: 4.4.3.2
Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16

Version: 5.1.0.0.alpha1+
Build ID: 5fc0cbbc1254223fedf0f78c5e7539219b228697
TinderBox: Win-x86@39, Branch:master, Time: 2015-06-11_04:30:51
Comment 5 Gordo 2015-06-16 12:53:13 UTC
Um, what I said earlier...about the end of the document...and the bullets and such...  It has nothing to do with it.  It is happening without any of those cases.

Maybe it is to do with the state of the Navigator.  Leaving the Comments expanded will result in only showing the first page of comments when a document is opened again.  If the Comments are expanded before the document has fully loaded then, again, only the first page of comments are shown.  If you click in the text and then in the Navigator or if you start typing something, then the rest of the comments appear.
Comment 6 QA Administrators 2016-09-20 10:00:52 UTC Comment hidden (obsolete)
Comment 7 tera_1225 2016-09-20 18:59:58 UTC
Ok, after getting the automated "please re-check" email today, I just checked again using my same "Example file.odt" included here, and it seems the search issue is now solved, but the navigator one is still present.
So... I guess my initial assessment of these two problems coming from one source was wrong.
Not sure how to proceed from here, should this bug be closed and a new one opened? Or can this one be kept with a mention of the fact the "search" part is solved?
Comment 8 Xisco Faulí 2017-02-28 16:47:53 UTC
(In reply to tera_1225 from comment #7)
> Ok, after getting the automated "please re-check" email today, I just
> checked again using my same "Example file.odt" included here, and it seems
> the search issue is now solved, but the navigator one is still present.
> So... I guess my initial assessment of these two problems coming from one
> source was wrong.
> Not sure how to proceed from here, should this bug be closed and a new one
> opened? Or can this one be kept with a mention of the fact the "search" part
> is solved?

Hello,
Yes, please.
Test the navigator one with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ and if it's still reproducible, open a new follow-up bug.
Regards