Bug Hunting Session
Bug 69524 - EDITING Creating new frame style from selected graphic, adds properties for dimensions, and thus changes the size of images that it is applied too, which is wrong
Summary: EDITING Creating new frame style from selected graphic, adds properties for ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Styles-Frame
  Show dependency treegraph
 
Reported: 2013-09-18 12:17 UTC by Cor Nouws
Modified: 2019-06-07 06:26 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2013-09-18 12:17:57 UTC
To reproduce:

- writer document with some text
- insert graphic and change the border setting
- put focus in box Apply Style, where name 'Graphics' is shown, and type new name: 'Test1'
- set focus in text of document and insert another grafic, with different dimensions then the first one.
- while that graphic is selected, select 'Test1' from the box Apply Style

  > not only border is added, but also the size is changed!

I was pretty sure that somewhere  in the past, this did not happen. And found an old document that confirms that.

Grabbed the info from the styles.xml
"_5f_Icoontje" is the old one.
"_5f_KaderMagentaGrijs" is the one I made now in 4.1.1.2.



<style:style style:name="_5f_Icoontje" style:display-name="_Icoontje" style:family="graphic" style:parent-style-name="Graphics">
	<style:graphic-properties text:anchor-type="paragraph" svg:x="0cm" svg:y="0cm" style:wrap="dynamic" style:number-wrapped-paragraphs="no-limit" style:wrap-contour="false" style:vertical-pos="top" style:vertical-rel="paragraph-content" style:horizontal-pos="right" style:horizontal-rel="paragraph" fo:padding="0.049cm" fo:border="0.51pt solid #000080" style:shadow="none"/></style:style>


<style:style style:name="_5f_KaderMagentaGrijs" style:display-name="_KaderMagentaGrijs" style:family="graphic" style:parent-style-name="Graphics">
	<style:graphic-properties svg:width="4.657cm" fo:min-height="5.741cm" 	
	text:anchor-type="paragraph" svg:x="6.172cm" svg:y="0cm" style:wrap="dynamic" style:number-wrapped-paragraphs="no-limit" style:wrap-contour="false" style:vertical-pos="top" style:vertical-rel="paragraph-content" style:horizontal-pos="center" style:horizontal-rel="paragraph" fo:padding="0.049cm" fo:border="0.54pt solid #ff33ff" style:shadow="none"/></style:style>


Difference:
svg:width="4.657cm" fo:min-height="5.741cm"

(Also for Anchor type a vallue is added: svg:x="6.172cm"  - no idea if that cause a problem)


I see the problem already in 3.3.0. The style icoontje (properties above) has been made somewhere in 2009 or earlier...
Comment 1 Cor Nouws 2013-09-18 12:19:45 UTC
As a work around, the user can
 - first apply the style
 - then open window Graphics of the graphic and click 'original dimensions'.

But it's so great the LibreOffice offers styles and lovely that they are so useful :)
Comment 2 Cor Nouws 2013-09-18 12:30:32 UTC
And of course, create a new style in the window Styles and Formatting, based on Graphic, works too.
Though dimensions in the window are set to 0,36 cm, practical effec is that the style respects the size of the graphic.
Comment 3 Cor Nouws 2013-09-18 12:46:42 UTC
Indeed, changing the mentioned properties in the styles.xml corrects the wrong behaviour.
Comment 4 Cor Nouws 2013-11-28 14:48:50 UTC
regression from OOo, but still :(
Comment 5 Matthew Francis 2014-12-29 14:25:44 UTC
Could you please clarify if you think this is an early regression since the fork from OOo (in which case, please add Whiteboard: preBibisect), or if it was in fact present before the fork (in which case set Version: "Inherited from OOo" and remove Keywords: regression)
Comment 6 Cor Nouws 2014-12-29 16:02:26 UTC
(In reply to Matthew Francis from comment #5)
> Could you please clarify if you think this is an early regression since the
> fork from OOo 

As I wrote when submitting the issue: " I see the problem already in 3.3.0. The style icoontje (properties above) has been made somewhere in 2009 or earlier..."

So it's fair to remove 'regression' since the problem origens from OOo

Work Around: create new Style for images/frames in Dialog F11
Comment 7 Robinson Tryon (qubit) 2015-12-14 05:40:11 UTC Comment hidden (obsolete)
Comment 8 Xisco Faulí 2016-09-14 14:51:37 UTC
Only regressions should use the keyword 'preBibisect'. Removing it...
Comment 9 QA Administrators 2018-06-06 02:46:34 UTC Comment hidden (obsolete)
Comment 10 Regina Henschel 2018-06-06 08:54:58 UTC
The problem still exists in Version: 6.0.4.2 (x64)
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 8; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: CL
Comment 11 QA Administrators 2019-06-07 02:53:02 UTC Comment hidden (obsolete)
Comment 12 Cor Nouws 2019-06-07 06:26:47 UTC
unchanged in Version: 6.3.0.0.alpha1+
Build ID: 77ae0abe21f672cf4b7d2e069f1d40d20edc49a7
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-05-31_15:33:33
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded