Bug Hunting Session
Bug 70102 - RTL: Flipped toolbar button icons dont always look suitable
Summary: RTL: Flipped toolbar button icons dont always look suitable
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.2.0.0.alpha0+ Master
Hardware: Other All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 95613 114445 (view as bug list)
Depends on:
Blocks: RTL-CTL Toolbars Icon-Themes-Code-Language
  Show dependency treegraph
 
Reported: 2013-10-03 21:19 UTC by Tin Man
Modified: 2019-04-26 08:43 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments
how the toolbar looks in RTL mode in English and Arabic UIs (112.59 KB, image/png)
2014-06-25 19:20 UTC, Yousuf Philips (jay) (retired)
Details
LibreOffice 6.0 icon RTL (81.48 KB, image/png)
2018-09-10 09:35 UTC, Rizal Muttaqin
Details
Template whose use reproduces icon mirroring issues (9.44 KB, application/vnd.oasis.opendocument.text-template)
2018-10-08 23:10 UTC, Shai Berger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tin Man 2013-10-03 21:19:32 UTC
LibreOffice flips icons for e.g. line spacing, numbering, and increased indents when switching to RTL mode. This can result in icons with mirrored numerals and sometimes with incorrect appearance (e.g. the icon style may specify lighting from the top left, mirrored icons appear lit from the top right).
It'd be preferrable if separate RTL icons were used instead.

To reproduce, click the RTL button in the toolbar or press Ctrl-Shift-D.
Comment 1 Yousuf Philips (jay) (retired) 2014-06-25 19:19:42 UTC
Hi Mirek2,

It would be great if you can send in an image of how it incorrectly looks as it looks fine in my theme.
Comment 2 Yousuf Philips (jay) (retired) 2014-06-25 19:20:42 UTC
Created attachment 101757 [details]
how the toolbar looks in RTL mode in English and Arabic UIs
Comment 3 Tin Man 2014-06-25 20:51:19 UTC
(In reply to comment #2)
> Created attachment 101757 [details]
> how the toolbar looks in RTL mode in English and Arabic UIs

It's only visible in one icon in the screenshot. Take a close look at the numbering icon and you'll see that the numerals are inverted.
Comment 4 Yousuf Philips (jay) (retired) 2014-06-25 23:38:35 UTC
So other than the number list icon, are there any other icons that would need an RTL version?
Comment 5 Tin Man 2014-08-04 16:55:18 UTC
(In reply to comment #4)
> So other than the number list icon, are there any other icons that would
> need an RTL version?

All icons that are currently being flipped need to be replaced with RTL versions.

Many of those may be perfectly legible when flipped and, in some icon sets, may look exactly the same as their RTL versions would, but generally it's better practice to produce RTL versions than rely on flipped icons. For example, some icon sets are lit asymetrically (e.g. from the top left) and flipped icons look out-of-place among correctly-lit icons. Additionally, some icons that perhaps should be flipped aren't because they contain text -- superscript and subscript for example.
Comment 6 Yousuf Philips (jay) (retired) 2014-08-05 06:27:33 UTC
Adding the ux-team for their input.
Comment 7 Heiko Tietze 2014-10-22 08:19:47 UTC
Is there really need to have two versions of icons, LTR and RTL? I have never seen such an overkill, IMHO, and would rather attribute it to badly designed icons if they don't fit in RTL - not mirrored.
On the other hand it makes sense for the bullets. So why don't we prepare a special icon set for RTL, i.e. put designers in charge and not the devs.
Comment 8 Tin Man 2014-10-26 20:39:55 UTC
(In reply to Heiko Tietze from comment #7)
> Is there really need to have two versions of icons, LTR and RTL? I have
> never seen such an overkill, IMHO, and would rather attribute it to badly
> designed icons if they don't fit in RTL - not mirrored.

No, separate LTR and RTL versions are needed only for a few select icons -- those dependent on text direction. For example: undo, redo, (the new Tango icons use color to distinguish the two), superscript, subscript, bullets, numbering, and I'm sure there are some more, but it's not very many.

> On the other hand it makes sense for the bullets. So why don't we prepare a
> special icon set for RTL, i.e. put designers in charge and not the devs.

It'd be very easy to do -- we just need devs to make it so that an RTL setting prefers icons suffixed with "_rtl" and doesn't flip any icons. It'd be good to get a list of the icons that LibreOffice currently flips, so that we have a list of RTL icons to make.
Comment 9 Maxim Monastirsky 2015-11-05 18:45:05 UTC
*** Bug 95613 has been marked as a duplicate of this bug. ***
Comment 10 Robinson Tryon (qubit) 2016-08-25 05:39:05 UTC Comment hidden (obsolete)
Comment 11 Yousuf Philips (jay) (retired) 2017-10-13 14:14:24 UTC
(In reply to Tin Man from comment #8)
> No, separate LTR and RTL versions are needed only for a few select icons --
> those dependent on text direction. For example: undo, redo, (the new Tango
> icons use color to distinguish the two), superscript, subscript, bullets,
> numbering, and I'm sure there are some more, but it's not very many.

Undo, redo, and bullets look fine to me reversed. Cant reverse or do anything about superscript and subscript as it uses english letters. Numbering uses '1' and '2' which when reserved are flipped which it shouldnt, so this should be fixed.

> It'd be very easy to do -- we just need devs to make it so that an RTL
> setting prefers icons suffixed with "_rtl" and doesn't flip any icons. It'd
> be good to get a list of the icons that LibreOffice currently flips, so that
> we have a list of RTL icons to make.

Maxim: What do you think of this solution of switching in rtl icons, as flipping the current one doesnt generate a suitable icon?
Comment 12 Maxim Monastirsky 2017-12-16 21:03:13 UTC
*** Bug 114445 has been marked as a duplicate of this bug. ***
Comment 13 Yousuf Philips (jay) (retired) 2017-12-16 21:41:47 UTC
So this doesnt affect breeze and galaxy icon themes which use roman numerals in the numbering list icon, but affects other icon themes that use 1 and 2 in their icon.
Comment 14 Rizal Muttaqin 2018-09-10 09:35:21 UTC
Created attachment 144770 [details]
LibreOffice 6.0 icon RTL

In the 6.0 version, this is not reproducable

إصدارة: Version: 6.0.6.2
Build ID: 1:6.0.6-0ubuntu0.16.04.1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: id-ID (id_ID.UTF-8); Calc: group
Comment 15 Eyal Rozenberg 2018-09-17 17:33:11 UTC
From a user's perspective, I suggest great care be taken to asses users' reaction to icon direction flipping. Some may like it, some may not.

Anyway, things haven't changed as of 6.1.1.2
Comment 16 Shai Berger 2018-10-08 23:10:37 UTC
Created attachment 145501 [details]
Template whose use reproduces icon mirroring issues

Hi,

I cannot reproduce the bug when opening a blank new document, but it does show up if I use the template I am attaching here.

Version: 6.1.2.1
Build ID: 1:6.1.2-1
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: gtk3; 
Locale: en-US (en_IL.UTF-8); Calc: group threaded

(en_IL is a bit of a fabricated locale, but I've tried with en_US.UTF-8 and he_IL.UTF-8 and it didn't make any difference)
Comment 17 Boaz Dodin 2019-03-07 19:31:22 UTC
The numbered list icon in RTL LO 6.2.2.1 on Windows 10 1803 is wrong (mirrored 1 and 2 numbers), Colibre theme.

As this pretty old bug, I am wondering if new bug should be opened, for the specific icon issue?
Comment 18 Xisco Faulí 2019-03-20 18:36:13 UTC
(In reply to Boaz Dodin from comment #17)
> The numbered list icon in RTL LO 6.2.2.1 on Windows 10 1803 is wrong
> (mirrored 1 and 2 numbers), Colibre theme.
> 
> As this pretty old bug, I am wondering if new bug should be opened, for the
> specific icon issue?

I think this issue still applies...
Comment 19 andreas_k 2019-04-24 09:41:34 UTC
I submitted today an patch where I add rtl icon support in the language folder where flipping isn't useful. For me that's an good solution, cause it is language specific and don't need coding work.

I hope it will work fine for everybody.
Comment 20 andreas_k 2019-04-24 09:50:22 UTC
fix:
https://gerrit.libreoffice.org/#/c/71147/

Change-Id: I3114afc6856f2a44127b2959408337c464d9ff88
Comment 21 Buovjaga 2019-04-24 12:30:43 UTC
Tested by launching with SAL_RTL_ENABLED=1 and the numbered list icon is ok in all icon themes.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: cfbb223d5666cb803539ac98918ff39b27efc6e7
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 24 April 2019
Comment 22 andreas_k 2019-04-24 20:37:20 UTC
awesome so best practice to fix this bugs is to add language specific icons to the cmd folder.
Comment 23 Shai Berger 2019-04-24 21:15:04 UTC
(In reply to Buovjaga from comment #21)
> Tested by launching with SAL_RTL_ENABLED=1 and the numbered list icon is ok
> in all icon themes.
> 

Hi, thanks for your help, although it is unclear to me: 

1) Did you test with Andreas` patch?
2) Did you try the template I attached?

Thanks,
Shai
Comment 24 Buovjaga 2019-04-24 22:03:43 UTC
Ok, apologies, for some reason I ignored completely the original description for this. This does not need an RTL UI - I can reproduce the problem simply by clicking the RTL button.

Andreas's commit was in my build.
Comment 25 Rizal Muttaqin 2019-04-26 08:03:48 UTC
Andreas patch is just related to Arabic UI, not RTL input. So, we need a dev touch here. My suggestion is to replace flipping behavior with pointing to an RTL icon UI instead. Does the coding work is considerable as a easyhack?
Comment 26 andreas_k 2019-04-26 08:43:29 UTC
when it's an easyhack than an codepointer is needed.