Bug 73799 - Filtering conditions are not translatable
Summary: Filtering conditions are not translatable
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
4.0.0.2 rc
Hardware: All All
: medium normal
Assignee: Kohei Yoshida
URL:
Whiteboard: target:4.3.0 target:4.2.1
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-19 15:44 UTC by OKANO Takayoshi
Modified: 2014-01-19 19:18 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description OKANO Takayoshi 2014-01-19 15:44:55 UTC
in Calc,
Date -> Filter -> Standard Filter...,
options for "Condition" pulldown menu (e.g. "Does not contain"; defined in core/sc/uiconfig/scalc/ui/standardfilterdialog.ui ?)
are not translatable.

pointed out at http://listarchives.libreoffice.org/ja/discuss/msg02779.html
(written in Japanese)
Comment 1 Cor Nouws 2014-01-19 17:09:00 UTC
Hi Takayoshi,

Thanks for the issue.
I happen to have seen the same some days ago. And indeed in Pootle I can't find for example that string. I set it to new.

Best,
Cor
Comment 2 Kohei Yoshida 2014-01-19 17:34:39 UTC
I'm not an expert on the new .ui based dialog, but is it just a matter of setting the "translatable" property of the <item> elements to "yes"?  If so, I can do this real quick.
Comment 3 Commit Notification 2014-01-19 17:42:18 UTC
Kohei Yoshida committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6d7a4e5744c6ce5f1362b659464fb94465c2cb67

fdo#73799: Make some items in the filter dialogs translatable.



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2014-01-19 17:55:03 UTC
Kohei Yoshida committed a patch related to this issue.
It has been pushed to "libreoffice-4-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=00dbc2c847cb88a8a46fdec0b09973e460139636&h=libreoffice-4-2

fdo#73799: Make some items in the filter dialogs translatable.


It will be available in LibreOffice 4.2.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Kohei Yoshida 2014-01-19 17:59:02 UTC
I guess I'll assign this to myself.
Comment 6 Kohei Yoshida 2014-01-19 18:23:26 UTC
Marking this fixed.
Comment 7 Cor Nouws 2014-01-19 19:18:32 UTC
thanks Kohei!