Bug 74934 - 'Install' button in update dialog is never activated
Summary: 'Install' button in update dialog is never activated
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: high enhancement
Assignee: Julien Nabet
URL: https://mmohrhard.wordpress.com/2017/...
Whiteboard: target:24.2.0 target:7.6.0.2
Keywords:
: 62637 99268 105619 125451 144426 151466 (view as bug list)
Depends on:
Blocks: Automatic-Updater Updates
  Show dependency treegraph
 
Reported: 2014-02-13 15:10 UTC by Jan Holesovsky
Modified: 2023-07-19 04:32 UTC (History)
22 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Holesovsky 2014-02-13 15:10:22 UTC
Currently the 'Install' button in the update dialog is never activated.  It is because we do not provide automatic download of new version.

In order to be able to have this functionality, we need to make sure that the download is safe - that the cannot get a binary from some malicious site instead.

The code needs review & update in case there are dangerous bits there; then we can enable this.
Comment 1 Jan Holesovsky 2014-02-13 15:10:46 UTC
MAB - as discussed at the ESC.
Comment 2 Jan Holesovsky 2014-02-13 15:11:49 UTC
Short term, we should at least update the help:

https://help.libreoffice.org/swriter/EXTENSIONS_HID_CHECK_FOR_UPD_DLG
Comment 3 Björn Michaelsen 2014-03-16 01:12:34 UTC
Fix priority for MABs.
Comment 4 tommy27 2014-11-29 17:47:54 UTC
@Jan
is this MAB still reproducible with 4.3.x releases?
Comment 5 Robinson Tryon (qubit) 2014-12-07 19:10:59 UTC
(In reply to Jan Holesovsky from comment #0)
> Currently the 'Install' button in the update dialog is never activated. 

CONFIRMED with 4.3.2.2 + Ubuntu 14.04

REPRO:
1) Open LibreOffice
2) Help -> Check for updates.

RESULT:
LO 4.3.4 is offered for download, but the 'Install' button stays grayed-out
Comment 6 Adolfo Jayme Barrientos 2015-01-17 09:37:14 UTC
Can we consider using Sparkle/WinSparkle instead?
Comment 7 Adolfo Jayme Barrientos 2015-02-09 07:53:55 UTC
(In reply to Adolfo Jayme from comment #6)
> Can we consider using Sparkle/WinSparkle instead?

That could be another idea for GSoC. Integrating Sparkle would fix some long-requested enhancements: it supports diff-based (incremental) updates, avoiding huge downloads (bug 54242); it supports displaying release notes (bug 69042)… Also, Sparkle is an actively maintained project, and integrating it would reduce the burden in maintaining our custom mechanisms.
Comment 8 tommy27 2015-06-18 20:26:27 UTC
hi Adolfo, is the "Reuse Mozilla's rolling update mechanism for LibreOffice" in the GSOC 2015 projects something related to this?

https://wiki.documentfoundation.org/Development/GSoC/2015
Comment 9 steve 2015-10-25 15:12:25 UTC
Update from GSoC 2015 wrapup from
http://bosdonnat.fr/gsoc-2015-wrap-up.html


Mozilla update system for LibreOffice from Nathan Yi

Although Nathan did not have time to fully implement the UI and server-side backend components of the project, he managed to do in-place upgrades of LibreOffice using full and partial (version-to-version) patches. These patches can optionally be signed for secure transport over the Internet.

Wiki entry: https://wiki.documentfoundation.org/Development/GSoC/Ideas#Reuse_Mozilla.27s_rolling_update_mechanism_for_LibreOffice
Comment 10 steve 2016-04-13 12:32:29 UTC
*** Bug 99268 has been marked as a duplicate of this bug. ***
Comment 11 Adolfo Jayme Barrientos 2016-04-28 02:34:21 UTC
*** Bug 62637 has been marked as a duplicate of this bug. ***
Comment 12 steve 2017-01-31 11:20:34 UTC
*** Bug 105619 has been marked as a duplicate of this bug. ***
Comment 13 Patrick 2017-12-29 23:09:49 UTC
I am curious about the status of this issue. It's been active since 2014 and no apparent progress or news since 2015.
Comment 14 steve 2018-01-07 12:13:23 UTC
linux and windows have seen work on using MAR updater for LO. Sadly that effort has not taken macOS into account.
Comment 15 Rishabh Kalra 2018-02-14 13:24:15 UTC
Is this issue still open?
Comment 16 Sheldon Kelly 2018-03-08 08:13:47 UTC
I am currently using LibreOffice 6.0.1 on Win 10 and I am still experiencing this bug.
Comment 17 yinjui 2018-11-29 08:01:53 UTC
Still exists in version: 6.3.0.0.alpha0+ (x64)

Build ID: 0f25a3c36f27fd51453b9a9115f236b83c143684
CPU threads: 8; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-11-27_20:06:55
Locale: zh-TW (zh_TW); UI-Language: en-US
Calc: threaded
Comment 18 Xisco Faulí 2018-11-29 09:28:22 UTC
Automatic updates were implemented by Markus Mohrhard, please see
- https://mmohrhard.wordpress.com/2017/08/22/announcing-automatically-updating-daily-windows-libreoffice-builds/
- https://mmohrhard.wordpress.com/2017/06/21/announcing-automatically-updating-libreoffice-builds/

although they are not used in production releases, yet.
Comment 19 Xisco Faulí 2019-11-29 13:27:29 UTC
Changing priority back to 'medium' since the number of duplicates is lower than 5
Comment 20 Thomas Bertels 2023-02-01 09:13:57 UTC
*** Bug 125451 has been marked as a duplicate of this bug. ***
Comment 21 Thomas Bertels 2023-02-01 09:19:42 UTC
*** Bug 144426 has been marked as a duplicate of this bug. ***
Comment 22 Maverick 2023-02-03 11:48:24 UTC
Considering the duplicates, shouldn't the bug priority be updated?
Comment 23 Stéphane Guillou (stragu) 2023-03-13 22:36:01 UTC
*** Bug 151466 has been marked as a duplicate of this bug. ***
Comment 24 Julien Nabet 2023-03-23 08:06:57 UTC
What about removing the "install" button waiting for the implementation of the lacking code to implement it?
Comment 25 Thomas H. Schmidt 2023-06-12 10:43:02 UTC
What can I do to promote this feature?
There are lots of good reasons to have this feature implemented.
For me it's a kind of basic feature for all user-friendly and safe software to allow for automatic upgrades (see https://ask.libreoffice.org/t/wann-wird-das-automatische-update-endlich-implementiert/43530 for some thoughts on this).
Comment 26 Julien Nabet 2023-06-12 15:30:45 UTC
Miklos: would it be possible ESC takes a look at this one?
I mean:
1) Do we still want this feature or should we just use update to know if there's an update (and the user does the job)?

2) Let's say I got 7.4.5 installed, do we want LO detects there's 7.4.7 or should it detect 7.5.4 ?

3) Depending on the OS, the install can fail (eg: on Linux, I prefer trusting repo manager since a dependency may lack) so is it only for Windows (and perhaps macOS?)?

4) What's the status of the current implementation in LO?
Reading https://mmohrhard.wordpress.com/2017/08/22/announcing-automatically-updating-daily-windows-libreoffice-builds/ it seems there are still work to do but not sure Markus would work on it? Above all it talks about daily builds, it's very specific. I don't expect someone who has important documents should give a try to a dev version only if very clearly informed.

5) if we enable this feature, who will treat the bugtrackers related to this? I may be wrong but only Markus was working on it, would he still want to help here? Did he have some backup who would help if it's not the case?
IMHO, if nobody is volunteer to work on this, the feature should be removed, no need to pile up bugs => less disappointment for users, less work for QA.
Comment 27 Miklos Vajna 2023-06-13 06:47:11 UTC
Will add it to the agenda. My memory is that Markus did this based on the Mozilla updater, but that didn't work out, there was a TDF tender to try this again (based on lessons from the first one), but TDF decided to not award that to anyone, and currently they are working on this year's tender budget.

But possibly I forgot about something, I'll link the minutes here in 2 days.
Comment 28 Miklos Vajna 2023-07-13 14:52:18 UTC
Sorry it took this long, unexpected events delayed this. Today's ESC minutes:

https://lists.freedesktop.org/archives/libreoffice/2023-July/090623.html
Comment 29 Julien Nabet 2023-07-14 07:44:43 UTC
(In reply to Miklos Vajna from comment #28)
> Sorry it took this long, unexpected events delayed this. Today's ESC minutes:
> 
> https://lists.freedesktop.org/archives/libreoffice/2023-July/090623.html

I read the ESC but what's the conclusion? Eg: can we consider since there's no conflict we can remove the "Install" button or even the whole part?
Comment 30 V Stuart Foote 2023-07-14 13:20:50 UTC
(In reply to Julien Nabet from comment #29)
> (In reply to Miklos Vajna from comment #28)
> > Sorry it took this long, unexpected events delayed this. Today's ESC minutes:
> > 
> > https://lists.freedesktop.org/archives/libreoffice/2023-July/090623.html
> 
> I read the ESC but what's the conclusion? Eg: can we consider since there's
> no conflict we can remove the "Install" button or even the whole part?

+1 to simply *remove* the 'Install' button (for now) absent MAR or other "incremental" updating, at which point the action would become 'Apply' or 'Update' and maybe could be moved into the 'About...' dialog.

Otherwise the 'Download' button remains a redirection to the project download page(s). But in reality with a little refactoring could become a build time adjustment for other community packagers: PortableApps, Flatpak, Snap, AppImage to link to and promote their release channels. 

There are better ways to drive donation campaign(s) than the downloads landing page.
Comment 31 Miklos Vajna 2023-07-17 07:01:39 UTC
Yes, probably you can go ahead and remove that button for now. Thanks.
Comment 32 Julien Nabet 2023-07-17 08:55:40 UTC
I've submitted this to remove Install button and related:
https://gerrit.libreoffice.org/c/core/+/154515
Comment 33 Commit Notification 2023-07-17 11:41:06 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e43d5776fee7c89029389fcc3b8011d041033108

tdf#74934: remove Install button and related

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 34 Julien Nabet 2023-07-17 11:41:33 UTC
Patch for 7.6 waiting for review here:
https://gerrit.libreoffice.org/c/core/+/154467
Comment 35 Commit Notification 2023-07-19 04:32:34 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/7468041cd84d21297a12574e385ea3ff166fc134

tdf#74934: remove Install button and related

It will be available in 7.6.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.