Bug 81740 - Toolbars Should Not Contain Checkboxes
Summary: Toolbars Should Not Contain Checkboxes
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.3.0.1 rc
Hardware: Other All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 83321 83329 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-25 10:49 UTC by Tin Man
Modified: 2018-11-06 11:25 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Current LO find bar (274 bytes, image/png)
2014-07-25 20:50 UTC, Tin Man
Details
Current LO find bar (11.99 KB, image/png)
2014-07-25 20:52 UTC, Tin Man
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tin Man 2014-07-25 10:49:35 UTC
Currently, the "Find" toolbar contains a "Match Case" checkbox item.
However, check boxes should never be used in a toolbar -- buttons should be used instead (in the same way that "Bold", "Italicize", and "Underline" are buttons, not checkboxes).
Please convert any toolbar checkboxes, including the "Match Case" one, to buttons.
Comment 1 tommy27 2014-07-25 12:09:16 UTC
would you please post a screenshot?
Comment 2 Kevin Suo 2014-07-25 13:56:53 UTC
(In reply to comment #1)
> would you please post a screenshot?

@tommy, Mirek is talking about the "Match case" checkbox when you "CTRL+F" in writer.

@Mirek: I dont think this is a bug. 
A button is an action (it applies bold/Italicize/underline to text/paragraph). 
A checkbox is an option (For the "match case" one, it tells the "find" action that you want to match case when you find)

It makes no sense to convert the "match case" to a button. How can it be implemented? what's the advantage?
Comment 3 Urmas 2014-07-25 14:51:42 UTC
Exactly like the Bold button does, like Visual Studio editor does, etc.
Comment 4 Tin Man 2014-07-25 20:47:09 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > would you please post a screenshot?
> 
> @tommy, Mirek is talking about the "Match case" checkbox when you "CTRL+F"
> in writer.
> 
> @Mirek: I dont think this is a bug. 
> A button is an action (it applies bold/Italicize/underline to
> text/paragraph). 
> A checkbox is an option (For the "match case" one, it tells the "find"
> action that you want to match case when you find)
> It makes no sense to convert the "match case" to a button. How can it be
> implemented?

As a button, which shouldn't really be that hard, considering buttons are a toolbar's specialty and . If you'd like to see an actual implementation, take a look at the Find bar: Firefox (25+). A screenshot from the web: https://3.bp.blogspot.com/-0lhD-hxtbw4/UkMjVSy2KVI/AAAAAAAAAKA/5iFxZoeu3zE/s1600/findbar1.png

> what's the advantage?

Well, it's mostly superficial. Labels of checkboxes in toolbars right now don't have the same size as button labels and that makes toolbars with both look inconsistent. (I'll attach a screenshot.)

Secondly, it has to do with perceived target area. Because checkbox labels aren't always actionable, the perceived target area may for some users be just the check box and not its label. With a button, it's clear that the whole button is actionable.
Comment 5 Tin Man 2014-07-25 20:50:18 UTC
Created attachment 103472 [details]
Current LO find bar
Comment 6 Tin Man 2014-07-25 20:52:38 UTC
Created attachment 103473 [details]
Current LO find bar
Comment 7 Adolfo Jayme Barrientos 2014-09-01 21:37:06 UTC
*** Bug 83321 has been marked as a duplicate of this bug. ***
Comment 8 Adolfo Jayme Barrientos 2014-09-27 06:21:43 UTC
*** Bug 83329 has been marked as a duplicate of this bug. ***
Comment 9 QA Administrators 2015-10-14 19:58:20 UTC Comment hidden (obsolete)
Comment 10 Adolfo Jayme Barrientos 2015-10-15 18:15:03 UTC
The enhancement request still stands and is valid, but I’m not convinced of its alleged advantages (on the “perceived click area”) anymore – not that I were ever actually very convinced of it.
Comment 11 QA Administrators 2016-11-08 11:41:50 UTC Comment hidden (obsolete)
Comment 12 Roman Kuznetsov 2018-11-06 11:19:20 UTC
Heiko, what do you think about this "problem"?
Comment 13 Heiko Tietze 2018-11-06 11:25:41 UTC
(In reply to Roman Kuznetsov from comment #12)
> Heiko, what do you think about this "problem"?

It's true that toolbars must not contain of other controls but buttons. But guidelines also must not be strict and exceptions should be allowed. The Find toobar is such a case: a temporary toolbar, clear interaction, known for long. So we better set this issue as WFM.