Bug 82234 - EDITING: Indent size is added to tab stop positions silently (and inconsistently)
Summary: EDITING: Indent size is added to tab stop positions silently (and inconsisten...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 152240 154925 (view as bug list)
Depends on:
Blocks: Tab-Stops Paragraph-Indent
  Show dependency treegraph
 
Reported: 2014-08-06 08:22 UTC by Antanas
Modified: 2023-10-29 20:24 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
test ODT (11.46 KB, application/vnd.oasis.opendocument.text)
2023-09-05 08:51 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antanas 2014-08-06 08:22:19 UTC
This is an oldish bug (from the LO project start, maybe older) but I did not found it filed.
How to reproduce: 
format a paragraph with indent before text (left side), add two or more tab stops (remember tab stops position values).

For example –
Indent befor text: 1 cm;
Tabs positions: 3 cm, 5 cm.

(Re)open menu Format>Paragraph>Tabs and alter desired tab position (say 3 cm) options (Type, Fill). Hit OK.

UNexpected result:
Indent befor text: 1 cm;
Tabs positions: 4 cm, 5 cm.

Lets set indent before text to 2 cm.

Result (expected):
Indent befor text: 2 cm;
Tabs positions: 5 cm, 6 cm.

Then alter options of the second tab position (5 cm). 

UNexpected result:
Indent befor text: 2 cm;
Tabs positions: 5 cm, 8 cm.

Conclusion: the value of indent is allways added to edited tab position, when there are two or more tabs stops.
Comment 1 Yousuf Philips (jay) (retired) 2014-08-11 00:03:14 UTC
Hello Antanas,

Thank you for submitting the bug. I can confirm that the bug is available in 4.2.7, 4.3.2, and master.

Steps:
1) Open Writer
2) right-click > Paragraph
3) in indents tab, set indent before text to 1cm
4) in tabs tab, add a tab position at 3cm
5) press OK
6) tab position will be set to 4cm
Comment 2 Antanas 2014-08-11 08:27:54 UTC
Hello Jay,

(In reply to comment #1)
> Hello Antanas,
> 
> Thank you for submitting the bug. I can confirm that the bug is available in
> 4.2.7, 4.3.2, and master.
> 
> Steps:
> 1) Open Writer
> 2) right-click > Paragraph
> 3) in indents tab, set indent before text to 1cm
> 4) in tabs tab, add a tab position at 3cm
> 5) press OK
> 6) tab position will be set to 4cm

You are describing a different case and *may*be* an intended behavoir (there is still 3 cm between paragraph's left side and tab-stop). At least, the 4 cm tab position remains intact after returning editing of tab properties. 

In my original bug description (using two or more tab-stops) tab position moves further *each*time* you are editing tab properties.
Therefore I'm not fully agree with your version of the bug summary.
Comment 3 Yousuf Philips (jay) (retired) 2014-08-11 15:26:18 UTC
(In reply to comment #2)
> Hello Jay,

Hi Antanas,

> You are describing a different case and *may*be* an intended behavoir (there
> is still 3 cm between paragraph's left side and tab-stop). At least, the 4
> cm tab position remains intact after returning editing of tab properties. 

I dont think this should be the intended behaviour as the values set in the tab page should be absolute values and not dependent on the indent value.

> In my original bug description (using two or more tab-stops) tab position
> moves further *each*time* you are editing tab properties.
> Therefore I'm not fully agree with your version of the bug summary.

I can still reproduce your bug with doing it for one tab stop.
Comment 4 Antanas 2014-08-11 16:33:10 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Hello Jay,
> 
> Hi Antanas,
> 
> > You are describing a different case and *may*be* an intended behavoir (there
> > is still 3 cm between paragraph's left side and tab-stop). At least, the 4
> > cm tab position remains intact after returning editing of tab properties. 
> 
> I dont think this should be the intended behaviour as the values set in the
> tab page should be absolute values and not dependent on the indent value.
> 
> > In my original bug description (using two or more tab-stops) tab position
> > moves further *each*time* you are editing tab properties.
> > Therefore I'm not fully agree with your version of the bug summary.
> 
> I can still reproduce your bug with doing it for one tab stop.

Not exactly. If you extend your bug reproduction – open paragraph formatting once again and set e. g. tab fill character to "dot" – the tab position remains as it was before. Is it true?
By having two or more tab positions, the last (right-most) tab position each time increments by value of left indent. 

P.S. I just noticed that if I set paragraph's left indent to arbitrary non-zero value and add two or more tab positions – all in one take, by pressing <OK> one tab position is lost.
Comment 5 Yousuf Philips (jay) (retired) 2014-08-11 20:48:50 UTC
(In reply to comment #4)
> Not exactly. If you extend your bug reproduction – open paragraph formatting
> once again and set e. g. tab fill character to "dot" – the tab position
> remains as it was before. Is it true?
> By having two or more tab positions, the last (right-most) tab position each
> time increments by value of left indent. 

When you open up the dialog again, you have to first select the entry in the position list and then change its properties, or else it is thinking that your modifying the options of a new entry you are going to add.

> P.S. I just noticed that if I set paragraph's left indent to arbitrary
> non-zero value and add two or more tab positions – all in one take, by
> pressing <OK> one tab position is lost.

I had noticed that as well after working on your bug and filed a bug for it (bug 82436). :D
Comment 6 QA Administrators 2015-09-04 02:48:09 UTC Comment hidden (obsolete)
Comment 7 Antanas 2015-09-04 07:17:21 UTC
The bug is still reproducible in LibreOffice 5.0.1.2 00m0(Build:2) using Ubuntu 14.04 LTS 32 bit
Comment 8 QA Administrators 2016-09-20 10:29:11 UTC Comment hidden (obsolete)
Comment 9 Antanas 2016-09-22 09:55:11 UTC
The original bug is still present in LibreOffice 5.2.1.2 20m0(Build:2)
Ubuntu 14.04.5 LTS
and
Ubuntu 16.04.1 LTS
Comment 10 QA Administrators 2018-06-13 02:36:36 UTC Comment hidden (obsolete)
Comment 11 QA Administrators 2020-06-13 03:43:01 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2022-06-14 03:28:21 UTC Comment hidden (obsolete)
Comment 13 Dieter 2023-05-06 12:04:11 UTC
*** Bug 154925 has been marked as a duplicate of this bug. ***
Comment 14 Dieter 2023-05-06 12:07:53 UTC
Still present in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 006b35d50024b1932d84380b5d2fec1f7066bccd
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded
Comment 15 Regina Henschel 2023-08-07 20:00:28 UTC
The fact whether the tab position is relative to the indent is determined by the setting TabsRelativeToIndent in the subdocument settings.xml. For documents originally created in LibreOffice its default value is "true", for documents imported from docx the value is "false". There is currently no UI for this setting. You need a macro or edit the markup in the file source to change it.

In ODF 1.4 this setting will belong to the paragraph style.
Comment 16 Stéphane Guillou (stragu) 2023-09-05 08:51:37 UTC
Created attachment 189364 [details]
test ODT

(In reply to Regina Henschel from comment #15)
> The fact whether the tab position is relative to the indent is determined by
> the setting TabsRelativeToIndent in the subdocument settings.xml. For
> documents originally created in LibreOffice its default value is "true", for
> documents imported from docx the value is "false". There is currently no UI
> for this setting. You need a macro or edit the markup in the file source to
> change it.
> 
> In ODF 1.4 this setting will belong to the paragraph style.

The tab position being relative to the indent is fine, and having UI to change that is welcome, but the bug here is that the indent value is added to the tab stop position for all but the first custom tab stop when it's edited - even when the position isn't touched. See for example with the attachment:


Steps to reproduce:
1. Open attachment, created in LibreOffice, which has:
- indent at 1 cm
- 3 tab stops at 2, 4 and 6 cm.
2. In Format > Paragraph > Tabs, change the tap Type of all three tabs to any other, e.g. "Right". Click OK.
Result A: First tab stop does not move; second and third tab stops get 1 extra cm in their position.
3. In Format > Paragraph > Tabs, change type back to "Left" for all three. Click OK.
Result B: all three tabs get an extra 1 cm in position.

What needs to be fixed:
- Inconsistency in how the first tab behaves compared to others
- If tab position is relative according to document setting, make it transparent (with a hint in the dialog telling the user what the value is exactly) and do not add the indent size _every single time_ the tabs are modified.

Tested in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cc7d6211bc01e5ec84dbad542605d2e93dea925c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 17 Stéphane Guillou (stragu) 2023-09-05 08:59:33 UTC
(In reply to Stéphane Guillou (stragu) from comment #16)
> 3. In Format > Paragraph > Tabs, change type back to "Left" for all three.
> Click OK.
> Result B: all three tabs get an extra 1 cm in position.

Checking once more, Result B is again like Result A, so you can ignore that. Fact is: indent value keeps being added at each tab modification even if the position value isn't touched.
Comment 18 Antanas 2023-09-12 09:33:59 UTC
Hi testers,

we are in the tenth year after the bug submission by me and still no resolution.
Thank you Stéphane for the detalisation.
The bug persists.

Version: 7.4.7.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: lt-LT (lt_LT.UTF-8); UI: lt-LT
Ubuntu package version: 1:7.4.7~rc2-0ubuntu0.20.04.1~lo1
Calc: threaded
Comment 19 Dieter 2023-10-29 20:24:05 UTC
*** Bug 152240 has been marked as a duplicate of this bug. ***