Bug 85263 - same shortcuts for Company and Cancel in "Tools/Options/User Data"
Summary: same shortcuts for Company and Cancel in "Tools/Options/User Data"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.4.0.0.alpha0+ Master
Hardware: x86-64 (AMD64) Linux (All)
: medium enhancement
Assignee: Gabor Kelemen (allotropia)
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Options-Dialog-UserData
  Show dependency treegraph
 
Reported: 2014-10-21 02:27 UTC by Tim Lloyd
Modified: 2023-09-27 09:50 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Company and cancel both use ALT-C (61.95 KB, image/png)
2014-10-21 21:17 UTC, Tim Lloyd
Details
Win7x64 screenshot NoRepro (14.62 KB, image/png)
2014-10-23 05:10 UTC, tommy27
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Lloyd 2014-10-21 02:27:19 UTC
Irritation more than anything else and I have flagged as an enhancement. 

Under Fedora 21 (LO4.4.0.0) head to Tools→Options and the shortcut for both Company & Cancel is <Alt>C. This is misleading when you want to cancel (control goes to company first).

I looked at 4.1.1.2 under Fedora and that has the same features as 4.4.

Under XP (LO4.2.0.4) there is no shortcut to cancel.

I have a VM running Centos 6 which is bundled with OOo and version 3.2.1 has the same features as XP.

Would it be an easy hack to allocate <Alt>A as a shortcut to cancel?
Comment 1 tommy27 2014-10-21 04:36:39 UTC
I don't understand...
I'm on Win7x64 and if I take a look at "Tools/Customize/Keyboard/Writer" I see that the "Alt+C" shortcut is not assigned to anything.
Comment 2 Tim Lloyd 2014-10-21 04:58:49 UTC
LOL tools->customize crashes 4.4. I guess that is for another bug report :)

The specific screen I was referring to was tools->Options->LibreOffice->User Data (apologies I should have been more specific). Not sure how to get to Tools->customize->keyboard->writer but "cancel" does not seem to have a shortcut on Windows.

I see my mistake now and I was being too hasty...the "cancel" button is always allocated the shortcut "ALT+C" (on the RPM version anyway). In the case of "user data" "company" is also allocated "ALT+C".

I'll leave this up to the devs to decide whether it is worth allocating an alternative shortcut to "company" (which will then lead to an inconsistency between RPM & windows).
Comment 3 tommy27 2014-10-21 05:11:24 UTC
(In reply to Tim Lloyd from comment #2)
> LOL tools->customize crashes 4.4. I guess that is for another bug report :)

I see no crash under Win7x64, but please file a new report about this telling the exact 4.4 build you are using (copy data from Help/about LibOdev)

> The specific screen I was referring to was tools->Options->LibreOffice->User
> Data (apologies I should have been more specific). Not sure how to get to
> Tools->customize->keyboard->writer but "cancel" does not seem to have a
> shortcut on Windows.
> 
> I see my mistake now and I was being too hasty...the "cancel" button is
> always allocated the shortcut "ALT+C" (on the RPM version anyway). In the
> case of "user data" "company" is also allocated "ALT+C".
> 

please post a screenshot of those shortcut allocations.
Comment 4 Tim Lloyd 2014-10-21 21:17:20 UTC
Created attachment 108214 [details]
Company and cancel both use ALT-C

Tools-Options on Fedora Linux. The buttons "company" & "comment" both use ALT-C
Comment 5 tommy27 2014-10-22 13:32:40 UTC
Ok thanks 4 screenshot... now I understand we were talking of different things...

I thought you were complaining of the general settings of shortcuts that you find under "Tools/Customize/Keyboard/Writer" 

now I see that the issue is about the keyboard shortcuts to edit the form fields of the <Alt+C> shortcuts ot the "Tools/Options/UserData" where the letter "C" is underlined either for Company and Cancel

edited summary notes to clarify things

I have italian GUI so there's not that issue.
I'll retest this evening with an english GUI
Comment 6 tommy27 2014-10-23 05:10:55 UTC
Created attachment 108275 [details]
Win7x64 screenshot NoRepro

see my screenshot 
not reproducible under Win7x64 using 4.4.0.0.alpha0+
Build ID: 3e2bd1e4022e25b77bcc8eba5e02c1adc57008a1
TinderBox: Win-x86@42, Branch:master, Time: 2014-10-16_01:04:13

maybe the bug is Linux specific.
did you try installing a more recent daily build?

I'll CC some QA Linux users to CC list as well.
Comment 7 Tim Lloyd 2014-10-23 05:25:21 UTC
Yup, as noted in the original report...cancel does not have a keyboard shortcut under windows :)
Comment 8 Yousuf Philips (jay) (retired) 2014-10-24 00:41:08 UTC
There are a number of dialogs that have duplicate shortcuts with the same letter and pressing the shortcut multiple times goes between them. You can see this in the spellcheck dialog as you have <Alt>C on both cancel and correct buttons.
Comment 9 sophie 2014-10-28 14:15:22 UTC
Hi, confirmed under Ubuntu also. See the workaround indicated by Jay - Set as New - Sophie
Comment 10 Commit Notification 2023-09-26 14:28:12 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e0021031f6cb0c52892142d5753b222d571acf49

tdf#85263 Resolve accelerator collision in Options - User Data page

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.