Bug 85610 - Track Changes does not keep Footnote marked as deleted
Summary: Track Changes does not keep Footnote marked as deleted
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: Other Windows (All)
: medium normal
Assignee: Not Assigned
Whiteboard: target:7.4.0
Depends on:
Blocks: Track-Changes Footnote-Endnote
  Show dependency treegraph
Reported: 2014-10-29 16:22 UTC by Ellis Farmer
Modified: 2022-04-28 08:18 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Page 5 Footnote Num 3 will not stay marked as deleted (296.87 KB, application/pdf)
2014-10-29 16:22 UTC, Ellis Farmer
Very similar problem where a Save is reverting changes. (21.88 KB, application/vnd.oasis.opendocument.text)
2015-03-16 13:43 UTC, Ellis Farmer
Even simpler test document (9.24 KB, application/vnd.oasis.opendocument.text)
2019-08-22 07:44 UTC, Gabor Kelemen (allotropia)
Screenshot of the example document after deleting the footnote (38.75 KB, image/png)
2019-08-22 07:46 UTC, Gabor Kelemen (allotropia)
The example document after saving (34.60 KB, image/png)
2019-08-22 07:47 UTC, Gabor Kelemen (allotropia)
The example document saved as docx (5.01 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2019-08-22 07:52 UTC, Gabor Kelemen (allotropia)
Simplified example file saved as docx (33.24 KB, image/png)
2019-08-22 07:53 UTC, Gabor Kelemen (allotropia)

Note You need to log in before you can comment on or make changes to this bug.
Description Ellis Farmer 2014-10-29 16:22:02 UTC
Created attachment 108640 [details]
Page 5 Footnote Num 3 will not stay marked as deleted

I created a footnote, turned on track changes, deleted the text where the footnote was referenced (9.E.v.), and deleted the footnote text.

It looks correctly marked and will print correctly once.

Once I print it or save it, the footnote text reverts to not being marked as deleted.

See Page 5 Footnote #3 in the attachment.
Comment 1 Buovjaga 2014-11-15 12:45:08 UTC
In your attached PDF pg 5, is this what you want to see?
If I delete the footnote text, there remains only the footnote number and no text.

Change back to UNCONFIRMED after you have provided the information.

Win 7 64-bit Version:
Build ID: b021b5983c62e266b82d9f0c5c6d8d8900553827
TinderBox: Win-x86@39, Branch:master, Time: 2014-11-12_01:10:08
Comment 2 Gordo 2015-03-04 13:36:29 UTC
1. New Text Document.
2. Type “This is a test of track changes and footnotes.”, ignoring quotations.
3. Place cursor after footnotes and before period/full stop.
4. Insert → Footnote/Endnote... → OK default.
5. In footnote, type “test”.
6. Save document.
7. Edit → Track changes → Record Changes.
8. Delete “ and footnotes”, including the footnote number.
9. Delete “test” from footnote.
10. Edit → Track changes → Record Changes.
11. Save document.
The text “test” in footnote is not marked as deleted.
12. Edit → Track changes → Show Changes.
The footnote correctly hides.

Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432
Comment 3 Ellis Farmer 2015-03-16 13:43:08 UTC
Created attachment 114129 [details]
Very similar problem where a Save is reverting changes.

This is a later version of the same file (earlier problem with the footnote is still not resolved) where someone else had a very similar problem. I've stripped the file down so it is easier to locate the problem. => Try tabbing “B” and “C” over to make them “i” and “ii” and hit Save to save it.  When you hit Save, they revert.
Comment 4 Ellis Farmer 2015-03-16 14:02:33 UTC
Yes, the first attachment PDF shows the footnote #3 on page 5 as it should be, but when you open the embedded ODF in LibreOffice, footnote #3 is not marked as deleted.

I get the same results.

This latest file has the same problem: When the changes are shown, they are not shown correctly.

I'm still getting the same results using Version:
Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432
Locale: en_US
Comment 5 Buovjaga 2015-03-16 15:10:39 UTC
Gordo confirmed it, so let's keep as NEW :)
Comment 6 tommy27 2016-04-16 07:24:19 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2017-05-22 13:25:14 UTC Comment hidden (obsolete)
Comment 8 sdc.blanco 2018-06-26 18:12:05 UTC
Here is a simpler recipe than comment 2, which still reproduces some of original bug report.

1.  New Text Document.
2.  Type a text, and make a footnote.
3.  Edit → Track changes → Record Changes.
4.  Delete some text and footnote in the text.
5.  Delete the text in the footnote.
6.  Turn 'off' "Show Track Changes"

(correct) Result:  all deletions are not shown.

7.  Turn 'on' "Show Track Changes"

(correct) Result:   Deletions in body are still shown as deleted.
(incorrect) Result:  the text in the footnote is no longer shown as deleted.

8. It does not matter if the file is saved or not. (Also, if the footnote text is deleted, and then the file is immediately saved and closed, the footnote text is shown as undeleted, when the file is opened again.)
Comment 9 sdc.blanco 2018-06-26 18:14:41 UTC
Here is the version information for comment #8

Version: (x64)
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU threads: 4; OS: Windows 6.19; UI render: default;
Comment 10 QA Administrators 2019-06-27 02:53:34 UTC Comment hidden (obsolete)
Comment 11 Gabor Kelemen (allotropia) 2019-08-22 07:44:03 UTC
Created attachment 153566 [details]
Even simpler test document
Comment 12 Gabor Kelemen (allotropia) 2019-08-22 07:46:06 UTC
Created attachment 153567 [details]
Screenshot of the example document after deleting the footnote

This creates 2 CT entries
Comment 13 Gabor Kelemen (allotropia) 2019-08-22 07:47:04 UTC
Created attachment 153568 [details]
The example document after saving

...but saving - without even reloading the file - destroys the CT entry of the footnote.
Comment 14 Gabor Kelemen (allotropia) 2019-08-22 07:52:39 UTC
Created attachment 153569 [details]
The example document saved as docx

Saving the example file with two CT entries works fine in docx format.
Comment 15 Gabor Kelemen (allotropia) 2019-08-22 07:53:31 UTC
Created attachment 153570 [details]
Simplified example file saved as docx

Version: (x64)
Build ID: 3e64065612acec2eb29aa21e2b515953422256d7
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-08-15_22:57:26
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL
Comment 16 Gabor Kelemen (allotropia) 2019-08-23 11:10:26 UTC
What really should happen is Writer should mark the footnote text as deleted when one deletes the footnote entry in the main document text. 
This is what Word does and more importantly: without change tracking enabled deleting the footnote entry removes the footnote itself. 
When change tracking is enabled accepting the removal of the footnote entry deletes the footnote itself as expectable.

I think this is more like a display issue, the base behavior works sanely and allowing to separately remove an already deleted footnote entries footnote is a bug.
Comment 17 QA Administrators 2022-04-24 03:30:27 UTC Comment hidden (obsolete)
Comment 18 László Németh 2022-04-27 14:37:12 UTC
Commmit description:

tdf#85610 sw: show tracked footnote insertion/deletion

also in the footnote area by formatting the footnote
number there as the footnote index number in the main
text (i.e. as anchor of the footnote).

Previously deleted footnotes were shown as not
deleted footnotes in Show Changes mode, also inserted
footnotes lost their footnote number formatting (i.e.
author color of the tracked change, and e.g. the default
underline) after file saving.

Note: for a working test, fix also MetafileXmlDump by
removing the bad 0x01 from the XML dump, which resulted
by the not expanded footnote index placeholder character.
Comment 19 Commit Notification 2022-04-27 14:37:18 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":


tdf#85610 sw: show tracked footnote insertion/deletion

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.
Comment 20 NISZ LibreOffice Team 2022-04-28 08:18:15 UTC
Verified in:
Version: (x64) / LibreOffice Community
Build ID: 3a05acb8f0d94728ea6cbfd7a69dac6ffa7ffc68
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded