I've been told that there is no uno command for the thousand separator, but it would be useful for such a button to be created. There is already code for this in the sidebar (i believe its in /sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx and the checkbox is in /sc/uiconfig/scalc/ui/sidebarnumberformat.ui), so a simple toggle button would be needed to be created for this. The alternative approach would be to create a copy of .uno:NumberFormatDecimal and modify it to set decimal places to 0.
Hi Jay, Do you also look at the side bar? Easy access to direct formatting number format is already available there.
Hi Cor, (In reply to Cor Nouws from comment #1) > Do you also look at the side bar? > Easy access to direct formatting number format is already available there. Yes i am aware it is there in the sidebar, but with the sidebar still disabled by default in Calc, many people wouldnt see it. :D
If you think it's worth (and reasonable possible) to add another button, despite the fact that in the nearby future the side bar will be promoted ...
Fine request - moving to NEW. The bar for enhancement requests are quite low guys - if it seems at all reasonable let's just mark as NEW. If someone implements the change, great, if no one does, well that's fine too. If UX doesn't want this implemented they can of course close it as WONTFIX but it should be some kind of consensus and not one person irritated about the proposed change.
Jay - let's set all of your enhancement pertaining to UX to ux-advice instead of the component. This way the team is aware of the proposal.
From the UX point of view - this is a request for the UNO command / functionality that could be an Easy Hack; so let's move to needsDevEval for a creation of this UNO command. To implement that, you want to take the functionality from: IMPL_LINK_NOARG_TYPED( NumberFormatPropertyPanel, NumFormatValueHdl, Edit&, void ) in sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx and when the button is pressed, either add or remove the thousand separator from the number format. To actually create the .uno: command for that, git grep SID_NUMBER_FORMAT - this is where the number format is applied; you want to do the same, but specialized on the thousand separator only.
JanI is default CC for Easy Hacks (Add Jan; remove LibreOffice Dev List from CC) [NinjaEdit]
A polite ping, still working on this bug
(In reply to jani from comment #8) > A polite ping, still working on this bug Was little busy, will submit a patch soon.
Gulsah: If you get some time as i dont think Fakabbir is working on this.
Is anyone working on this? If not, I would like to do it.
(In reply to Jim Raykowski from comment #13) > Is anyone working on this? If not, I would like to do it. No nobody is, so go for it. I've assigned it to you.
Ok here it be for kind review and helpful comments :) https://gerrit.libreoffice.org/#/c/45731/
Will this control have an icon created for it?
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=92eb84ec047cd091d467fd02c8e8bc8d85002b2e tdf#86085 add slot for toggling thousands separator It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Eike Rathke committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=39854837073158555ee26bee9254d1e5ac36a215 Slightly change state method logic, tdf#86085 follow-up It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Jim Raykowski from comment #16) > Will this control have an icon created for it? I've asked the icon team to work on it.
A polite ping, still working on this bug?