Bug 86688 - FILESAVE: Saving as XLS file fails
Summary: FILESAVE: Saving as XLS file fails
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.3.0.0.alpha0+ Master
Hardware: Other All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest
Depends on:
Blocks:
 
Reported: 2014-11-25 07:24 UTC by Luke
Modified: 2015-12-17 10:41 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Debug output (267.97 KB, text/plain)
2014-11-25 07:59 UTC, Matthew Francis
Details
bt with debug symbols (12.63 KB, text/plain)
2014-11-26 21:37 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luke 2014-11-25 07:24:50 UTC
Steps to Reproduce:
1. In a recent build of Calc 4.5, Open attachment 109652 [details]
2. File -> Save as -> *.xls -> Use Excel 2003 Format

Results:
4.2.6.3 - GOOD, saved correctly
4.5.0.0.alpha0+ - Calc will crash
Comment 1 Matthew Francis 2014-11-25 07:58:47 UTC
When I reproduced the bug on freshly built master, it didn't crash as such, but did fail to save the file (an exception is caught and an dialog displayed)

-> Summary edited
-> NEW
Comment 2 Matthew Francis 2014-11-25 07:59:33 UTC
Created attachment 109988 [details]
Debug output
Comment 3 Matthew Francis 2014-11-26 04:37:59 UTC
Could not reproduce a correct save with 4.2.6.3.
When I try, every version back to LO 3.3.0 (and also current AOO) either crashes or fails to save

-> Setting earliest reproduced version to "Inherited from OOo"
Comment 4 Julien Nabet 2014-11-26 21:37:48 UTC
Created attachment 110090 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today (ee5010f04c214a15ad7b62f662b59b8ba028a902) + enable-dbgutil, I could reproduce the crash.
I attached bt.
Comment 6 Luke 2014-11-27 04:51:09 UTC
LO Version: 4.1.6.2 - GOOD
LO Version: 4.2.6.3 - GOOD
LO Version: 4.5.0.0.alpha0+ - FAIL
AOO 420m1(Build:9800) Rev. 1627435 - GOOD

I had 3 successful saves on a 32bit Win 7 box. For Windows at least, this does not go back to OOo.
Comment 7 spamnot 2014-11-29 01:45:55 UTC
I used 4.4.0.0.beta1 to open an old encrypted .xls file that I was using with previous versions of LibreOffice Calc without problem.  4.4.0.0.beta1 consistently hung when trying to save in any manner.  I went back to 4.3.4.1 and the encrypted .xls file worked perfectly.
Comment 8 Markus Mohrhard 2014-12-01 02:25:34 UTC
(In reply to Julien Nabet from comment #5)
> Matus: noticing
> http://cgit.freedesktop.org/libreoffice/core/log/
> ?qt=range&q=5ed4c11534ba431097da1abb5d600d21b5f68a9a, one for you?

That one is fixed. But that only affects the Biff export and not the old xls xml format. So this problem is anyway not related to this bug report.
Comment 9 Markus Mohrhard 2014-12-01 02:42:29 UTC
So this looks like a problem with the recursion depth. There is no easy fix for that and nobody who I know who would be willing to spend time debugging the old XSLT based export filter.

In general don't use the XLS XML export/import as it is badly maintained and will not be fixed.
Comment 10 Julien Nabet 2014-12-02 20:49:45 UTC
Markus: just for curiosity, do you mean these:
./filter/source/xslt/export/spreadsheetml/table.xsl
./filter/source/xslt/export/spreadsheetml/ooo2spreadsheetml.xsl
./filter/source/xslt/export/spreadsheetml/formular.xsl
./filter/source/xslt/export/spreadsheetml/styles.xsl
./filter/source/xslt/export/spreadsheetml/style_mapping.xsl
?
Also, do you mean Save as "Microsoft Excel 97-2003 xls" shouldn't be used? If yes should this export be removed or is there a work in progress to replace it?

BTW, "find . -name *.xsl* |wc -l" indicates there are still 140 xsl/xslt files, so if there's no xsl hero here, bad news :-(
Comment 11 Robinson Tryon (qubit) 2014-12-10 14:20:02 UTC
(In reply to Luke from comment #0)
> Steps to Reproduce:
> 1. In a recent build of Calc 4.5, Open attachment 109652 [details]
> 2. File -> Save as -> *.xls -> Use Excel 2003 Format

Testing on Ubuntu 14.04 x86_64:
LO 4.4.0.0.beta2 - GOOD
LO Version: 4.5.0.0.alpha0+ - GOOD
  (Build ID: df62a2c81bef2bcd96a5f14802e41815f0bdc2da
   TinderBox: Linux-rpm_deb-x86_64@46-TDF, 
   Branch:master,
   Time: 2014-12-09_22:40:23
   Locale: en_US)

Luke: is this one fixed?
Comment 12 Luke 2014-12-11 08:26:45 UTC
Confirmed FIXED in today's 12/10 4.5 daily build under Win7. Great work team!
Comment 13 Robinson Tryon (qubit) 2015-12-17 10:41:01 UTC
Migrating Whiteboard tags to Keywords: (BibisectRequest)
[NinjaEdit]