Bug 87178 - DIALOG: Reset menus in Customize dialog resets toolbars as well
Summary: DIALOG: Reset menus in Customize dialog resets toolbars as well
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:5.2.0 target:5.1.1 target:5.0.6
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-10 02:54 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-10-25 19:08 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-12-10 02:54:01 UTC
If you have modified your toolbars and go into Tools > Customize > Menus and click the reset button, the notification states it will reset the menus, but it also resets the toolbars.

Version: 4.5.0.0.alpha0+
Build ID: 6163291b25d2dac74ac353c3879fdc520bee747e
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-12-09_01:35:51
Comment 1 tommy27 2014-12-10 05:41:01 UTC
confirmed under Win8.1 x64 4.5.0.0.alpha0+
Build ID: 6b096f273ac9d7bbe93d2cb083958b3a04866d73
TinderBox: Win-x86@42, Branch:master, Time: 2014-12-04_22:57:23

however the same issue happens with LibO 4.3.3, 4.1.5, 3.3.3 and OOo 3.3.0, hence the problem is inherited from OOo

it seems that the reset button is not specific to the tab you are working with but resets both menus and toolbars setups.

I agree that this is a bug, and the reset should only apply to the the current tab, not both.

the keyboard tabs seems unaffected but disfunctional too (try deleting the F2 key, then close, reopen and click reset and it won't come back) but that is probably a different bug.
Comment 2 tommy27 2014-12-10 06:08:52 UTC
(In reply to tommy27 from comment #1)
> ....
> 
> the keyboard tabs seems unaffected but disfunctional too (try deleting the
> F2 key, then close, reopen and click reset and it won't come back) but that
> is probably a different bug.

submitted as Bug 87181. please test to confirm.
Comment 3 QA Administrators 2015-12-20 16:18:17 UTC Comment hidden (obsolete)
Comment 4 Commit Notification 2016-01-21 20:37:50 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb3ee586e420ee4e38f9ef8c579e1a37d2dc0c10

tdf#87178 Resetting menu shouldn't reset other resources

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Maxim Monastirsky 2016-01-21 20:39:28 UTC
Will also backport to stable branches.
Comment 6 Commit Notification 2016-01-22 13:27:10 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c36e8a3e99388485066a8321c28807ba4677114d&h=libreoffice-5-1

tdf#87178 Resetting menu shouldn't reset other resources

It will be available in 5.1.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2016-02-18 09:33:58 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb0aad9186953e0602ed96244492a71f203d8f94&h=libreoffice-5-0

tdf#87178 Resetting menu shouldn't reset other resources

It will be available in 5.0.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.