Created attachment 111848 [details] Sample file Calc's autofill is annoyingly slow even for very simple formulas. Steps: 1. Open the attached ods file 2. In vell 'F3' there is a simple 'trim' function 3. Double click on the bottom right corner of the cell to autofill 4. Calc seems to take quite a lot of time to autofill the cells.
Calc 4.5 and 3.5 is +- the same time (slow, tens of seconds). Comparing to excel where this operation takes 1 sec (slower VM on my machine ), so it's possible to make this instantly.. Marking as NEW.
Migrating Whiteboard tags to Keywords: (perf)
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.6 or 5.2.3 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170103
it takes 1 minute and 55 seconds in Version: 5.5.0.0.alpha0+ Build ID: 6ab249ea6aecef5d3f35d624622a368061cad9c3 CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group
In LibreOffice 3.3.0 OOO330m19 (Build:6) tag libreoffice-3.3.0.4 it takes 8 minutes 30 seconds. There has been some improvements at least...
with Version: 6.0.0.0.alpha1+ Build ID: 91987a559bf1fde4a8d1eadc81e5711a7670fe69 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-10-26_23:50:05 Locale: nl-BE (en_US.UTF-8); Calc: group it takes 52 seconds Version: 5.4.4.0.0+ Build ID: f95ec59f035ef1f6e9bd2a24e9d69e35edd6e089 CPU threads: 8; OS: Linux 4.9; UI render: default; VCL: kde4; Locale: nl-BE (en_US.UTF-8); Calc: group it takes 66 seconds
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Takes ~10 s for me now. For comparison, in 5.4.0.3 it took ~20 s. Version: 6.3.0.0.alpha0+ (x64) Build ID: eef8c4952da288629f9aad23f75d6f894eba83b4 CPU threads: 16; OS: Windows 6.1; UI render: default; VCL: win; Locale: hu-HU (hu_HU); UI-Language: en-US Calc: CL
(In reply to Aron Budea from comment #8) > Takes ~10 s for me now. > For comparison, in 5.4.0.3 it took ~20 s. > > Version: 6.3.0.0.alpha0+ (x64) > Build ID: eef8c4952da288629f9aad23f75d6f894eba83b4 > CPU threads: 16; OS: Windows 6.1; UI render: default; VCL: win; > Locale: hu-HU (hu_HU); UI-Language: en-US > Calc: CL it took 34 sec for me in Version: 6.5.0.0.alpha0+ (x64) Build ID: 2d736e1a0a2bbd41fe7793d52bbcc7bfc89c7da3 CPU threads: 4; OS: Windows 10.0 Build 18362; UI render: default; VCL: win; Locale: ru-RU (ru_RU); UI-Language: en-US Calc: threaded Julien, can you make the perfgraph here?
> ... > Julien, can you make the perfgraph here? No pb, I'll do it after my daytime job.
Created attachment 156856 [details] perf flamegraph Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today
Noel, please can you look at it?
For me it takes 26 seconds in Version: 6.5.0.0.alpha0+ Build ID: bf540873f5e258452fed5006f65a403c95e7872a CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded
Just for the record, the import time changed from real 0m10,414s user 0m8,418s sys 0m0,680s to real 0m31,807s user 0m27,930s sys 0m2,827s after https://cgit.freedesktop.org/libreoffice/core/commit/?id=1e55a47e89a9d9d6cf9cb3993484022aaf2c097b which is already reported in bug 124098
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/68547fa26897a8076eeda13cdcf20fb6078af6a4 tdf#88109 speed up calc autofill It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
My apologies, I marked this resolved before I pushed the patch. It should be much better now, although I think I can still speed it up a little more.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9073a47b99e22585c6d1603dd747cb14f081fca1 tdf#88109 improve autofill perf (2) It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/a5010d00be3a2dc1c89935d473b20fcbc127da86 tdf#88109 improve autofill perf (2) It will be available in 7.0.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
it takes 17 seconds in Version: 7.1.0.0.alpha0+ Build ID: e0f058bcd5e185b89e4b7c680a7901bc7eb2a790 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded while in Version: 6.4.0.0.alpha1+ Build ID: 9bc848cf0d301aa57eabcffa101a1cf87bad6470 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded it takes 78 seconds. Nice improvement. @Noel, thanks for fixing this issue!!