In order to reproduce the bug:
 Create new text document.
 If not displayed open „Styles and Formatting“ window (F11).
 Formatting bar > Apply Style > More... Window „Styles and Formatting“ is closed. Expected: No close.
In version 4.3.5 that window is not closed, hence regression.
* open writer
* open top menu format > Styles and Formatting (cmd + T on OSX btw).
But where is "Apple Style > more
Can't reproduce. Can you give more info?
"Apply Style" is the drop-down menu in the formatting bar where the current paragraph style is displayed and where you can assign another paragraph style to the current paragraph. If you move the mouse pointer above this menu the tip "Apply Style" is displayed.
Not reproduced. Tried with US & FI UIs.
Win 7 64-bit, LibO Version: 184.108.40.206
Build ID: a3603970151a6ae2596acd62b70112f4d376b99
Created attachment 112397 [details]
Screenshot before clicking "More Styles..."
Created attachment 112398 [details]
Screenshot after clicking "More Styles..."
Hoping that it's now clear what's happening.
(In reply to Harald Koester from comment #5)
> Created attachment 112398 [details]
> Screenshot after clicking "More Styles..."
> Hoping that it's now clear what's happening.
Yes, that didn't happen in my case.
Can you please see at Bug 85722 - Sidebar hides itself after unhiding it ?
I had a look at bug 85722. The bug described there is different to this bug. Hence no connection to this bug from my point of view. Also that bug exists already in versions 4.3.x, though this bug is new in 4.4.0.
This behaviour is happening in 220.127.116.11. Clicking on "More Styles..." from the "Apply Style" drop down is the same as clicking on the "Styles and Formatting" button in the Foramtting toolbar or the Sidebar--it hides/closes the already open "Styles and Formatting" window in the Sidebar.
I suspect it doesn't test to see the state of the window--if it's open, keep it open--but just does the opposite of whatever state it's in.
(In reply to Keymasher from comment #9)
> This behaviour is happening in 18.104.22.168. Clicking on "More Styles..." from
> the "Apply Style" drop down is the same as clicking on the "Styles and
> Formatting" button in the Foramtting toolbar or the Sidebar--it hides/closes
> the already open "Styles and Formatting" window in the Sidebar.
Ok, now I can suddenly reproduce this on Win & Linux.
On Linux 4.3.5 this is not observed, so this can be bibisected.
Win 7 Pro 64-bit, LibO Version: 22.214.171.124
Build ID: de093506bcdc5fafd9023ee680b8c60e3e0645d7
Build ID: b13534de022972131b46f93f5ada90af155eec9e
TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-02-19_00:21:37
Build ID: 40m0(Build:3)
Build ID: 3a87456aaa6a95c63eea1c1b3201acedf0751bd5
I am seeing this in Linux 126.96.36.199, Ubuntu 14.04.1 LTS.
If the sidebar is closed, "Apply Style > More Styles..." opens it properly.
Possibly "Apply Style > More Styles..." is triggering an unconditional toggle of the sidebar instead of a conditional toggle or just an open.
I have been looking at this bug to try and bisect but I want to make sure I understand the problem first.
As I understand it we are talking about clicking "More Styles" on the "Styles and Formatting" dropdown and it closes the sidebar specifically? Or are we also referring to the "Styles and Formatting" window (not sidebar) that was present in older versions of LibreOffice.
I noticed whilst I was testing that when using F11 many times it would bring up a separate window which I did not see being closed by clicking on "More Styles", however I do see the sidebar being closed when clicking on "More Styles"
Yep, it's the sidebar closing, you can bibisect from 4.3.5 onwards.
Created attachment 113810 [details]
Bug 88396 Git bisect log
I have attached a git bisect log for this. It is the first bisect I have done so hopefully I have done it correctly.
One thing I noticed is that usually when the siebar was not closed by clicking on "more styles" a separate window would open which duplicated the the sidebar contents.
Hope this helps.
I reported the same issue in bug 84351 and it was supposedly closed as being fixed.
Going to change the whiteboard comment to "bibisected" if there are no objections.
Yep, let's switch to "bibisected" :)
According to the commit logs in question, the issue that was actually fixed under bug 84351 relates to clicking on icons. This bug relates to the Apply Style dropdown - More Styles... on the Formatting toolbar. It's not quite the same, so I'm leaving this as a separate bug rather than reopening the other one.
This seems to have been introduced in the below commit when the window was converted to be part of the sidebar. It still occurs on current master.
Adding Cc: to firstname.lastname@example.org; Any chance you could take a look at this? Thanks
Author: Samuel Mehrbrodt <email@example.com>
AuthorDate: Fri Aug 22 22:37:56 2014 +0200
Commit: Thomas Arnhold <firstname.lastname@example.org>
CommitDate: Sun Aug 24 06:26:17 2014 -0500
fdo#73151 Make better use of the sidebar
*** Bug 90251 has been marked as a duplicate of this bug. ***
I can confirm this bug on fedora workstation 22. Tested with 4.4 from fedora repo and latest dev build.
Steps to reproduce:
If you click on "More styles..." in style menu and have opened sidebar with "Styles and Formatting" sidebar will be hide.
Sidebar with "Styles and Formatting" stays open since you clicked on "More styles.."
2. If you have open sidebar with "Properties" or "Gallery", then "Styles and Formatting" will open as expected.
Tested with:(in video)
Build ID: 188.8.131.52-6.fc22
Development version:(same issue)
Build ID: b990cdf57d6a85a36de713004a67a90ba2650623
Migrating Whiteboard tags to Keywords: (bibisected)
I fixed this during 5-2 I believe
Yes, as https://cgit.freedesktop.org/libreoffice/core/commit/?id=b81daea4a78083def286fa2d5360b152b7a703fd
so good in 5-2 and I have a backport for 5-1 as
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-5-1":
Resolves: tdf#88396 switching to sidebar panel will toggle it *off*...
It will be available in 5.1.5.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.