Bug 88635 - namespace scaddins ...
Summary: namespace scaddins ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Stephan Bergmann
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2015-01-20 18:07 UTC by Michael Meeks
Modified: 2015-12-15 16:27 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2015-01-20 18:07:37 UTC 
The scaddins/ code needs moving into a pleasant namespace; recently we had a problem that ConvertData is used in there - and conflicts with vcl's ConvertData.

It'd be great to add a namespace of 'analysis' to all the scaddins/ pieces - or some other suitable name. Just a matter of extending:

git log -u -1 b398945d08bdab0de5f22b06c91686569942e668

to the rest of scaddins I suspect; it'd be awesome to vcl:: prefix the VCL version too if possible.

Thanks ! =)
Comment 1 David Tardon 2015-03-25 08:03:40 UTC 
This has already been done by Stephan as a part of his ASan work.
Comment 2 Robinson Tryon (qubit) 2015-12-15 16:27:29 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup)
[NinjaEdit]