Bug 89679 - FILTER: A Typo in the source code of Calc export filter.
Summary: FILTER: A Typo in the source code of Calc export filter.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.1.2 release
Hardware: Other All
: medium normal
Assignee: Mark Hung
URL:
Whiteboard: target:4.5.0 target:4.4.2 target:4.3.7
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-26 13:11 UTC by Mark Hung
Modified: 2015-03-03 11:17 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hung 2015-02-26 13:11:17 UTC
The line in sc/source/filter/xml/editattributemap.cxx:

{ XML_NAMESPACE_STYLE, "font-family-complex", "CharFontNameAsian", EE_CHAR_FONTINFO_CTL, MID_FONT_FAMILY_NAME }

Here, CharFontNameAsian is obviously typo of CharFontNameComplex.
Comment 1 Julien Nabet 2015-02-26 21:41:10 UTC
Good catch!
Comment 2 Julien Nabet 2015-02-26 21:44:43 UTC
I was preparing a patch when I noticed you had an account.
Would you mind submitting a patch to review?
Comment 3 Mark Hung 2015-02-27 01:05:16 UTC
https://gerrit.libreoffice.org/#/c/14663/
Comment 4 Commit Notification 2015-02-27 14:28:57 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cda9ae79e58d861a85128d6a37587b633b956aae

tdf#89679 - fix incorrect mapping of font-family-complex and CharFontNameAsian

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2015-02-27 14:35:40 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb493f5b9d59a82b2aae729f0b02a76f2b9b8e50&h=libreoffice-4-4

tdf#89679 - fix incorrect mapping of font-family-complex and CharFontNameAsian

It will be available in 4.4.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2015-02-27 14:36:54 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "libreoffice-4-3":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce7a2502810615b64e83036211e6149313604fff&h=libreoffice-4-3

tdf#89679 - fix incorrect mapping of font-family-complex and CharFontNameAsian

It will be available in 4.3.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.