Bug 89933 - Calc crashes after pressing F2 after keyboard formatted input
Summary: Calc crashes after pressing F2 after keyboard formatted input
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.3.6.2 release
Hardware: All All
: high critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks:
 
Reported: 2015-03-10 14:32 UTC by Francisco
Modified: 2015-12-15 11:03 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francisco 2015-03-10 14:32:42 UTC
As the title describes, Calc 4.3.6 crashes every time I press F2 for editing a cell, while already editing. Pressing F2 while editing is useful when one needs to go back using keyboard arrows, otherwise, the cursor will move to another cell.

Steps to reproduce
1) Start to type in a cell (any character)
2) Now "preformat" next character from toolbar o keyboard. A simple way is to press "crtl+B" to make next characters bold.
3) Press F2

Results: Calc crases

Expected result:
Calc doesn't crash

I can reproduce this bug *every time* with LibO 4.3.6 RC2 under Kubuntu Linux 14.04 x64 and Windows 7 Professional x86, from clean user folders. Both installers (Linux 64 bits and Windows 32 bits) were downloaded from LibO site.

However, I can't reproduce this bug with LibO 4.2.8 in Kubuntu Linux installed from repositories.
Comment 1 Francisco 2015-03-10 14:35:22 UTC
(In reply to Francisco from comment #0)

> Steps to reproduce
> 1) Start to type in a cell (any character)
> 2) Now "preformat" next character from toolbar o keyboard. A simple way is
> to press "crtl+B" to make next characters bold.
> 3) Press F2
> 

Sorry, I forget one step

 Steps to reproduce
1) Start to type in a cell (any character).
2) Now "preformat" next character from toolbar o keyboard. A simple way is
to press "crtl+B" to make next characters bold.

--> 2.b) Type any character.

3) Press F2.
Comment 2 raal 2015-03-10 14:50:33 UTC
I can reproduce crash with LO 4.1.1.2, win7
Comment 3 raal 2015-03-10 14:51:36 UTC
(In reply to raal from comment #2)
> I can reproduce crash with LO 4.1.1.2, win7

vesion  4.4.1.2
Comment 4 Julien Nabet 2015-03-11 23:05:42 UTC
part of bt:
#2  0x00002aaace88307e in WrongList::empty (this=0x0) at /home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/edtspell.cxx:519
#3  0x00002aaace8d3d76 in ImpEditEngine::Paint (this=0x2eb66a0, pOutDev=0x2c53420, aClipRect=Rectangle = {...}, aStartPos=Point = {...}, bStripOnly=false, nOrientation=0)
    at /home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/impedit3.cxx:3478
#4  0x00002aaace8d5cc7 in ImpEditEngine::Paint (this=0x2eb66a0, pView=0x3095930, rRect=Rectangle = {...}, pTargetDevice=0x2c53420, bUseVirtDev=false)
    at /home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/impedit3.cxx:3859
#5  0x00002aaace87a3e0 in EditView::Paint (this=0x3035010, rRect=Rectangle = {...}, pTargetDevice=0x2c53420)
    at /home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/editview.cxx:268
#6  0x00002aaacbc1b040 in ScGridWindow::DrawContent (this=0x2c53420, rDevice=..., rTableInfo=..., aOutputData=..., bLogicText=false, eMode=SC_UPDATE_MARKS)
    at /home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/gridwin4.cxx:891
#7  0x00002aaacbc193aa in ScGridWindow::Draw (this=0x2c53420, nX1=0, nY1=0, nX2=16, nY2=0, eMode=SC_UPDATE_MARKS)
    at /home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/gridwin4.cxx:508
#8  0x00002aaacbc187b2 in ScGridWindow::Paint (this=0x2c53420, rRect=Rectangle = {...}) at /home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/gridwin4.cxx:374
#9  0x00002aaab1767058 in PaintHelper::DoPaint (this=0x7fffffff4720, pRegion=0x0) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/paint.cxx:125
Comment 5 Michael Weghorn 2015-03-13 21:07:45 UTC
bibisect result:
 1da949ef6797e95f5249072e645f9c36fe3afd45 is the first bad commit
commit 1da949ef6797e95f5249072e645f9c36fe3afd45
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date:   Sat Nov 8 03:50:03 2014 +0000

    source-hash-6a4b976bd0818c2f60b879594d393baad9a0f346
    
    commit 6a4b976bd0818c2f60b879594d393baad9a0f346
    Author:     Stephan Bergmann <sbergman@redhat.com>
    AuthorDate: Fri Oct 24 16:10:26 2014 +0200
    Commit:     Stephan Bergmann <sbergman@redhat.com>
    CommitDate: Fri Oct 24 16:10:54 2014 +0200
    
        Fix Fraction(-2147483648.0) for 32-bit wide long
    
        Change-Id: I6465377de1edff5d0ccc0049fb6d24f6f1223fd2



$ git bisect log
# bad: [4a3091e95fa263d3e2dd81e56e83996f0bb12287] source-hash-2b5b04e1e62914bf0902dfd7943cdc44499c47a6
# good: [812c4a492375ac47b3557fbb32f5637fc89d60d9] source-hash-dea4a3b9d7182700abeb4dc756a24a9e8dea8474
git bisect start 'latest' 'oldest'
# good: [5d0dfb8e62ae61a240f8313c594d4560e7c8e048] source-hash-0c6cd530de13f80795881f61064f1bf1dcc4ea81
git bisect good 5d0dfb8e62ae61a240f8313c594d4560e7c8e048
# good: [7dfacd0b8bd828331d74c0f79de6e8924bc4e6a5] source-hash-f93ce4f7eb90093d0ea3115d0a1c614612676dbd
git bisect good 7dfacd0b8bd828331d74c0f79de6e8924bc4e6a5
# good: [a42da134cd542144fca7ba14cce86c2b409fc18a] source-hash-beadebc0f7eb5582fcb8dcb082d19afdf2751876
git bisect good a42da134cd542144fca7ba14cce86c2b409fc18a
# bad: [038f586bf711ad77856916be954b6c02a5717eb1] source-hash-2ec4c8b07427af868e32e14aaefd20649c1135d6
git bisect bad 038f586bf711ad77856916be954b6c02a5717eb1
# good: [3272655899837213551d1b46343269e2d15692b7] source-hash-973eb2f6db60c0939299a968a3121e3310e6d1f5
git bisect good 3272655899837213551d1b46343269e2d15692b7
# good: [f733d1b756f29ca288289e0c26afa5255baf6181] source-hash-81819527318c583ead77a15e700ebf81e9e41e6e
git bisect good f733d1b756f29ca288289e0c26afa5255baf6181
# skip: [ff9182ded0b6769a7b32be62ee114e9c4ec3592e] source-hash-10727e53f718086e8b26ded1b904cb4f11501e34
git bisect skip ff9182ded0b6769a7b32be62ee114e9c4ec3592e
# bad: [9d07b6090380399776f3a3da7103cfea7ce60f5a] source-hash-8c5f640308b618ec330e83527019a4baa982f902
git bisect bad 9d07b6090380399776f3a3da7103cfea7ce60f5a
# skip: [b89a67f52c5cb90b23c9323d50947774d2aaa90c] source-hash-89a04240222ff6909d37debcbf5dce614c4dd1c8
git bisect skip b89a67f52c5cb90b23c9323d50947774d2aaa90c
# bad: [1da949ef6797e95f5249072e645f9c36fe3afd45] source-hash-6a4b976bd0818c2f60b879594d393baad9a0f346
git bisect bad 1da949ef6797e95f5249072e645f9c36fe3afd45
# first bad commit: [1da949ef6797e95f5249072e645f9c36fe3afd45] source-hash-6a4b976bd0818c2f60b879594d393baad9a0f346
Comment 6 Matthew Francis 2015-03-14 13:57:41 UTC
The issue seems to have begun at the below commit.
Adding Cc: to momonasmon@gmail.com; could you possibly take a look at this? Thanks

    commit 6ba8b7f5eacac969e4781d63718083a05491b1bc
    Author:     Maxim Monastirsky <momonasmon@gmail.com>
    AuthorDate: Fri Oct 24 01:35:56 2014 +0300
    Commit:     Maxim Monastirsky <momonasmon@gmail.com>
    CommitDate: Fri Oct 24 01:47:46 2014 +0300
    
        fdo#73617 sc: Don't update the gui during live preview
    
        Apart from (apparently) being not necessary, it creates
        bugs like this one. If the selection consist of multiple
        fonts, it leads to clearing the font name box, which in
        turn leads to scrolling the list up.
    
        Change-Id: I8e702b9b4d4a1f7ad1ded5de1a5e162f039f6d4d
Comment 7 Michael Meeks 2015-05-08 21:32:20 UTC
Fixed on master by dtardon in commit: 89c92e533daf9ee597b858be8207dedcd1139643, I've cherry-picked it to -4-4 =)
Comment 8 Robinson Tryon (qubit) 2015-12-15 11:03:02 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]