Bug 89955 - EDITING: focus lost when using edit button or CTRL-SHIFT_M
Summary: EDITING: focus lost when using edit button or CTRL-SHIFT_M
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.0.beta1
Hardware: Other Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2015-03-11 15:37 UTC by Bernard Moreton
Modified: 2017-10-01 09:31 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Moreton 2015-03-11 15:37:48 UTC
When going into read-only mode in any document using the edit button or CTRL-SHIFT-M, focus is lost (PageUp/Down no longer works, and CTRL-SHIFT-M is also disabled) until the user clicks on the document text area.

May be related to bug 89688
Comment 1 A (Andy) 2015-03-14 10:09:36 UTC
For me not reproducible with LO 4.4.1.2, Win 8.1.  Maybe a Linux only issue?
Comment 2 Bernard Moreton 2015-03-14 13:40:39 UTC
OK, so to be more precise:
--version gives 4.4.1.2 40m0(Build:2)
On Ubuntu 12.04 LTS
Comment 3 Buovjaga 2015-03-20 18:06:58 UTC
Cannot reproduce.

Ubuntu 14.10 64-bit 
Version: 4.4.1.2
Build ID: 40m0(Build:2)
Locale: en_US
Comment 4 Matthew Francis 2015-04-28 00:54:56 UTC
I can reproduce this.
Ubuntu 14.04 (lxde)
LO 4.4.2.2

-> NEW
Comment 5 Matthew Francis 2015-04-28 00:59:43 UTC
This began somewhere in the 4.4 master cycle
-> Version: 4.4.0.0beta1
-> Keywords: regression
-> Whiteboard: bibisectRequest
Comment 6 Robinson Tryon (qubit) 2015-12-14 05:32:41 UTC Comment hidden (obsolete)
Comment 7 Joel Madero 2015-12-16 15:26:06 UTC
Was it possible to go into edit mode prior to 4.4 - if so...how? it's not in edit -> edit mode, nor is it assigned a keyboard shortcut from what it seems.

I'm happy to bibisect but need a little guidance for pre-4.4 releases.
Comment 8 Bernard Moreton 2015-12-21 12:23:53 UTC
In the absence of replies to comment 7, yes it was possible to go into edit mode prior to 4.4 - but I'm afraid it was so automatic that I can't remember how!  Either an icon (probably), or a menu entry in Edit.  Sorry that's not as helpful as you'd want, but didn't want to continue the silence ...
Happy Christmas!
Comment 9 raal 2016-01-01 20:25:49 UTC
This seems to have begun at the below commit.
Adding Cc: to Samuel Mehrbrodt ; Could you possibly take a look at this one?
Thanks
 0f9f354ac2a2e115f76429c91aa1ba545a08f328 is the first bad commit
commit 0f9f354ac2a2e115f76429c91aa1ba545a08f328
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 01:49:58 2015 +0800

    source-hash-b4558b508141af16d335f45a0f12bdd34521e944
    
    commit b4558b508141af16d335f45a0f12bdd34521e944
    Author:     Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
    AuthorDate: Fri Aug 22 22:37:56 2014 +0200
    Commit:     Thomas Arnhold <thomas@arnhold.org>
    CommitDate: Sun Aug 24 06:26:17 2014 -0500
    
        fdo#73151 Make better use of the sidebar
    
        The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)
    
        Changes:
        * Show the sidebar by default in Writer & Impress
        * Remove the Gallery floating window (Gallery now always opens in the sidebar)
        * Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
          (since they have an icon in the sidebar and the sidebar is shown by default now)
        * When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window
    
        This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151
    
        Change-Id: I3a0461d1472711da7121801000af294b432fccb1
        Reviewed-on: https://gerrit.libreoffice.org/11077
        Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
        Tested-by: Thomas Arnhold <thomas@arnhold.org>
Comment 10 Samuel Mehrbrodt (allotropia) 2016-01-08 10:37:37 UTC
That commit only enabled the sidebar by default - did this also happen before when the sidebar was enabled manually?
Comment 11 Björn Michaelsen 2016-08-09 13:55:04 UTC
NEEDINFO as per comment 10
Comment 12 Bernard Moreton 2016-08-25 16:49:12 UTC
In the absence of any other reply to #10, I first found the bug in 4.4, and since I frequently open documents in read-only mode, I believe it was new then.

I hardly ever opened the sidebar manually, so I'm afraid I can't comment adequately on that.  Sorry!
Comment 13 Buovjaga 2016-08-27 19:27:09 UTC
NEW -> NEEDINFO considered harmful, as proven again.. correcting status.
Comment 14 Xisco Faulí 2017-09-29 08:51:57 UTC Comment hidden (obsolete)
Comment 15 Bernard Moreton 2017-10-01 09:31:24 UTC
Using LibreOffice 5.4.1.2 on Ubuntu 16.04 and opening a document in readonly mode (ie with --view), 
PageUp/Down and CTRL-SHIFT-M now work as they should, without any need to click on the document text area.
Thank you for this fix!