Bug 90073 - SIDEBAR: Color picker fill bar has gone missing
Summary: SIDEBAR: Color picker fill bar has gone missing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:5.0.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Sidebar-Properties
  Show dependency tree / graph
 
Reported: 2015-03-17 21:00 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-10-24 15:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
4.4 vs 4.5 (23.30 KB, image/png)
2015-03-17 21:00 UTC, Yousuf Philips (jay) (retired) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-03-17 21:00:05 UTC 
Created attachment 114157 [details]
4.4 vs 4.5

In the sidebar, there are wide color controls that show a fill bar of the current color and these have disappeared in master and have been replaced with filling the bottom of the color icon. This affects color controls in the area, line, paragraph, and cell appearance sections, though there maybe more

Version: 4.5.0.0.alpha0+
Build ID: de145fb467f2a168261915d63b47d3cd3b03d732
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-03-15_09:51:29
Comment 1 Tomaz Vajngerl 2015-03-18 01:15:07 UTC 
Oh that's probably one of my changes - I'll investigate.
Comment 2 Yousuf Philips (jay) (retired) 2015-04-14 06:01:31 UTC 
Lets set this to NEW so Matthew can try and track down where this happened.
Comment 3 Matthew Francis 2015-04-14 06:09:21 UTC 
Looks like this one

commit b8f21298288890d52c06fef6c84441634c56c986
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date:   Mon Mar 2 20:57:32 2015 +0900

    toolbox - preserve the orig. image + use it in menu & color update
    
    In toolbox the images are scaled for HiDPI, which causes various
    problems. This change preserves the original image and uses that
    when adding images into the menu and also uses that when updating
    the color related toolbox-es.
    
    Change-Id: Ib7e7d82ccb1cd774e0e14dd6bab5626eaefea097
Comment 4 Tomaz Vajngerl 2015-04-14 06:15:40 UTC 
Thank you. I know this since I commented :)
Comment 5 Yousuf Philips (jay) (retired) 2015-04-14 06:20:47 UTC 
(In reply to Tomaz Vajngerl from comment #4)
> Thank you. I know this since I commented :)

Just trying to make your job easier. :D
Comment 6 Adolfo Jayme Barrientos 2015-05-06 14:17:59 UTC 
Fixed by Caolán: http://cgit.freedesktop.org/libreoffice/core/commit/?id=27d94c482e82ea5d4f202109614c6fb3578fb0a4

Thanks!
Comment 7 Tomaz Vajngerl 2015-05-07 02:16:15 UTC 
Not fixed - it totally screws the HiDPI scenario, which is what my change was all about in the first place. I fixed multiple problems in HiDPI, the changes caused this regression only, for which I had a solution but no time to implement it yet. With this we are one step back again..
Comment 8 Robinson Tryon (qubit) 2015-12-17 08:49:18 UTC Comment hidden (obsolete)