Bug 90144 - SIDEBAR: Addition of a image border section
Summary: SIDEBAR: Addition of a image border section
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Properties-New-Content-Panels
  Show dependency treegraph
 
Reported: 2015-03-21 09:01 UTC by Yousuf Philips (jay) (retired)
Modified: 2017-12-19 08:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
mockup (5.21 KB, image/png)
2015-03-21 09:01 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-03-21 09:01:30 UTC
Created attachment 114229 [details]
mockup

When an image is selected in other modules, a line section appears in the sidebar which allows you to add borders around it, but in writer this doesnt appear as images are treated different in writer than in other modules. So a border section needs to be added to the sidebar, which will be activated when either an image or frame is selected, similar to both frames and images sharing the same frame toolbar when selected.

The sidebar section requires three controls, which can be pulled as is from the line section - width, color, style - but will manipulate the border tab in the properties dialog box.

The functionality of the controls need to be tweaked so that it activates the border when any of the three controls are set. So as an example, if a user selects a color for the border, and the border style and/or width arent already set, then border style needs to be turned on to continuous and the border needs to be applied to all 4 sides at a width of 0.5pt.
Comment 1 A (Andy) 2015-03-21 10:40:44 UTC
@Jay: If I click on an image in a WRITER document then I have in the Sidebar already a section Line where I can add a border around the image (LO 4.4.1.2.).  Or is there a misunderstanding from my side?
Comment 2 Yousuf Philips (jay) (retired) 2015-03-21 11:17:23 UTC
Please send me a screenshot of this, as there isnt one for me. :D
Comment 3 Tomaz Vajngerl 2015-03-21 11:18:57 UTC
(In reply to A (Andy) from comment #1)
> @Jay: If I click on an image in a WRITER document then I have in the Sidebar
> already a section Line where I can add a border around the image (LO
> 4.4.1.2.).  Or is there a misunderstanding from my side?

You have an image from Draw in Writer (this can happen when you copy-paste an image from Draw for example) and not a "native" Writer image. 

Agh.. one more difference between Writer image and Draw image that I didn't know about! What a pain.
Comment 4 A (Andy) 2015-03-21 11:55:23 UTC
(In reply to Tomaz Vajngerl from comment #3)
> (In reply to A (Andy) from comment #1)
> > @Jay: If I click on an image in a WRITER document then I have in the Sidebar
> > already a section Line where I can add a border around the image (LO
> > 4.4.1.2.).  Or is there a misunderstanding from my side?
> 
> You have an image from Draw in Writer (this can happen when you copy-paste
> an image from Draw for example) and not a "native" Writer image. 
> 
> Agh.. one more difference between Writer image and Draw image that I didn't
> know about! What a pain.


@Tomaz and Jay:
Tomaz, you are right.  I made a screenshot of the screen with the Print Screen key and then pressed CTRL + V to insert it into DRAW and then I copied it to WRITER.  This complicated procedure was only done, because I was actually testing something else.
But what is strange for me, if I make a print screen and insert it directly with CTRL + V in WRITER then the Line section does not appear (Reproducible with LO 4.4.1.2, Win 8.1).  But why does the Line section only appear if I copy the same from DRAW?
I agree the Line section should always appear in the Sidebar for images.
Comment 5 Tomaz Vajngerl 2015-03-21 13:26:45 UTC
Because there are two implementations of image object - Writer specific one and a common one (shared with Draw, Calc, Impress). Both have some functionality the other lacks (for example - common implementation has rotation, Write implementation doesn't, but on the other hand common implementation doesn't have contour I think - and this is only one example) and some things have both, but implementation differs or is named differently. This is quite a PITA actually.
Comment 6 Robinson Tryon (qubit) 2016-08-25 05:26:52 UTC Comment hidden (obsolete)
Comment 7 Heiko Tietze 2017-12-19 08:24:02 UTC
Valid request where no further input from UX is needed. Guess the best solution is to clean-up the code.