Bug 90411 - core/sw/source/core/text/txtftn.cxx:530: bad ? :
Summary: core/sw/source/core/text/txtftn.cxx:530: bad ? :
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Julien Nabet
URL: http://dev-builds.libreoffice.org/cpp...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 11:23 UTC by dcb314
Modified: 2015-04-04 10:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2015-04-02 11:23:17 UTC 
[core/sw/source/core/text/txtftn.cxx:530]: (style) Same expression in both branches of ternary operator.

 OSL_ENSURE( bEndn ? !SwFtnBossFrm::FindFtn( this, pFtn ) :
                     !SwFtnBossFrm::FindFtn( this, pFtn ),
                            "SwTxtFrm::RemoveFtn: can't get off that footnote" );
Comment 1 Alex Thurgood 2015-04-03 14:37:36 UTC 
@dcb314 : stuff like this is usually best discussed on the libreoffice irc channel.
Comment 2 Julien Nabet 2015-04-04 09:59:27 UTC 
Looking at git history, it's been like this since http://cgit.freedesktop.org/libreoffice/core/commit/?id=887b3a35628b349e7934f2ae7c220a1cc17c3e63

Caolan fixed a similar place here:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f9bc93ba3299efbd8ad181481e6e2e87df7c066

I'll push a patch for this remaining part.
Comment 3 Julien Nabet 2015-04-04 10:03:44 UTC 
Fixed in master with http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce1365ec147a33a07df5bdc53796180d84b9d9e5

I don't think it worths it to cherry-pick this on 4.4 or even less in 4.3 since there's no impact.