Download it now!
Bug 90586 - OLE objects move around when entering into the edit mode
Summary: OLE objects move around when entering into the edit mode
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-13 02:09 UTC by Francisco
Modified: 2019-12-05 04:35 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
example file (27.51 KB, application/vnd.oasis.opendocument.presentation)
2015-04-13 02:09 UTC, Francisco
Details
sceenshot 1 (91.98 KB, image/png)
2015-04-13 17:30 UTC, Francisco
Details
screenshot 2 (83.64 KB, image/png)
2015-04-13 17:31 UTC, Francisco
Details
the attached opened with LibO 4.5 alpha 0 (109.08 KB, image/png)
2015-04-17 01:47 UTC, Francisco
Details
the same bug in LibO 4.3.6 under Windows 7 (214.76 KB, image/png)
2015-04-18 18:38 UTC, Francisco
Details
new example file (22.41 KB, application/vnd.oasis.opendocument.presentation)
2016-09-20 12:33 UTC, Francisco
Details
Screenshot 3: File opened with Impress 5.2.1 (63.86 KB, image/png)
2016-09-20 12:34 UTC, Francisco
Details
Screenshot 4: edit mode for the chart. (56.80 KB, image/png)
2016-09-20 12:35 UTC, Francisco
Details
Screenshot 5: edit mode for the equation. (50.41 KB, image/png)
2016-09-20 12:36 UTC, Francisco
Details
The bug is solved for charts, but not for equations (63.07 KB, image/png)
2019-12-05 04:34 UTC, Francisco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francisco 2015-04-13 02:09:25 UTC
Created attachment 114753 [details]
example file

When entering into edit mode in OLE objects like charts or equation, all the content of the document moves. In general it seems that this movement is related with the existence of different quantity of toolbars on top, plus docks at left like page navigator.

Exiting the edit mode leaves all in its position. However, I have found this movement quite annoying. It's drastic. IMHO the content of the document shouldn't change its position when selecting objects or entering into edit mode, and if it does, the change should be smooth.

Moreover, sometimes when entering into the edit mode, not only the content of the document is not in the same position on screen, but also the relative position of the object is wrong!

I'm attaching the file "movement_of_objects.odp" to show what I mean. I'll also attach some screenshots if what I mean can't be understood.

Steps:
1) Open ODP file attached
2) Double click on the chart at left to activate the edit mode

Expected result:
1) The content of the document remains in the same position, on screen.
2) The relative position of the object, with respect to the content of the document, remains constant

Actual result:
1) None of the expected.
a) When editing the chart, the slide is moved a little to the right, and the chart appears outside the slide!!
b) When editing the equation, the slide is moved upwards because the equation code dock appears. But also, the equation itself is moved into the middle! It's even a little scary, even for me.

Notice that the symbols (squares) which shows the position of the object in the slide (or spreadsheet, or doc page) shows the correct position, which will be restored when exiting the edit mode.

Notice that this bug is different from bug 90515, though maybe they are related.
Comment 1 Yousuf Philips (jay) (retired) 2015-04-13 09:06:29 UTC
Hi Francisco,

This movement is due to edit mode launching the internal chart app which has a different set of toolbars than the app the chart is included in. It is hoped that in the future, the app toolbars of the app that includes the chart can remain and just the chart toolbar appear when going into edit mode.
Comment 2 Francisco 2015-04-13 17:30:25 UTC
Created attachment 114764 [details]
sceenshot 1

(In reply to Jay Philips from comment #1)
> Hi Francisco,
> 
> This movement is due to edit mode launching the internal chart app which has
> a different set of toolbars than the app the chart is included in. It is
> hoped that in the future, the app toolbars of the app that includes the
> chart can remain and just the chart toolbar appear when going into edit mode.

Hi, Jay. Yes, I know that: it also happens when editing file inserted in a document, like a Draw file in Writer.

But, see screenshot 1: the chart is positioned inside the slide, becuase I putted there.

Ok, now lets launch the edit mode (screenshot 2): the content has been moved to the right. Ok, I don't like it personally and we all hope that toolbars in a future won't be a problem

Ok, but notice that also that the chart is located in a complete different position, relative to the slide content. It's outside the slide!

Put this in a context of a novice user... he/she puts it there, try to edit, and suddenly, that chart was outside the slide. The user sees that the content of his document has suddenly changed, and not that the edit mode has been launched.

So, even if the content moves in one direction because of toolbars and docks or not, care should be taken in the fact that the object that the user sees should be in the same position relative to the content.
Comment 3 Francisco 2015-04-13 17:31:07 UTC
Created attachment 114765 [details]
screenshot 2
Comment 4 Yousuf Philips (jay) (retired) 2015-04-13 20:53:58 UTC
(In reply to Francisco from comment #3)
> Created attachment 114765 [details]
> screenshot 2

That seems like a bug to me, as the chart should be in the exact same place in the document as it is when entering edit mode. I just tested it now in impress and it worked fine. What is that fourth toolbar i'm seeing in the screenshot outside of the standard, formatting and drawing toolbars, as those are the only ones that should be accessible in edit mode.

See that your on plasma 5. Which distro you running?
Comment 5 Francisco 2015-04-13 21:10:52 UTC
Hi, Jay
 
> That seems like a bug to me, as the chart should be in the exact same place
> in the document as it is when entering edit mode. I just tested it now in
> impress and it worked fine. What is that fourth toolbar i'm seeing in the
> screenshot outside of the standard, formatting and drawing toolbars, as
> those are the only ones that should be accessible in edit mode.

It's a custom toolbar I created, for being able to edit shapes drawn in charts. (Necessary workaround for bug 39052). It has "character", "line", "fill" and "size and position" options. That's because the options for shapes drawn in charts are more "limited" that the ones in Writer (see bug 58038), and have also its particular bugs (see bug 58027).

> See that your on plasma 5. Which distro you running?

Ha! It's just a plasma 4, with a "Brezze theme" I found in kde-look.org. Anyway, I'm running Kubuntu 14.04.
Comment 6 Yousuf Philips (jay) (retired) 2015-04-13 22:58:42 UTC
Hi Francisco,

(In reply to Francisco from comment #5)
> Hi, Jay
> 
> It's a custom toolbar I created, for being able to edit shapes drawn in
> charts. (Necessary workaround for bug 39052). It has "character", "line",
> "fill" and "size and position" options. That's because the options for
> shapes drawn in charts are more "limited" that the ones in Writer (see bug
> 58038), and have also its particular bugs (see bug 58027).

I had noticed the same problem as bug 58038, when i was working on improving the chart toolbars and thought to file a bug for it, but glad to see that you have already done so.

I believe the best solution is to not allow drawing capabilities in chart edit mode and have users do drawing over the chart object in the document, as i dont see why it needs to be embedding into the chart other than so that it remains in place when a chart is moved around.

I believe we can get those buttons you have into the formatting and shapes toolbar, so people can easily enable them rather than create a new toolbar.

> Ha! It's just a plasma 4, with a "Brezze theme" I found in kde-look.org.
> Anyway, I'm running Kubuntu 14.04.

Well LO 4.5 will be coming with breeze icons, so hopefully it will all blend well on your setup. :D
Comment 7 Francisco 2015-04-13 23:17:53 UTC
Regarding this bug, I'll test in my house with LibO 4.5 if the problem is still there (now I'm at work)

------------------------------------------------------------------------
(In reply to Jay Philips from comment #6)
> I had noticed the same problem as bug 58038, when i was working on improving
> the chart toolbars and thought to file a bug for it, but glad to see that
> you have already done so.
> 
> I believe the best solution is to not allow drawing capabilities in chart
> edit mode and have users do drawing over the chart object in the document,
> as i dont see why it needs to be embedding into the chart other than so that
> it remains in place when a chart is moved around.

You are right, they are useful for fixing shapes in a chart. For example, a chart may have a "call" shape for indicating something of a specific point. Or a line could be drawn to separate two regions, etc, etc. And charts in spreadsheets are continuously moved around.

I find this feature useful. It was introduced with LibO 3.3, imported from OOo. (https://wiki.documentfoundation.org/Marketing/LibOReleaseEvents/LOPressKit/FeatureList3.3#Productivity_Enhancements)

(Also, those shapes should also be useful as workaround for bug 39052, but not at the end because of bug 58027.)

> I believe we can get those buttons you have into the formatting and shapes
> toolbar, so people can easily enable them rather than create a new toolbar.

Indeed. 
 
> Well LO 4.5 will be coming with breeze icons, so hopefully it will all blend
> well on your setup. :D

Yeap, I know! I was using it on LibO 4.4... but bug 90581 took me back into Libo 4.3. :-P
Comment 8 Francisco 2015-04-17 01:47:23 UTC
Created attachment 114844 [details]
the attached opened with LibO 4.5 alpha 0

I've just tested the attached ODP file with LibO 4.5, and the bug is there


Version: 4.5.0.0.alpha0+
Build ID: 09a1e4f36128f64029d45a38d9b059bf11ea0821
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-04-15_23:39:39
Locale: es_AR
Comment 9 Yousuf Philips (jay) (retired) 2015-04-17 23:16:48 UTC
@Heiko: Does this happen to you on your KDE desktop?
Comment 10 raal 2015-04-18 05:22:33 UTC
I can confirm with Version: 4.5.0.0.alpha0+
Build ID: 51e0d789c344547956764c3b5f0ef5a304f4e0aa
TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-04-13_16:58:45
Comment 11 Yousuf Philips (jay) (retired) 2015-04-18 08:39:24 UTC
@raal: which version of ubuntu are you running?
Comment 12 raal 2015-04-18 10:23:47 UTC
(In reply to Jay Philips from comment #11)
> @raal: which version of ubuntu are you running?

14.10, Unity
Comment 13 Francisco 2015-04-18 18:38:09 UTC
Created attachment 114891 [details]
the same bug in LibO 4.3.6 under Windows 7

I can reproduce this bug also under with LibO 4.3.6 under Windows 7.
Comment 14 Yousuf Philips (jay) (retired) 2015-04-18 19:27:21 UTC
Okay i see where i was going wrong. I was zooming out to fit slide in windows before double clicking.

So the problem seems to arise when the slide is zoomed in more than what can fit in the viewable area. This seems to be a refresh issue, as when the chart is in its moved position, if you scroll up or down, it will refresh to its correct position.
Comment 15 QA Administrators 2016-09-20 09:24:36 UTC Comment hidden (obsolete)
Comment 16 Francisco 2016-09-20 12:25:00 UTC
Tested again in the following version:

Versión: 5.2.1.2
Id. de compilación: 1:5.2.1~rc2-0ubuntu1~trusty0
Subprocesos de CPU: 4; Versión de SO: Linux 3.13; Renderizado de IU: predeterminado; 
Configuración regional: en-US (es_AR.UTF-8); Calc: group

Situation has been really improved since now at least, the chart isn't moved to the left, outside the slide. Moreover, it remains in the same relative place _if_ there are the same amount of toolbars in the Impress and Chart apps. If, however, there are different number of toolbars, the chart is moved as shown in the screenshots.
Moreover, the problem is _still_ present in the Math app.

Steps:
0) Set different amount of toolbars in Chart and Impress 
1) Open the new example file: it's actually the same as the original, but now it has a black line drawn to show the position. (screenshot 3)
2) Enter in the edit mode for the chart:

Result: the chart is shown in a different position regarding the original relative position in the slide. (Again, it remains perfectly in the same place if there are the same number of toolbars). 
This is screenshot 4.

3) Enter in the edit mode for the equation in the file

Result: the relative position changes completely: the slide it self moves around, and the formula appears in the middle of the screen. (However, the selection marks are in the correct place, see screenshot 5)
Comment 17 Francisco 2016-09-20 12:29:20 UTC
> Result: the chart is shown in a different position regarding the original
> relative position in the slide. (Again, it remains perfectly in the same
> place if there are the same number of toolbars). 
> This is screenshot 4.

Sorry, I made a mistake: even if there are the same amount of toolbars, the relative position of the chart with respect to the slide changes. What doesn't change is the position of the chart with respect to the LibreOffice window. This is what screehshot 4 shows.
Comment 18 Francisco 2016-09-20 12:33:28 UTC
Created attachment 127462 [details]
new example file

This is the new example file. It's barely the same except for a line above the only 2 objects on the slide.
Comment 19 Francisco 2016-09-20 12:34:30 UTC
Created attachment 127463 [details]
Screenshot 3: File opened with Impress 5.2.1

This is the what I see when opening the file.
Comment 20 Francisco 2016-09-20 12:35:41 UTC
Created attachment 127464 [details]
Screenshot 4: edit mode for the chart.
Comment 21 Francisco 2016-09-20 12:36:20 UTC
Created attachment 127465 [details]
Screenshot 5: edit mode for the equation.
Comment 22 Xisco Faulí 2017-09-29 08:53:23 UTC Comment hidden (obsolete)
Comment 23 QA Administrators 2019-12-03 14:35:48 UTC Comment hidden (obsolete)
Comment 24 Francisco 2019-12-04 14:04:05 UTC
(In reply to QA Administrators from comment #23)
> Dear Francisco,
> 
> [...]

Dear QA admins,

The bug seems solved in LibO 6.3 under Kubuntu 18.04.

Versión: 6.3.3.2
Id. de compilación: 1:6.3.3-0ubuntu0.18.04.1~lo1
Subprocs. CPU: 4; SO: Linux 4.15; Repres. IU: predet.; VCL: kde5; 
Configuración regional: en-US (es_AR.UTF-8); Idioma de IU: es-ES
Calc: threaded

Thank you all for your efforts.
Comment 25 Francisco 2019-12-05 04:34:14 UTC
Created attachment 156319 [details]
The bug is solved for charts, but not for equations

Dear all,

Sorry, but I mistakenly only checked for charts: the chart remains in the same relative position in the slide.

However, the equation still moves when entering into edit mode.

Again, sorry for my mistake, and thank you for solving the "chart part".
Comment 26 Francisco 2019-12-05 04:35:22 UTC
(In reply to Francisco from comment #25)
> Sorry, but I mistakenly only checked for charts: the chart remains in the
> same relative position in the slide.


Tested in
Versión: 6.3.3.2
Id. de compilación: 1:6.3.3-0ubuntu0.18.04.1~lo1
Subprocs. CPU: 4; SO: Linux 4.15; Repres. IU: predet.; VCL: kde5; 
Configuración regional: en-US (es_AR.UTF-8); Idioma de IU: es-ES
Calc: threaded