Bug 90638 - Page title field doesn't update on renaming the page/slide
Summary: Page title field doesn't update on renaming the page/slide
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: Other All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 114871 (view as bug list)
Depends on:
Blocks: Fields
  Show dependency treegraph
 
Reported: 2015-04-15 14:37 UTC by Katarina Behrens (Inactive)
Modified: 2024-11-15 14:12 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
24.8.2.1 (503.60 KB, image/jpeg)
2024-11-10 09:34 UTC, Chika
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Katarina Behrens (Inactive) 2015-04-15 14:37:33 UTC
I tried to use the new page title field feature (bug 47302) but it didn't quite work as expected ... here's what I've done:

1. New Impress document
2. Menu -> Insert -> Fields -> Page Title ... a field with 'Slide1' content appears
3. Left-most pane w/ slides, right-click 1st slide, select Rename Slide
4. A dialog pops up. Enter a new slide name (e.g. '42'), confirm w/ OK

I'd expect the page title field (page title? really? didn't I just change the slide name?) to change now, so that it contains the updated name (42) but it ain't the case. 
One has to click inside the field and only then the content actually changes to reflect the new slide name.
Comment 1 Buovjaga 2015-04-17 19:22:59 UTC
Reproduced.

Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ (x64)
Build ID: 53d7c88da82f6d16c0c9a45a86a3f9d505764605
TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-10_02:14:19
Locale: fi_FI
Comment 2 QA Administrators 2016-09-20 09:24:41 UTC Comment hidden (obsolete)
Comment 3 Mike 2018-08-06 19:02:12 UTC
Reproduced

Version: 6.1.0.2 (x64)
Build ID: b3972dcf1284967612d5ee04fea9d15bcf0cc106
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: de-DE (de_DE); Calc: group threaded
Comment 4 Timur 2019-12-03 21:12:26 UTC
It's Menu -> Insert -> Fields -> Slide Title now.
Repro 6.5+.
(Used menu to rename, reported right-click bug.)
Comment 5 Timur 2019-12-03 21:13:49 UTC
*** Bug 114871 has been marked as a duplicate of this bug. ***
Comment 6 QA Administrators 2021-12-03 04:36:41 UTC Comment hidden (obsolete)
Comment 7 Steven Casey 2023-11-06 05:11:37 UTC
Still reproducible. Seems to be purely a visual bug. After renaming the slide, it retains the previous slide's title. Press F5 (start slideshow) and it will be updated (just like how on click it updates). Changing title (without "click updating") and then saving the file also shows the correct title on reopen.

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 32; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2b84c860b591457da4c995435f9ca7ce5c7b3d23
CPU threads: 32; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 8 Chika 2024-11-10 09:33:35 UTC
Hello,

I was partially able to reproduce this issue in the latest stable version.

Steps to Reproduce:
1) Open Impress
2) Click Insert
3) Select Field > Slide Title
4) Type some texts 
* Notice that the pre-filled text (ex: “Slide 4”) remains, and the newly entered text is appended to it, resulting in something like “Slide 4abc” instead of just the new text being entered “abc”.

Version: 24.8.2.1 (X86_64) / LibreOffice Community
Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13
CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Adding my comment with the latest information and findings.

Sincerely,

Chika
Comment 9 Chika 2024-11-10 09:34:09 UTC
Created attachment 197521 [details]
24.8.2.1
Comment 10 Buovjaga 2024-11-15 14:12:44 UTC
Comment 8 doesn't seem to have followed the original steps. I still reproduce.

Code pointers: functions SlotManager::InsertSlide and SlotManager::RenameSlide in sd/source/ui/slidesorter/controller/SlsSlotManager.cxx

When adding a new slide via the slide sorter (with the firing of function InsertSlide), the field *is* updated. So somewhere along the journey a view invalidation happens that is missing from the rename case. Unfortunately the exact location eludes me as I apparently got lost in a thicket of threads while debugging.

I also noticed once that renaming did update the field, so it seems possible to hit the invalidation with that action as well, if the stars are right.

Arch Linux 64-bit
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4805277b8d3e93ac652a5ed66d0ed101d64a78c3
CPU threads: 8; OS: Linux 6.11; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Built on 15 November 2024