Bug 90868 - EDITING: Interactive image crop tool can't apply proportional crop
Summary: EDITING: Interactive image crop tool can't apply proportional crop
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Image-Crop
  Show dependency treegraph
 
Reported: 2015-04-25 19:23 UTC by tmacalp
Modified: 2023-04-21 16:55 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tmacalp 2015-04-25 19:23:11 UTC
Description:
The new interactive crop tool in Draw/Impress in 4.4 has no way to perform an proportionally constrained crop.  This is useful if you want to keep your image's aspect ratio while cropping off the sides.  This action would normally be performed by holding down shift while dragging your crop region.

Bug 86329 fixed the preview rectangle overlay that appears while you drag your crop region.  With that bug fixed (merged in master and should hopefully be in 4.4.4), this preview behaves properly and constrains proportions when you hold shift.  Unfortunately, the resulting crop when you release your drag does not behave properly, and ends up wherever you release (not constrained).

Steps to reproduce:
1. New drawing
2. Insert image
3. Right click image and Crop Image
4. Hold shift key and drag a crop region *
5. Note results of attempted constrained crop

* Again note that if testing in versions before bug 86329's fix, the crop drag preview overlay (rectangle while actually dragging) had its behavior reversed, which scaled proportionally by default and holding shift caused it to not constrain.

Expected:
If holding shift while dragging out and releasing crop region, the resulting selection should be constrained.

Actual:
Resulting crop completely ignores the shift key and selects an unconstrained crop region.

Notes:
As far as I know, there is currently NO way perform an accurate constrained crop in Draw/Impress in LO 4.4+.  You completely have to eyeball it.  Before, you could at least use math to figure it out.

I find constrained crop to be VERY handy.  If I have many images on a page, I usually want to keep them all 3:2 or 4:3 or whatever.  This bug really hampers my ability to use LO's built in crop tool.  It will affect me much more if/when this tool is implemented in Writer.
Comment 1 Yousuf Philips (jay) (retired) 2015-04-25 19:42:28 UTC
Confirmed, as mentioned by me in bug 86329 comment 18 answer 4.

Version: 5.0.0.0.alpha1+
Build ID: badec7478035008f514e0976a94438fe2e32dc40
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-04-22_00:50:58
Comment 2 QA Administrators 2016-09-20 09:34:09 UTC Comment hidden (obsolete)
Comment 3 tmacalp 2017-06-01 16:14:03 UTC
This still affects 5.3.3.2.
Comment 4 QA Administrators 2018-06-02 03:09:33 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2020-06-03 03:48:29 UTC Comment hidden (obsolete)
Comment 6 QA Administrators 2022-06-04 03:33:06 UTC Comment hidden (obsolete)
Comment 7 Stéphane Guillou (stragu) 2023-04-21 16:55:49 UTC
Still the case in recent master build:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

The dashed frame shown while dragging does not match the result.