Bug 91053 - cleanup bogus member ...
Summary: cleanup bogus member ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Formula Editor (show other bugs)
Version:
(earliest affected)
4.4.3.2 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks:
 
Reported: 2015-05-03 18:07 UTC by Michael Meeks
Modified: 2017-02-14 08:58 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Meeks 2015-05-03 18:07:09 UTC
StarMath's SmEdit class has a bogus duplicate member checkout:

starmath/source/edit.cxx

The 'xAccessible' and 'pAccessible' point to the same thing.

Instead we should use an rtl::Reference<<SmEditAccessible> replacing the 'xAccessible' member, kill the pAccessible (replace them all with xAccessible) - and life should be good =)

There is a similar commit here:

git log -u -1 c0be3d072956d97f10d3ade9c80c426cb8c6d605

And I imagine there are quite a number of other instances of this sort of pointless-ness around the code =)

Thanks ! =)
Comment 1 Commit Notification 2015-06-01 07:39:11 UTC
Takeshi Abe committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8c5471c3a625c42523b144cf8d1dddf75f4a2746

tdf#91053 cleanup bogus member ...

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 2 Robinson Tryon (qubit) 2015-12-13 11:04:06 UTC Comment hidden (obsolete)
Comment 3 Robinson Tryon (qubit) 2016-02-18 14:52:20 UTC Comment hidden (obsolete)