Bug 91332 - Saving XLSX File Removes textbox Linked to Other Tabs
Summary: Saving XLSX File Removes textbox Linked to Other Tabs
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.3.2 release
Hardware: All All
: high major
Assignee: Tünde Tóth
URL:
Whiteboard: interoperability target:7.6.0 target:...
Keywords: bibisected, bisected, filter:xlsx, regression
Depends on:
Blocks: XLSX-Limitations Excel-2013-Templates XLSX-Shapes
  Show dependency treegraph
 
Reported: 2015-05-16 19:09 UTC by Joel Madero
Modified: 2023-04-27 07:17 UTC (History)
12 users (show)

See Also:
Crash report or crash signature:


Attachments
Original.xlsx (39.37 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2015-05-16 19:09 UTC, Joel Madero
Details
Minimized test document (11.57 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-09-22 12:11 UTC, NISZ LibreOffice Team
Details
The example file saved with Calc master (8.23 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-09-22 12:12 UTC, NISZ LibreOffice Team
Details
The minimized example file in Exel and Calc (83.66 KB, image/png)
2020-09-22 12:14 UTC, NISZ LibreOffice Team
Details
The example file saved with Calc in Excel and Calc (78.50 KB, image/png)
2020-09-22 12:30 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Madero 2015-05-16 19:09:31 UTC
Created attachment 115666 [details]
Original.xlsx

Windows 7
Version: 5.0.0.0.alpha1+
Build ID: 6664859e1e8b3f8b7db8c931b8d0335510c20ce0
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-05-16_03:18:47
Locale: en-US (en_US)

1) Open original.xlsx

observed: There are buttons that allow navigating between sheets (near column k on the top)

2) Save file as a new name (keep same xlsx extension)
3) Close file;
4) Open file

Observed: Controls are now gone
Expected: Controls remain 

Marking as Major as there is loss of data
Comment 1 A (Andy) 2015-05-16 19:30:38 UTC
Reproducible with LO 4.4.3.2, Win 8.1
Comment 2 Markus Mohrhard 2015-05-27 17:49:06 UTC
Regression from bc0a9076aa43a0782bcf81e55d3f84f6af0f68e8.

The concept there is broken and I asked on the mailing list if the person responsible will fix it or if I can just disable the whole stuff that is causing this regression.
Comment 4 Jean-Baptiste Faure 2016-04-19 18:22:09 UTC
(In reply to Markus Mohrhard from comment #2)
> Regression from bc0a9076aa43a0782bcf81e55d3f84f6af0f68e8.
> 
> The concept there is broken and I asked on the mailing list if the person
> responsible will fix it or if I can just disable the whole stuff that is
> causing this regression.

No decision about that ?

According to comment #1, version set to 4.4.3.2

Best regards. JBF
Comment 5 Aron Budea 2016-09-01 05:21:31 UTC
Based on Markus's comment, it seems like this should be fixed (reversed) as soon as possible. Raising priority to high.
Comment 6 QA Administrators 2018-06-20 02:49:35 UTC Comment hidden (obsolete)
Comment 7 Jacobo Aragunde Pérez 2018-06-20 08:51:38 UTC
Still reproducible.

Version: 6.0.4.2
Build ID: 6.0.4.2-2.fc28
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: gtk3; 
Locale: es-ES (en_US.UTF-8); Calc: group
Comment 8 Xisco Faulí 2019-05-18 15:28:45 UTC
Still reproducible in

Version: 6.3.0.0.alpha1+
Build ID: 787525a314de9c8178d0fedcd71ddbd08ec41a55
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 9 NISZ LibreOffice Team 2020-09-22 12:11:35 UTC
Created attachment 165767 [details]
Minimized test document

Only one sheet and only the shapes, ungrouped.
Comment 10 NISZ LibreOffice Team 2020-09-22 12:12:14 UTC
Created attachment 165768 [details]
The example file saved with Calc master

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 52a49f9e480ca03e231cfda82640a928393131c9
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 11 NISZ LibreOffice Team 2020-09-22 12:14:59 UTC
Created attachment 165769 [details]
The minimized example file in Exel and Calc
Comment 12 NISZ LibreOffice Team 2020-09-22 12:30:45 UTC
Created attachment 165770 [details]
The example file saved with Calc in Excel and Calc

So this file has shapes filled with colors from a theme: not a default shape + line color combination is used, but a fill color from the palette.
This combination is not converted to theme-independent fill color yet.

Root of the problem is that Calc does not write the themeN.xml files to XLSX, only references to theme colors. In this example not the Excel 2013 default theme and its colors is used so Excel tries to apply the color reference to the default theme - this is why the light green shapes become blue.
Comment 13 QA Administrators 2022-09-23 04:31:49 UTC Comment hidden (obsolete)
Comment 14 Commit Notification 2023-04-25 13:04:43 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2ef83c8782ed947b47f9292a12355fc3bb078078

tdf#91332 XLSX export: fix missing solidFill

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2023-04-26 09:59:43 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/eba5256cba797c67e13d8fc99cb213d6113fcb6a

tdf#91332 XLSX export: fix missing solidFill

It will be available in 7.5.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 NISZ LibreOffice Team 2023-04-27 07:17:46 UTC
Verified in:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9a555d79b3b00793edf1d51a8a7c76b723cc436d
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL threaded