Bug 91565 - REPORT BUILDER: Missing insert field icon in Add Field dialog
Summary: REPORT BUILDER: Missing insert field icon in Add Field dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
3.5.7.2 release
Hardware: All All
: low normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Database-Reports-Builder Icon-Themes-Code
  Show dependency treegraph
 
Reported: 2015-05-24 06:49 UTC by sawakaze
Modified: 2019-09-24 18:31 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Attachement is "Add Field Dialog". Insert button is right (12.13 KB, image/png)
2015-05-24 06:49 UTC, sawakaze
Details
screenshot (12.60 KB, image/png)
2015-10-11 15:17 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sawakaze 2015-05-24 06:49:59 UTC
Created attachment 115945 [details]
Attachement is "Add Field Dialog". Insert button is right

Insert icon is not shown on report builder "add field dialog".
Insert button is shown. is it true?

Insert icon on LibreOffice 4.4 is shown.

OS : Linux
Comment 1 Robert Großkopf 2015-05-25 18:48:24 UTC
I could confirm a button is shown. In older version appears a icon - but this icon doesn't look as a icon for inserting anything. The same icon has been used in older LO-versions for deleting or sorting groups in a report. It seems to be a default-icon, if there couldn't be found any icon, but a icon had been planned. So the short-help while pushing the mouse over the icon is needed to understand the reason for the icon.

I set this bug to New, but the Importance to low. I would prefer the button instead of an icon without relationship to the command "Insert".
Comment 2 Yousuf Philips (jay) (retired) 2015-05-26 22:25:07 UTC
Is the 'Insert' icon shown when you have the Galaxy icon theme selected (Tools > Options > View )?
Comment 3 Julien Nabet 2015-10-11 13:29:18 UTC
(In reply to Yousuf (Jay) Philips from comment #2)
> Is the 'Insert' icon shown when you have the Galaxy icon theme selected
> (Tools > Options > View )?

On pc Debian x86-64 with master sources updated today, default theme is Tango for me. In this case, no icon, just "Insert".
If I choose Galaxy theme, there's an icon, but its purpose is not very clear if we don't hover the mouse on it to have the short help as Robert indicated.
Comment 4 Yousuf Philips (jay) (retired) 2015-10-11 15:08:38 UTC
(In reply to Julien Nabet from comment #3)
> On pc Debian x86-64 with master sources updated today, default theme is
> Tango for me. In this case, no icon, just "Insert".

Means that the change in the icon system in 5.0 isnt working correctly if galaxy is installed and the galaxy icon isnt showing in tango when tango doesnt have the icon.

> If I choose Galaxy theme, there's an icon, but its purpose is not very clear
> if we don't hover the mouse on it to have the short help as Robert indicated.

Would be useful to get a screenshot of the dialog with galaxy icons,

Digging through the source code, i found references to the insert button as RID_STR_INSERT and m_aInsertButton in the following files, but couldnt track down the uno command or icon filename path.

reportdesign/source/ui/report/report.src
reportdesign/source/ui/dlg/AddField.cxx
reportdesign/source/ui/inc/AddField.hxx

It would be useful to know some exact steps to open this dialog in Base.

@Maxim: Could you track down which icon it is?
Comment 5 Julien Nabet 2015-10-11 15:17:43 UTC
Created attachment 119516 [details]
screenshot

To reproduce this:
1) create a brand new odb file (hsql embedded)
2) create a table with wizard with 2 fields taskid, Notes => finish button, close table 
3) click Reports on Database pane (at left)
4) Create a report in Design view
5) Click on a field so the insert icon is enabled
(see attachment)
Comment 6 Julien Nabet 2015-10-11 15:37:12 UTC
This code pointer may help to start investigation:
http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/CondFormat.src#57
Comment 7 Yousuf Philips (jay) (retired) 2015-10-11 19:44:17 UTC
(In reply to Julien Nabet from comment #5)
> Created attachment 119516 [details]
> screenshot

The icon used for insert button is the broken image icon (/icon-themes/galaxy/res/grafikde.png), which explains why the icon wasnt understandable.

(In reply to Julien Nabet from comment #6)
> This code pointer may help to start investigation:
> http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/
> CondFormat.src#57

Thanks for the pointer. Looking at link below, you can see that they have only assigned icons to 3 of the buttons in the dialog and the insert icon is likely just taking the broken image icon as none was assigned to it.

http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/dlg/CondFormat.src#94

So i see the broken image icon has always been displayed in galaxy and tango all the way back to 3.5.7, so this has always been broken. So what is needed is to decide which icon should be used for the Insert button.

We could use the 'Add Field' icon :-

http://cgit.freedesktop.org/libreoffice/core/plain/icon-themes/galaxy/cmd/lc_addfield.png

http://cgit.freedesktop.org/libreoffice/core/plain/icon-themes/tango/cmd/lc_addfield.png

Would be useful to also change the tooltip from just 'Insert' to 'Insert Field' or something like that.
Comment 8 QA Administrators 2016-11-08 11:32:46 UTC Comment hidden (obsolete)
Comment 9 Robert Großkopf 2016-11-08 17:46:42 UTC
Nothing changed. No Icon for Insert in the dialog, only a button with "Insert" written on it.
Comment 10 QA Administrators 2018-06-25 02:42:19 UTC Comment hidden (obsolete)
Comment 11 Robert Großkopf 2018-06-25 15:53:02 UTC
Bug still exists with LO 6.0.5.2, OpenSUSE 42.3 Leap, 64bit rpm Linux.
Comment 12 QA Administrators 2019-06-26 02:46:18 UTC Comment hidden (obsolete)
Comment 13 Robert Großkopf 2019-06-26 14:17:49 UTC
Bug still exists on LO 6.2.4.2, OpenSUSE 15 64bit rpm Linux
Comment 14 Julien Nabet 2019-09-23 19:45:05 UTC
Heiko/Xisco: any thoughts about UI point from https://bugs.documentfoundation.org/show_bug.cgi?id=91565#c7 ?
Comment 15 Rizal Muttaqin 2019-09-24 18:31:35 UTC
Reproducible with Karasa Jaga icons in 6.4 master build

Version: 6.4.0.0.alpha0+
Build ID: ee8bc3fbd5aa83112cd9cfef6788d2b3a2e55afe
CPU threads: 4; OS: Linux 5.0; UI render: default; VCL: gtk2; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-16_00:22:26
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

Though there's icon-themes/karasa_jaga/res/grafikde.png icon included.

I have tried to copy Galaxy icons to the dev directory and the result is the same: there's no icons appear.

Just tell us which icon should be added.