Bug 92460 - FILESAVE: saving any file freezes LibO
Summary: FILESAVE: saving any file freezes LibO
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha0+ Master
Hardware: Other Windows (All)
: highest blocker
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:5.1.0
Keywords: bibisected, bisected, regression
: 92477 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-30 18:28 UTC by Buovjaga
Modified: 2016-10-25 19:21 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2015-06-30 18:28:38 UTC 
Open any of the applications, try to save a file and it freezes.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: f33700200901ff5d54fbbbb12053e1f1ccad1739
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-29_22:45:51
Locale: fi-FI (fi_FI)
Comment 1 tommy27 2015-06-30 19:03:57 UTC 
no freeze under Win8.1x64 using LibO 5.1.0.0.alpha1+
Build ID: df7595a5f5871f8343e4ee3869ad153e3ae4a7f3
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-25_14:29:31
Locale: en-US (it_IT)

I'll retest with a newer build
Comment 2 tommy27 2015-06-30 19:15:53 UTC 
reproducible using LibO 5.1.0.0.alpha1+
Build ID: f33700200901ff5d54fbbbb12053e1f1ccad1739
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-29_22:45:51
Locale: en-US (it_IT)

critical regression needs  bibisecting... should be a small committ range since a few days ago it worked
Comment 3 tommy27 2015-06-30 19:56:09 UTC 
same issue with LibO  5.1.0.0.alpha1+
Build ID: ec44f1ae39e44f55ef1b1625fc5f638d2dbf5256
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-27_22:18:34
Locale: en-US (it_IT)
Comment 4 Buovjaga 2015-07-01 10:31:36 UTC 
Export to PDF freezes, too.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64)
Build ID: 3a6ec53eeeec71312f5ea890689f9c2ee79c2aac
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-01_02:24:40
Locale: fi-FI (fi_FI)
Comment 5 tommy27 2015-07-01 12:09:56 UTC 
it works with Build ID: ee3d40b30816a8fc6d4e8f984659c8dfac19ec3b
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-26_00:21:32
Locale: en-US (it_IT)

so the regression took place between 26th and 27th june
Comment 6 tommy27 2015-07-01 15:28:47 UTC 
info taken from the QA mailing list.

On Wed, 01 Jul 2015 14:26:53 +0200, Matthew J. Francis <mjay.francis@gmail.com> wrote:
>
> Assuming it's a Windows specific bug, a strong candidate in that range  
> is:
>
> commit 482c52e91fe41a52e68827e9bf64a9736427d517
> Author: Michael Stahl <mstahl@redhat.com>
> Date:   Fri Jun 26 13:01:51 2015 +0200
>
>      vcl: fix Win32 deadlocks from SolarMutexReleaser
>
>
> Regards
> Matthew Francis

adding Micheal Stahl to CC list ?
Comment 7 Michael Stahl (allotropia) 2015-07-01 22:06:36 UTC 
yes this was triggered by SolarMutexReleaser fix

fixed on master
Comment 8 Commit Notification 2015-07-01 22:07:20 UTC 
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c18f11587d37f285a95447dd8996c8b605732e00

tdf#92460: fpicker: fix VistaFilePicker using SolarMutexReleaser

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 9 Maxim Monastirsky 2015-07-02 11:41:39 UTC 
*** Bug 92477 has been marked as a duplicate of this bug. ***
Comment 10 Buovjaga 2015-07-03 12:55:56 UTC 
Doesn't crash anymore.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64)
Build ID: 8b788891796ff0571f779cdbe8ce809c35c42754
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-02_23:09:27
Locale: fi-FI (fi_FI)
Comment 11 Robinson Tryon (qubit) 2015-12-17 09:15:35 UTC Comment hidden (obsolete)