Steps to reproduce: 1. With a recent build of LO 5.1 launch it with $ SAL_USE_VCLPLUGIN=gtk soffice 2. Open a tabbed Dialog box such Format->Paragraph 3. Do the same with $ SAL_USE_VCLPLUGIN=gtk3 soffice Note the text in gtk3 is white on light gray, which is very hard to read.
Created attachment 117266 [details] gtk2 vs gtk3 in Ubuntu 15.4
→ NEW
I can confirm reverting http://cgit.freedesktop.org/libreoffice/core/commit/?id=031a347668e56c1b38c0539d30e9a1cbb808ca02 resolves this issue. With GTK3 the tabs are using the theme's font color but not background color. Caolán, Would it be possible to use the background color too? If not, reverting to the none-themed tabs would be better than the current situation.
regression is misleading in this context
Björn, If this doesn't get fixed before 5.1 makes it into Ubuntu, you'll want to force GTK2.
Maxim is working on theme consistency issues. See Bug 93558
This is not a dark theme/light theme issue. Both Ubuntu's dark theme Ambiance and light theme Radiance have the same issue. In Debian Jessie, when you use the tweak-tool to change to a dark theme, it correctly changes the tab color in LibreOffice. Another difference between Debian's Dark theme and Ubuntu's, is that the dark them in Debian also changes the sidebar. However unlike the tabs, the sidebar uses the correct uses black text. Maxim or Björn, It seems that Ubuntu's theme information is incomplete. Should a launchpad bug be filed? In any case, we need to emulate the sidebar's fall-back behavior. If you can't read the background color, don't change the font color.
*** Bug 96715 has been marked as a duplicate of this bug. ***
*** Bug 97793 has been marked as a duplicate of this bug. ***
There are two more issues on Ubuntu associated with gtk2-vs-gtk3 behavior. First is missing global menu and HUD in gtk3. Nonoperability of the global menu is clearly seen in the screenshot attached to this bug report. The other is broken scrollbars. It is not seen on the screenshot, but the current state is that the slider within the modern gtk3-style scrollbars fills the area of the scrollbar with its color as it moves just like a paint brush. I don't know if these issues can be considered as part of this bug or should be considered as separate bugs? Ubuntu 15.10 x64 LibreOffice 5.1.1.2 (1:5.1.1~rc2-0ubuntu1~wily0) installed from ppa:libreoffice/ppa
Doctor Rover, Thank you for your input, but please do not treat the bug tracker like a discussion forum. See https://wiki.documentfoundation.org/QA/BugReport#One_Report.2C_Five_Bugs "One report should only have a single bug in it. Developers are unlikely to take on a bug that has multiple issues listed." Please do not add noise here. If you want to help, file clear concise bug reports and link them with the "See Also".
*** Bug 102258 has been marked as a duplicate of this bug. ***
Vendor-patched on Ubuntu 16.10 with: https://git.launchpad.net/~libreoffice/ubuntu/+source/libreoffice/commit/?h=ubuntu-yakkety-5.2&id=6808808925f82839fd7f2bbfead4ddfa3081619b Ubuntu 16.10 uses gtk+3.0 3.20.9-1ubuntu2. Curiously, this does _not_ happen with the LibreOffice snap builds running on Xenial snap base and a Xenial host -- thus both using gtk+3.0 at 3.18.9-1ubuntu3.1.
Created attachment 127947 [details] LibreOffice 5.2.2 runs from snap on Ubuntu 16.04
Created attachment 127948 [details] vendor-patched LibreOffice 5.2.2 run on Ubuntu 16.10 (gtk+3.0 3.20) (Adding screenshot of LibreOffice 5.2.2 with vendor-patch from comment 13, without the patch it looks white-on-white as per attachment 117266 [details]. This suggests the theming is ok with 3.18, but broke with 3.20 -- either because of the theme, because of gtk3 itself or because of our gtk3 implementation in LibreOffice when build against 3.20.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=570669631359021a8ad420753c87bcf4419d06cd Related: tdf#92776 set parent style of notebook to toplevel window style It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
caolanm->bjoern: Can you check if this fixes the problem for you.
(In reply to Caolán McNamara from comment #17) > caolanm->bjoern: Can you check if this fixes the problem for you. Backported the fix to 5.2 to test and the fix solves the issue. Thank you so much for digging into this! Marking this RESOLVED/FIXED, setting as assignee (along with kudos and credit) to Caolan, as he fixed this.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=69c9acd4b8dcd7ec8a5c3c380ad5cd8b797661ea Resolves: tdf#92776 ensure correct notebook tab font color It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you very much Caolán for this fix. It works for me in the master under Ubuntu 16.04 x86-64. Do you plan to backport the fix to 5.2 branch ? Best regards. JBF
Problem is back: with the current master built at home under Ubuntu 16.10 x86-64, I get the same result as in first screen copy: https://bugs.documentfoundation.org/attachment.cgi?id=117266 Best regards. JBF
Ubuntu 16.10 is using gtk3 3.20 which has a different theming system in practice than the earlier gtk3 of Ubuntu 16.04. Oddly gtk3 3.20 is the version we use in Fedora 24 and has the "new" theming system which is better documented, so its odd that this isn't working right, and I can't see why. I'll attach a standalone program which reproduces the problem.
Created attachment 128758 [details] standalone get label text color in a notebook tab this is supposed to get the label text color in a notebook tab, see comment at to of tabcolor.c to compile
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=567580bddfa7b3d437b072698de77968c6513513 Resolves: tdf#92776 tab names unreadable under Ambiance theme 3.20 It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #24) > Caolán McNamara committed a patch related to this issue. > It has been pushed to "master": > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=567580bddfa7b3d437b072698de77968c6513513 > > Resolves: tdf#92776 tab names unreadable under Ambiance theme 3.20 > [...] > Affected users are encouraged to test the fix and report feedback. Now it works as expected! Tested in my own build of Version: 5.3.0.0.alpha1+ Build ID: 234325b9fc0d54e594de8e5d2e7c717684db1745 Threads CPU : 4; Version de l'OS :Linux 4.8; UI Render : par défaut; VCL: gtk3; Layout Engine: new; Ubuntu_16.10_x86-64 Locale : fr-FR (fr_FR.UTF-8); Calc: group Thank you very much. Closing as fixed again. Best regards. JBF
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-2": http://cgit.freedesktop.org/libreoffice/core/commit/?id=83dc2227f35795aee4e2ccaccbb7d67d4c50ba3f&h=libreoffice-5-2 Resolves: tdf#92776 backport gtk3 >= 3.20 themeing improvements It will be available in 5.2.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.