Bug 92921 - Impress Custom Animation Default Text Grouping Off By One
Summary: Impress Custom Animation Default Text Grouping Off By One
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.4.4.3 release
Hardware: x86-64 (AMD64) Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Animation Object-Animations
  Show dependency treegraph
 
Reported: 2015-07-25 01:23 UTC by Daniel Collins
Modified: 2019-03-28 08:18 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Collins 2015-07-25 01:23:43 UTC
In Impress, when applying an animation to a text element, the default grouping is always one *less* than the paragraph level present in the text item. This seems likely unintentional and undesired. Example:

- In Impress, select a text box with 2nd level paragraphs.
- In Custom Animation, click Add Effect (+)
- Click "OK" (default Entrance: Appear)
- Test the animation: text will appear by 1st level paragraph grouping.
- In Custom Animation, right-click element > Effect Options > Text Animation > note it is currently listed as "By 2nd level paragraphs" (despite that not actually happening).
- Now click on that same "By 2nd level paragraphs" in the drop-down menu, and click "OK"
- Test the animation: text will now appear correctly by 2nd level paragraph grouping.

Likewise: If you have only 1st level paragraphs, then all the text will appear at once. Or if you have 3rd level paragraphs present, then the default is to appear by 2nd level paragraphs. In each case, the default "Text Animation" lists the lowest-level grouping, but the animation actually does one less than that (until one manually clicks on the same lowest-level grouping for each animation element). I'm taking a stab that this is some classic off-by-one error.

I suppose that this is somewhat related to bug 48553, in that if the choice was made to switch back to "one object" by default, then this bug would be irrelevant. Personally I like defaulting to the lowest-level paragraph, as shown in the default Text Animation -- but either way, the slideshow should not perform one less level of grouping than shown in the drop-down UI on creation.
Comment 1 Buovjaga 2015-07-31 13:13:45 UTC
Reproduced.
A bulleted list with a 1st level entry and a 2nd level entry.
Effect Options > Text Animation shows "By 2nd level paragraphs".
Viewing the presentation shows both of the entries at once.
Going back to effect options and clicking at the "By 2nd level paragraphs" again and OK, now the entries appear in order (1st, then 2nd level entry).

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: 902255645328efde34ddf62227c8278e8dd61ff0
TinderBox: Win-x86@39, Branch:master, Time: 2015-07-30_03:52:07
Locale: en-US (fi_FI)
Comment 2 QA Administrators 2016-09-20 10:22:01 UTC Comment hidden (obsolete)
Comment 3 Daniel Collins 2018-01-03 04:35:40 UTC
This bug is still present (Version: 5.3.7.2 (x64), on Windows 7 Home Premium Service Pack 1 64-bit). 

Behavior seems changed from first report. Currently on creating animation, animation is always by top level, although the interface claims it is by lowest level available (whether 2nd or 3rd level paragraphs, etc.)
Comment 4 Brian Fraser 2019-03-28 08:18:33 UTC
This bug appears to have been fixed and the text grouping now works correctly.
Specifically: when adding an animation for a text element, it defaults to grouping by the first level paragraph regardless of how many levels of paragraphs are present in the text.

Testing on: 
Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 12; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded