Bug 93476 - Macro library list doesn't get sorted after importing a macro library
Summary: Macro library list doesn't get sorted after importing a macro library
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
4.4.4.3 release
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Andreas Heinisch
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-17 00:39 UTC by sworddragon2
Modified: 2019-09-04 06:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sworddragon2 2015-08-17 00:39:44 UTC
After importing a macro library the list doesn't get updated until the menu gets opened again. Steps to reproduce:

1. Open Writer.
2. Go to the menu bar -> Tools -> Macros -> "Organize Macros" -> "LibreOffice Basic..." -> Organizer... -> Libraries and click in "Import...".
3. Import a macro library that would normally be sorted before the default one.
4. Click on "OK".
5. Click on "Close".
6. Go to Organizer... -> Libraries.


After step 4 the list is unsorted but after step 6 the list is sorted again.
Comment 1 raal 2015-08-25 14:04:57 UTC
Reproducible with Verze: 5.0.0.5
ID sestavení: 1b1a90865e348b492231e1c451437d7a15bb262b
Comment 2 Cor Nouws 2015-09-08 13:43:27 UTC
(For the record: There is also the problem that inserted functions are not sorted properly, until a close and reopen of the library is performed )
I would guess this problem is as old as Methusalem ?
Comment 3 QA Administrators 2016-09-20 10:28:57 UTC Comment hidden (obsolete)
Comment 4 Andreas Heinisch 2019-06-25 14:52:26 UTC
I committed a first patch: https://gerrit.libreoffice.org/#/c/74692/

But this behaviour can be observed in the Modules and Dialogs as well. I try to fix them too.
Comment 5 Commit Notification 2019-07-05 09:43:08 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/ff7e327e9e537ea129464a1de5a01bf32c1b9fd3%5E%21

tdf#93476 Sort Macro library list after creating/importing a macro

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-08-03 18:24:02 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/087f778579900998e8a37e2e9581ea230870a26e%5E%21

tdf#93476 Sort Macro library list after creating/importing a macro

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-08-04 10:56:23 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/a1b700a787e2f5bb46f7b39a704aed7c3c81bed9%5E%21

tdf#93476 Sort Macro library list after creating/importing a macro

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2019-09-04 06:53:28 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e8b3df5b9b0eb0a93c25b6dc2e445ae44a7e3f78%5E%21

tdf#93476 Sort Macro library list after creating/importing a macro

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.