Bug 93603 - No separator line when toolbars are vertical in some themes
Summary: No separator line when toolbars are vertical in some themes
Status: RESOLVED DUPLICATE of bug 91742
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-23 16:53 UTC by Yousuf Philips (jay) (retired)
Modified: 2015-08-27 00:11 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (85.73 KB, image/png)
2015-08-23 16:53 UTC, Yousuf Philips (jay) (retired)
Details
screenshot (75.23 KB, image/png)
2015-08-26 19:05 UTC, Efe Gürkan YALAMAN
Details
windows 7 screenshot (78.65 KB, image/png)
2015-08-26 21:33 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-08-23 16:53:41 UTC
Created attachment 118103 [details]
screenshot

There isnt a separator line when toolbars are moved to the left and right of the UI. This should be based on whether a user's theme has this separator line. At the moment, this enhancement would improve the current drawing toolbar in 5.0.
Comment 1 Yousuf Philips (jay) (retired) 2015-08-23 17:05:35 UTC
Setting to NEW as enhancement.
Comment 2 Efe Gürkan YALAMAN 2015-08-26 19:05:03 UTC
Created attachment 118204 [details]
screenshot

Hi Jay,

I don't know if it is 5.0 only or not. It might be also related the gtk theme or something like that. I have the toolbar borders you have on Debian 8 with Gnome 3.14.1


Build ID: 32069752b94a31303fd327b0c47037072600be6c
Locale: en-US (en_US.UTF-8)

Cheers,
Comment 3 Yousuf Philips (jay) (retired) 2015-08-26 21:33:42 UTC
Created attachment 118206 [details]
windows 7 screenshot

Yes this issue is based on the theme, as when i go through the themes on linux, some of them have a line separator (crux, industrial, redmond) and some dont (clearlooks, mint-x, mist). But for the ones that dont, the separator does appear when the toolbars are docked at the top.
Comment 4 Maxim Monastirsky 2015-08-26 23:10:31 UTC
(In reply to Efe Gürkan YALAMAN from comment #2)
> Created attachment 118204 [details]
> screenshot
> 
> Hi Jay,
> 
> I don't know if it is 5.0 only or not. It might be also related the gtk
> theme or something like that.
This screenshot is apparently of the GTK3 plugin, which has 3D borders for all toolbars regardless of the theme. Jay's report is about GTK2. (BTW I guess we should get rid of those ugly 3D borders in GTK3, the same way we did for Windows in 3.6?)

(In reply to Yousuf (Jay) Philips from comment #3)
> Yes this issue is based on the theme,
I'm a bit confused here, given what you stated in comment 0 that "This should be based on whether a user's theme has this separator line." Can you clarify this please?

*** This bug has been marked as a duplicate of bug 91742 ***
Comment 5 Yousuf Philips (jay) (retired) 2015-08-27 00:11:35 UTC
(In reply to Maxim Monastirsky from comment #4)
> (In reply to Yousuf (Jay) Philips from comment #3)
> > Yes this issue is based on the theme,
> I'm a bit confused here, given what you stated in comment 0 that "This
> should be based on whether a user's theme has this separator line." Can you
> clarify this please?

Yes when a user's theme has a separator when the toolbar is placed above, it should also have a separator when it is placed vertically, which isnt happening on windows 7 or on linux with clearlook theme. On mac, there isnt a separator for toolbars (http://download.softwsp.com/sites/12/2015/08/libreoffice-mac-001.jpg), so the separator shouldnt appear on mac if the toolbar was vertical.

> *** This bug has been marked as a duplicate of bug 91742 ***

Silly, silly me. :D