Bug 93610 - cannot flip .PNG properly in Writer and Draw with LXDE
Summary: cannot flip .PNG properly in Writer and Draw with LXDE
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
5.0.1.1 rc
Hardware: Other Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: needs:LXDE
Keywords: regression
Depends on:
Blocks:
 
Reported: 2015-08-24 02:27 UTC by Viruch Hemapanpairo
Modified: 2016-04-24 16:09 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
sample document on flipping images (163.62 KB, application/vnd.oasis.opendocument.text)
2015-08-25 00:47 UTC, Viruch Hemapanpairo
Details
the .odg file with the same problem with the same images (163.22 KB, application/vnd.oasis.opendocument.graphics)
2015-08-25 00:48 UTC, Viruch Hemapanpairo
Details
Some .png image can be flipped normally (6.30 MB, application/vnd.oasis.opendocument.text)
2015-08-25 00:58 UTC, Viruch Hemapanpairo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Viruch Hemapanpairo 2015-08-24 02:27:56 UTC
Version: 5.0.2.0.0+
Build ID: 4d1b6057627c1fbee8cceefe77f9fb1c0af836d5
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-5-0, Time: 2015-08-23_17:12:01
Locale: en-US (en_US.UTF-8)

When insert any image into Writer document. The image cannot flip properly.
Comment 1 tommy27 2015-08-24 12:55:47 UTC
please give step by step instructions how to reproduce the bug.
does it happens with any file or with some specific file or format? 
which is your exact Linux version?
Comment 2 Viruch Hemapanpairo 2015-08-24 13:41:14 UTC
I tried with 2-3 picture files which produce the same result. The image cannot be flipped properly as it used to be in LibO 4.4.3, the version I use for daily tasks. So I think it could be happen with any image file after inserting onto the document. The problem occur only in Writer and Draw, not in Calc and Impress.

I'm using Lubuntu 14.04 for my daily work with LibO 4.4.3 as the latest version which there's no problem for me. The current build version on my laptop is:

Version: 5.0.2.0.0+
Build ID: 8578df9017ab3786f7c40929220c4db36b090a06
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-5-0, Time: 2015-08-24_10:09:54
Locale: en-US (en_US.UTF-8)

The step of spotting this problem is quite normal
1. Insert any image onto the document (Writer or Draw)
2. Right click at the image and choose "Flip" -- both Vertical or Horizontal won't work properly.

Regards,
Viruch H.
Comment 3 Viruch Hemapanpairo 2015-08-24 13:45:30 UTC
Sorry, the problem seems to affect the .png format of images only.
Comment 4 tommy27 2015-08-24 15:28:35 UTC
(In reply to Viruch Hemapanpairo from comment #3)
> Sorry, the problem seems to affect the .png format of images only.

edited summary notes.

I do not reproduce issues under Win8.1 x64 using LibO 5.1.0.0.alpha1+
Build ID: 7d3fa6bae9f7a755eb2d0ca24bf1afd5f3646bb7
TinderBox: Win-x86@39, Branch:master, Time: 2015-08-09_08:38:08
Locale: it-IT (it_IT)

my daily build is however older than yours so I cannot exclude a recent regression...

however it would be important to see what do you exactly mean "won't work properly" ...

would you please upload a test file and a screenshot showing the different "flip" behaviour in LibO 4.4.x and 5.0.2+ ?

P.S. LibO 4.4.x latest release is 4.4.5 not 4.4.3 so it's better to upgrade since the 4.4.5 solves almost 200 bugs present in 4.4.3
Comment 5 Viruch Hemapanpairo 2015-08-25 00:47:13 UTC
Created attachment 118160 [details]
sample document on flipping images

Attached here is the file with problem on flipping the images. The .png format cannot be flipped as normal as the .jpg one.
Comment 6 Viruch Hemapanpairo 2015-08-25 00:48:20 UTC
Created attachment 118161 [details]
the .odg file with the same problem with the same images
Comment 7 Viruch Hemapanpairo 2015-08-25 00:58:11 UTC
Created attachment 118162 [details]
Some .png image can be flipped normally
Comment 8 Viruch Hemapanpairo 2015-08-25 01:07:25 UTC
PS: There's one bug (Bug 93098)just resolved by 5.0.2 daily build, and they informed that the patch will be included in LibO 4.4.6 or 5.0.2 official released. That's why I suspend my usage on LibO 4.4.3 as my latest one.

Regards,
Viruch H.
Comment 9 tommy27 2015-08-25 07:37:23 UTC
I can flip that png with 5.0.0.4 and 5.1.0.0 alpha (9 august build)
so it's probably Linux specific
Comment 10 V Stuart Foote 2015-08-25 13:19:39 UTC
On Windows 10 Pro, 64-bit en-US

Both JPEG and PNG can be "flipped" in Writer.

Steps:

1. Open document in Writer
2. select either image PNG or the JPEG
3. open its context menu
4. select the Format Image to open Image dialog
5. select the Image tab
6. click Flip check-boxes Vertically/Horizontally
7. image preview is altered
8. OK to apply to image in document


I could not confirm in Windows on the 5.0.1 release

Version: 5.0.1.2 (x64)
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: en-US (en_US)

nor on a 5.0 daily

Version: 5.0.2.0.0+
Build ID: a803ec69f69068e0c45a7825094941b9ea765c1c
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-0, Time: 2015-08-20_11:49:20
Locale: en-US (en_US)

nor on Master

Version: 5.1.0.0.alpha1+ (x64)
Build ID: d0489d0827fc6cef04d0f3602023d82ceda82480
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-08-21_22:27:16
Locale: en-US (en_US)
Comment 11 V Stuart Foote 2015-08-25 13:37:11 UTC
Also, same results with Draw and attachment 118161 [details] on 5.0.1.2, 5.0.2.0+, and 5.1.0.0+ on Windows as in comment 10, can not confirm on Windows.
Comment 12 Joel Madero 2015-08-27 17:56:20 UTC
Ubuntu 15.04 x64
LibreOffice 5.0.0.5

Works fine - I can flip using instructions in comment 10.
Comment 13 steve 2015-08-27 18:00:25 UTC
Works on OS X 10.10.5
LO Version: 5.1.0.0.alpha1+
Build ID: b2363e98af7b0281279617e43b8fec5b898b9120
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2015-08-25_23:42:33
Locale: de-DE (de.UTF-8)

So since this could not be reproduced on neither WIN, OSX nor Linux, setting to WORKSFORME.

Please try with LO 5.1 newest master build.
Comment 14 Viruch Hemapanpairo 2015-08-28 10:43:50 UTC
Still have this problem on Lubuntu 14.04.3
Version: 5.1.0.0.alpha1+
Build ID: b2363e98af7b0281279617e43b8fec5b898b9120
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2015-08-26_00:58:14
Locale: en-US (en_US.UTF-8)

Anyway, since LibO 4.4.3 doesn't affect from this problem. Is there any clue to solve this?
Comment 15 V Stuart Foote 2015-08-28 13:25:54 UTC
Confirmed, On Fedora21 with DESKTOP_SESSION=LXDE with
Version: 5.0.1.1
Build ID: 13f702ca819ea5b9f8605782c852d5bb513b3891
Locale: en-US (en_US.UTF-8)

The PNG in the ODG attachment 118161 [details] does not "flip" in Draw. And when attachment 118160 [details] is opened in Writer, the same PNG will not "flip" from the image Image dialog.

What is interesting is that in Writers Image dialog--the preview of the transform applied to the PNG shows it as "flipped" and the checkbox remain selected as the dialog is closed and reopened. But the image on the canvas is not rendered "flipped".

Setting NEW and adding a needs:LXDE
Comment 16 Viruch Hemapanpairo 2015-12-09 13:24:17 UTC
Besides of cannot flip some .PNG images, the LibreOffice 5.1.0 beta2+ (Build ID: d3ea3162f8bd491995103ae3f89a23da71365509) cannot export the document contained .PNG image with transparent background to PDF.
Comment 17 V Stuart Foote 2015-12-09 13:48:24 UTC
@Viruch,

(In reply to Viruch Hemapanpairo from comment #16)
> Besides of cannot flip some .PNG images, the LibreOffice 5.1.0 beta2+ (Build
> ID: d3ea3162f8bd491995103ae3f89a23da71365509) cannot export the document
> contained .PNG image with transparent background to PDF.

That needs to be reported as a New issue, please write it up as a new Bugzilla report with specific steps to reproduce (as detailed as in comment 10 above). And a description of what you mean by "cannot export", i.e. the PDF is not created, it crashes, the PNG is just missing, etc.
Comment 18 Viruch Hemapanpairo 2015-12-17 09:24:39 UTC
Testing the 3 newly built versions:

Version: 5.0.5.0.0+
Build ID: 58c8f4dc6c7d6897e36c0c754162035f70e3385f
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-5-0, Time: 2015-12-16_07:06:49
Locale: en-US (en_US.UTF-8)

Version: 5.1.0.1.0+
Build ID: 3b31d0dc86d75f8283951f3fd6a4f48ff649ed99
Threads 4; Ver: Linux 3.13; Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:libreoffice-5-1, Time: 2015-12-16_10:55:13
Locale: en-US (en_US.UTF-8)

Version: 5.2.0.0.alpha0+
Build ID: 0db3361527f799be6cadf5bedb8a37976fb0a39d
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2015-12-16_11:47:30
Locale: en-US (en_US.UTF-8)

These all version produce the same problem of flipping image. While the stable version (Version: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: en_US.UTF-8) can produce a perfect result.
Comment 19 pasqual milvaques 2016-04-07 11:27:01 UTC
Please, retest the issue with the latest daily build. In my testing the latest fix added for bug 90319 has solved the issue

Thanks
Comment 20 Viruch Hemapanpairo 2016-04-07 18:57:50 UTC
Already tested

The problem is still UNSOLVED in :
Version: 5.1.3.0.0+
Build ID: 24635317f09ecf48e5d800147b6a2b95963b69a7
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:libreoffice-5-1, Time: 2016-04-07_07:12:40
Locale: en-US (en_US.UTF-8)

The problem is already SOLVED in :
Version: 5.2.0.0.alpha0+
Build ID: 641840dc0f63d23acceb7edd833f4a31f216009d
CPU Threads: 4; OS Version: Linux 3.13; UI Render: default; 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-04-07_00:27:01
Locale: en-US (en_US.UTF-8)

Thanks
Viruch
Comment 21 Viruch Hemapanpairo 2016-04-07 19:07:00 UTC
Also the problem still UNSOLVED in 
Version: 5.0.6.0.0+
Build ID: f25eca3f230c170b46d7ce9f40842161a50b1883
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-5-0, Time: 2016-04-04_08:22:20
Locale: en-US (en_US.UTF-8)
Comment 22 Joel Madero 2016-04-07 19:10:19 UTC
It's solved then. The commit is in 5.2. Closing as fixed.

We may or may not backport the commit depending on if it conflicts, how intrusive it is to the code, etc....
Comment 23 pasqual milvaques 2016-04-08 16:43:13 UTC
A merge request for 5.1 has been solicited in https://gerrit.libreoffice.org/#/c/23852/ 

For 5.0 I have not solicited any as it's almost eol but, if is considered to  interesting anybody can make a cherry pick for 5.0

The code to solve this is quite simple

Thanks :)
Comment 24 Jean-Baptiste Faure 2016-04-24 16:09:49 UTC
Version set from comment #15.

Best regards. JBF