Bug 93693 - Browsing firefox themes by clicking category name no longer works
Summary: Browsing firefox themes by clicking category name no longer works
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2015-08-27 00:43 UTC by Yousuf Philips (jay) (retired)
Modified: 2016-05-11 15:21 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-08-27 00:43:54 UTC
Steps:
1) Open Tools > Options > Personalization
2) Click select theme button
3) Click a category

Regression as this works in 4.4 daily.

Version: 5.1.0.0.alpha1+
Build ID: b712b1f63492a311e4a51cffd516b3e202a140e6
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2015-08-23_06:03:52
Locale: en-US (en_US.UTF-8)
Comment 1 Buovjaga 2015-09-12 14:25:47 UTC
Repro.

Win 7 Pro 64-bit, Version: 5.0.1.2 (32-bit)
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: fi-FI (fi_FI)
Comment 2 raal 2015-12-08 06:57:00 UTC
This seems to have begun at the below commit.
Adding Cc: to Tomaž Vajngerl ; Could you possibly take a look at this one?
Thanks

There are only 'skip'ped commits left to test.
The first bad commit could be any of: f94c3dc930c090202b42cdae47e184331f087643 0d3becec432f8a91e4bef7deb4273ccb7f7d00f3
We cannot bisect more!


author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2015-04-29 02:49:47 (GMT)
committer	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2015-04-29 02:53:11 (GMT)
commit 969d833e7927f099de35b87d225a9e9dd9f08661 (patch)
Also add RenderContext parameter to updatecheckui

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2015-04-28 03:53:27 (GMT)
committer	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2015-04-29 00:24:20 (GMT)
commit 9905a8b953953b9ec5e123a17997d5931978acfe (patch)
replace Paint calls to Invalidate + fix compilation

/bibisect-win32-5.0
$ git bisect log
# bad: [575cd25f0560684895018d8fcfb1818dd4dd1c9b] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65
# good: [f449493ae11ac76cc7396bddeaa624a60c565936] source 57d6b92b69a31260dea0d84fcd1fc5866ada7adb
git bisect start 'libreoffice-5-0-branch-point' 'oldest'
# good: [da12357c491a0dce5acc0bd1f00c26f89d8f20e6] source c1b9402d49a7cd4bec383f28d397d9d89541f0e0
git bisect good da12357c491a0dce5acc0bd1f00c26f89d8f20e6
# good: [2783cac5d1f18f44ce31f52eb7ae2f0ea17d0c96] source 5d7a203bdae1940e4846c4c42f5d733e4ffa4160
git bisect good 2783cac5d1f18f44ce31f52eb7ae2f0ea17d0c96
# bad: [c6b55917df3df447007dbb29dd84f24d1203cfb3] source 5b8acf459e4a6728ea656e7abd5dfb08ad2ae345
git bisect bad c6b55917df3df447007dbb29dd84f24d1203cfb3
# good: [f3cd4f9fed8d6054c5112732a412cce67ac90ce1] source 0bdb8eda1272596301391d9620ccec2866642975
git bisect good f3cd4f9fed8d6054c5112732a412cce67ac90ce1
# good: [9c89ac023456f41259dca96ecbee34d9c41dc11b] source a390d178b0440f5ecc151427c9d05f52c54e8c45
git bisect good 9c89ac023456f41259dca96ecbee34d9c41dc11b
# good: [feaf5ecccd61a411c22c709cfc9e05e800a13679] source 433fb8c055ff93a9bb3567310d2dda6bbcc9d635
git bisect good feaf5ecccd61a411c22c709cfc9e05e800a13679
# bad: [9a231ed536024baadca8536923889128758c703b] source 0cd88d27ecd87c8c5791418bcac6ab1684ece74a
git bisect bad 9a231ed536024baadca8536923889128758c703b
# bad: [8857b2e421310c1f3fa01d54226dc933ee8d73b8] source 1ebffd4011b7e6ccf9f3eafdc7a88aa4bc77fd4f
git bisect bad 8857b2e421310c1f3fa01d54226dc933ee8d73b8
# good: [194df729cec157dd9eac68c9cd95e3b6474a04e1] source d798ee8f82dcbdada49ef0c745ff234d936bb3f6
git bisect good 194df729cec157dd9eac68c9cd95e3b6474a04e1
# skip: [f94c3dc930c090202b42cdae47e184331f087643] source 9905a8b953953b9ec5e123a17997d5931978acfe
git bisect skip f94c3dc930c090202b42cdae47e184331f087643
# bad: [0d3becec432f8a91e4bef7deb4273ccb7f7d00f3] source 969d833e7927f099de35b87d225a9e9dd9f08661
git bisect bad 0d3becec432f8a91e4bef7deb4273ccb7f7d00f3
# good: [65d31ab28dcfc50043508d7b795b8868a5cd2042] source d3ba96e37ec4681b9b7cb1ffac5e34060e47a4ee
git bisect good 65d31ab28dcfc50043508d7b795b8868a5cd2042
# good: [959e021ca4b6d38d286c75527c182738e4b98db7] source d36da8c19378f4772c896ca4df94117077e823d6
git bisect good 959e021ca4b6d38d286c75527c182738e4b98db7
# only skipped commits left to test
# possible first bad commit: [0d3becec432f8a91e4bef7deb4273ccb7f7d00f3] source 969d833e7927f099de35b87d225a9e9dd9f08661
# possible first bad commit: [f94c3dc930c090202b42cdae47e184331f087643] source 9905a8b953953b9ec5e123a17997d5931978acfe
Comment 3 Robinson Tryon (qubit) 2015-12-13 11:13:17 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]
Comment 4 Katarina Behrens (Inactive) 2016-05-11 14:16:06 UTC
It works now ... got fixed along w/ bug 88502. 

I'm not sure what the appropriate resolution now is, Fixed? Duplicate? (strictly speaking this isn't a duplicate, the issue here is different)
Comment 5 Buovjaga 2016-05-11 15:21:06 UTC
(In reply to Katarina Behrens (CIB) from comment #4)
> It works now ... got fixed along w/ bug 88502. 
> 
> I'm not sure what the appropriate resolution now is, Fixed? Duplicate?
> (strictly speaking this isn't a duplicate, the issue here is different)

Let's set to FIXED and mention commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f22f287b4ae80c5879f87071be93c3ea5d1001c