Bug Hunting Session
Bug 95569 - ODT export: conflicting style:repeat attributes on two XML elements
Summary: ODT export: conflicting style:repeat attributes on two XML elements
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.3.2 release
Hardware: Other All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:5.0.4
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-04 14:16 UTC by Miklos Vajna
Modified: 2015-11-04 14:29 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miklos Vajna 2015-11-04 14:16:37 UTC
With the latest libreoffice-5-0 branch:

1) Start Writer.
2) Format -> page -> area -> fill -> bitmap
3) Select e.g. sky
4) Uncheck "tile"
5) Uncheck "autofit", OK to close the dialog
6) Save as ODF

styles.xml of the resulting .odt file has:

      <style:page-layout-properties ... style:repeat="no-repeat">
        <style:background-image ... style:repeat="stretch"/>
      </style:page-layout-properties>

It's a task for the importer to decide in this case which one has priority, but we should not produce such output ourselves.
Comment 1 Commit Notification 2015-11-04 14:29:25 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-5-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=70ef5655d73cc486b93ed5792e5384696bd476fe&h=libreoffice-5-0

tdf#95569 xmloff: convert legacy assertions in PageMasterExportPropMapper

It will be available in 5.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Miklos Vajna 2015-11-04 14:29:45 UTC
Master is not affected, the cleanup commit 18a712d2b3fe03629e00868ce17226994b7b7252 fixes this as a side-effect, setting both XML attributes to style:repeat="no-repeat" as expected.

It's now cherry-picked to libreoffice-5-0, marking as resolved.