Bug Hunting Session
Bug 95854 - Insert comment shortcut doesn't let me edit existing comment
Summary: Insert comment shortcut doesn't let me edit existing comment
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.0.2.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
: 97738 103084 (view as bug list)
Depends on:
Blocks: UNO-Command-New Shortcuts-Accelerators Calc-Comments
  Show dependency treegraph
 
Reported: 2015-11-16 12:26 UTC by web_libreoffice
Modified: 2019-05-30 13:48 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description web_libreoffice 2015-11-16 12:26:44 UTC
"Insert comment" in previous versions either created comment in cell, or entered edit mode for existing comment. Now this is no longer the case - "Insert comment" only inserts new one, and to edit existing comment, I have to use "Edit comment" from mouse-context menu.

The problem is that "Edit comment" is not available anywhere as keyboard shortcut, and having to use different thing for inserting new comment, or editing existing one is problematic.
Comment 1 Buovjaga 2015-11-16 18:17:24 UTC
But you can create your own keyboard shortcut.

Tools - Customize - Keyboard - Functions category: Insert. Select "Edit comment", select some shortcut in the top list and click Modify to associate Edit comment with it.

Is this enough for you?

Set to NEEDINFO.
Change back to UNCONFIRMED, if it's not enough. Change to RESOLVED WORKSFORME, if you think it's ok.
Comment 2 web_libreoffice 2015-11-16 19:42:15 UTC
There is no "Edit comment" in there. Functions are ... "Define Name", and immediately after: "Floating Frame". Nothing starting with E.
Comment 3 web_libreoffice 2015-11-16 19:43:01 UTC
Also, "But you can create your own keyboard shortcut." - besides the point that I can't, why did we lose the ability to have *single* keyboard combination/functionality that lets me insert comment or edit existing one?
Comment 4 Buovjaga 2015-11-16 20:07:07 UTC
Whoops, sorry, I was looking at 5.1 for some reason.
You are right that it can't be defined in 5.0, strange.

For your question in comment 3, we have to ask UX.
Comment 5 Jean-Baptiste Faure 2016-01-09 17:45:46 UTC
(In reply to web_libreoffice from comment #3)
> Also, "But you can create your own keyboard shortcut." - besides the point
> that I can't, why did we lose the ability to have *single* keyboard
> combination/functionality that lets me insert comment or edit existing one?

Indeed. For me the removal of this ability is a bug or a design error, because you can't create a second comment if there is already one. So if a comment exists, the only actions you can take is edit or remove the comment. As it is not always obvious that a comment has already been defined, it is a good idea to have the same shortcut to create and edit a comment.

Setting status to NEW even if the possibility to create a shortcut for the edit comment exists in version 5.1. I think the bug should be fixed for the 5.0 branch. It is an accessibility problem too because it is not possible to edit a comment without the mouse.

In the case of 5.1 and next, a shortcut for the edit comment command should be defined by default. For example ctrl+shift+C but it would be better if we had the same shortcut to edit and create a comment.
The mnemonics to create and edit a comment are the same: right click + M (shift+F10+M).

Best regards. JBF
Comment 6 Robinson Tryon (qubit) 2016-08-25 05:39:06 UTC Comment hidden (obsolete)
Comment 7 Buovjaga 2016-11-29 18:31:17 UTC
*** Bug 97738 has been marked as a duplicate of this bug. ***
Comment 8 Buovjaga 2016-11-29 18:31:25 UTC
*** Bug 103084 has been marked as a duplicate of this bug. ***
Comment 9 Yousuf Philips (jay) (retired) 2016-11-30 22:42:42 UTC
The same shortcut should work for both inserting and editing comments, as it used to in 4.4 and below, and as it does in writer, so users dont have to learn a new shortcut.

https://gerrit.libreoffice.org/#/c/31449/
Comment 10 Xisco Faulí 2017-09-11 08:32:56 UTC
Dear developer,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 11 QA Administrators 2018-09-12 02:38:14 UTC Comment hidden (obsolete)
Comment 12 Stanislav Horacek 2018-09-12 21:11:54 UTC
It is still not possible to use the same command for inserting and editing comments.

Tested in master:
Version: 6.2.0.0.alpha0+
Build ID: c4fb70d1f70209e31936b9c488a044087f11c303