Bug 96939 - LOK: Add documentLoadWithOptionsPassword function to set Password when loading documents
Summary: LOK: Add documentLoadWithOptionsPassword function to set Password when loadin...
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: contrib (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 06:11 UTC by Zhang Jingqiang
Modified: 2017-03-28 08:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
The Patch, not compile-tested (4.55 KB, text/x-chdr)
2016-01-07 06:11 UTC, Zhang Jingqiang
Details
Patch refreshed for the master branch (5.85 KB, patch)
2016-01-07 09:51 UTC, Zhang Jingqiang
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zhang Jingqiang 2016-01-07 06:11:15 UTC
Created attachment 121761 [details]
The Patch, not compile-tested

It's not convenience when open encrypted files with LOK documentLoad functions.
So I add another function documentLoadWithOptionsPassword to support the Password param.

There's some problem with this patch.
1. It will break the ABI if user didn't define LOK_USE_UNSTABLE_API.
2. I haven't compiled it yet.
3. I'm still cloning the git repo, and this patch is just for discussion purpose, I will submit the final one if it could be accepted. Anyone can modify and still it.

Thanks.
Comment 1 Zhang Jingqiang 2016-01-07 09:51:54 UTC
Created attachment 121770 [details]
Patch refreshed for the master branch
Comment 2 Buovjaga 2016-01-10 19:25:30 UTC
Please submit your patch to gerrit and reference tdf#96939
https://wiki.documentfoundation.org/Development/gerrit
Comment 3 Aron Budea 2016-08-10 00:28:02 UTC
Just curious, are you still considering submitting your patch?

If you are, and require preliminary feedback, I'd suggest submitting your suggestion to the list: https://lists.freedesktop.org/mailman/listinfo/libreoffice
(developers read that list, while there's a lower chance they'd stumble upon this bug report)
Of course you can also just submit the changes to gerrit as described on the wiki page Buovjaga linked, and definitely get feedback that way.
Comment 4 QA Administrators 2017-03-01 10:41:11 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2017-03-28 08:13:10 UTC
Dear Bug Submitter,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-20170328