Created attachment 121913 [details] Proposed icons The new commands .unoInsertRowsAfter, .uno:InsertRowsBefore, .uno:InsertColumsAfter, .unoInsertColumnsBefore have no own icons in theme Galaxy. Therefore you can only distinguish one from another, when read the tooltip. I suggest new icons for them. I have kept the + as insert indication as it is usual for Galaxy. I have moved the green line to indicate where the row/column is inserted. Another idea would be to keep the position of the green line, but move the + to the place where the row/column is inserted. I do not have tried that yet, but it is unusual to have the + not top/left. What do you thing about my icons?
Created attachment 121938 [details] Version with shifted + And here is a version were the + indicates, where to insert the new row/column.
Created attachment 121941 [details] Tango uses unique
Created attachment 121942 [details] Breeze also uses unique
Created attachment 121943 [details] Galaxy (and Sifr) reuse icons, so dependent on tool tip Agree, it would be good to add several new icons to Galaxy. Unfortunately, I don't think relocating the "plus" on the icon makes it more readable in Galaxy. Even the "Breeze" use of "plus" is a little unreadable compared to the Tango triangle pointers.
For Sifr the new icons are already in core. They have a little triangle outside to indicate, where the row/column is inserted. Only the file 'links.txt' is not yet adapted n Sifr.
Created attachment 122161 [details] Version with little triangles and without cross
I think the first set seems fine, ideally without the plus sign, as most insert functions dont have it and the green columns and rows already emphasis the insert.
Created attachment 122303 [details] Three variants without plus Please look again. I have made versions without plus. I think using the original gradient does not give enough contrast. I would prefer those from "DarkWithMarkers". You can distinguish the small icons for insert rows best in that version. If you do not like markers, then those from "DarkWithoutMarkers" are clearer than from "Gradient". Please look at the icons with a small device like a netbook too. All three versions follow the idea, to indicate the insert position by the position of the green line.
I think DarkWithoutMarkers is the best of the three. Just a heads up Regina, noone is working on Galaxy anymore, so more and more icons will be missing from it as time goes by.
As long as Galaxy is used as fallback, it should contain all needed icons.
Regina Henschel committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a6238f8222714465fe7a11477706ad19a1b3bebb tdf#97116 Icons for theme Galaxy for new commands insertbefore and insertafter It will be available in 5.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Just a reminder to backport this also into 5.1. ;D
Regina Henschel committed a patch related to this issue. It has been pushed to "libreoffice-5-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=17336c2aec3946144026dac509917acb6846e1c8&h=libreoffice-5-1 tdf#97116 Icons for theme Galaxy for new commands insertbefore and insertafter It will be available in 5.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.