Bug 97367 - Editing white text has a white background fill (unseen in PDF and in slideshow)
Summary: Editing white text has a white background fill (unseen in PDF and in slideshow)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: ImpressDraw-Styles
  Show dependency tree / graph
 
Reported: 2016-01-25 20:20 UTC by szotsaki
Modified: 2022-02-10 11:08 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
White title texts with white rectangles in front of them (18.65 KB, application/vnd.oasis.opendocument.presentation)
2016-01-25 20:20 UTC, szotsaki 		Details
Example screenshot (34.72 KB, image/png)
2016-01-25 20:23 UTC, szotsaki 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description szotsaki 2016-01-25 20:20:02 UTC 
Created attachment 122203 [details]
White title texts with white rectangles in front of them

Test 1 and Test 2 titles has a white "filling" rectangle in front of the text. This disappears when you export the document as PDF or press F5.

If I'm not mistaken, some versions ago this document was exported from Google Drive as an OOXML and then converted to ODF.

I'm on openSUSE x64 and KDE 5.
Comment 1 szotsaki 2016-01-25 20:23:24 UTC 
Created attachment 122204 [details]
Example screenshot
Comment 2 Buovjaga 2016-01-28 17:04:26 UTC 
Confirmed.

Would be cool to get the original OOXML.

Works ok in 4.3.

Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+
Build ID: 259c1ed201f4277d74dfd600fed8c837cbf56abc
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-01-27_00:45:12
Locale: fi-FI (fi_FI)

4.3.0.1
Comment 3 raal 2016-01-29 12:53:43 UTC 
Reproducible with Version: 4.5.0.0.alpha0+
Comment 4 raal 2016-01-29 14:52:06 UTC 
This seems to have begun at the below commit.
Adding Cc: to Kohei Yoshida ; Could you possibly take a look at this one?
Thanks
 d09c5defb702f63eabd460d81f2e9434866f3b24 is the first bad commit
commit d09c5defb702f63eabd460d81f2e9434866f3b24
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Mar 14 23:38:09 2015 +0800

    source-hash-0f47de0cff673d298af63926e15e3dff40ee80db
    
    commit 0f47de0cff673d298af63926e15e3dff40ee80db
    Author:     Kohei Yoshida <kohei.yoshida@collabora.com>
    AuthorDate: Tue Jul 22 15:25:27 2014 -0400
    Commit:     Kohei Yoshida <kohei.yoshida@collabora.com>
    CommitDate: Tue Jul 22 15:26:14 2014 -0400
    
        Fix the font handling esp wrt font colors.
    
        Change-Id: I7dda03368f67ea6a12dfb39115f4546277abb76b
Comment 5 Xisco Faulí 2017-09-29 08:53:03 UTC Comment hidden (obsolete)
Comment 6 szotsaki 2018-03-07 18:06:07 UTC 
Reproducible with 
Version: 6.0.2.1
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
Locale: hu-HU (hu_HU); Calc: CL
Comment 7 QA Administrators 2019-03-08 03:40:21 UTC Comment hidden (obsolete)
Comment 8 Roman Kuznetsov 2019-03-30 20:10:09 UTC 
still repro with file from attach in

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 5cb2db6dd7d234a610a6501668a9901af8472b7f
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-26_23:06:31
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

but white font on white background is in PDF and in presentation mode (F5) too.

For me it's just wrong formatting of title now and can be easy fix.
Comment 9 QA Administrators 2021-03-30 03:40:02 UTC Comment hidden (obsolete, spam)
Comment 10 Justin L 2022-02-10 11:08:49 UTC 
(In reply to Roman Kuznetsov from comment #8)
> but white font on white background is in PDF and in presentation mode (F5)
I suggest that means this bug is fixed. The master page specifies a white highlight colour for the Title, and direct formatting says nothing about highlight.

The master page draw:master-page-name="Title_20_Slide" uses  draw:text-style-name="MP5".

<style:style style:name="MP5" style:family="paragraph"> contains
  <loext:graphic-properties draw:fill="solid" draw:fill-color="#ffffff"/>

Test1 and Test2 are using 
<text:p text:style-name="P1">
  <text:span text:style-name="T1">Test1</text:span>
</text:p>

where P1 says nothing about the fill, and thus the master page props apply.
<style:style style:name="P1" style:family="paragraph">
  <style:paragraph-properties fo:margin-left="0cm" fo:margin-right="0cm"
   fo:margin-top="0cm" fo:margin-bottom="0cm" fo:line-height="100%"
   fo:text-align="center" fo:text-indent="0cm" style:writing-mode="lr-tb"/>
</style:style>