Bug 97555 - unsuitable colour feedback when selecting multiple sheet in calc
Summary: unsuitable colour feedback when selecting multiple sheet in calc
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
(earliest affected)
Hardware: All All
: medium enhancement
Assignee: Not Assigned
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
: 125729 (view as bug list)
Depends on:
Blocks: Calc-UX Sheet-Tabs-Bar
  Show dependency treegraph
Reported: 2016-02-04 10:32 UTC by riccardo.arzenton
Modified: 2019-08-29 21:59 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:

printscreen from windows (3.20 KB, image/png)
2016-02-08 07:45 UTC, raal
how it looks for me (4.42 KB, image/png)
2016-02-24 18:16 UTC, Yousuf Philips (jay) (retired)
Simulated proposed solution (2.56 KB, image/png)
2018-11-21 10:24 UTC, Heiko Tietze

Note You need to log in before you can comment on or make changes to this bug.
Description riccardo.arzenton 2016-02-04 10:32:59 UTC
In LibreOffice Calc when you ctrl+click multiple sheet for a multi select (in example if you want to delete multiple sheet at the same time) there's a unsuitable colour change. It pass from a very light gray to a nearly-white. In practice it is a not-noticeable difference.  

I think it's a better choice to mark them in a different way, maybe with a bold frame or something like this.
Comment 1 raal 2016-02-06 20:37:18 UTC
UX Team -- please take a look at this enhancement. Thanks!
Comment 2 Adolfo Jayme Barrientos 2016-02-07 22:12:11 UTC
What OS are you on? Here on Ubuntu’s default UI theme, contrast is enough.

I would suggest drawing the selected tabs with the bottom-right corner “folded”, since drawing an underline is out of the question (we already underline colored but active tabs) and a bold frame would look ugly (IMHO, its harsh color already makes it stand out too much without doubling its width… Still, I don’t rule out this option). Anyway, let’s throw out more ideas, folks!
Comment 3 raal 2016-02-08 07:45:40 UTC
Created attachment 122430 [details]
printscreen from windows
Comment 4 riccardo.arzenton 2016-02-08 08:10:58 UTC
I really like the idea of a black corner folded.
Comment 5 Yousuf Philips (jay) (retired) 2016-02-24 18:16:41 UTC
Created attachment 122962 [details]
how it looks for me

Screenshot of how it looks for me, but it should be easy to see which ones arent selected (gray) from the ones that are selected (white), though it would be better if it had a different color for the selection than white.
Comment 6 Robinson Tryon (qubit) 2016-08-25 05:49:34 UTC Comment hidden (obsolete)
Comment 7 Heiko Tietze 2018-11-21 10:24:27 UTC
Created attachment 146859 [details]
Simulated proposed solution

We should use the system color for selection (usually blue). Since tabs can have any color it's not an ultimate approach. However, the selection of colored tabs is done with just a small bar where the full tab is reverted to light gray, and I think that's the best compromise. Any icon/mark/corner is IMHO misleading.

So suggestion is to draw a small bar at the tab bottom when selected (and also for the currently visible tab).

Could be an easyhack.
Comment 8 Eike Rathke 2019-01-24 22:49:36 UTC
AFAIK the colors in the render context are the same as the window settings, unselected tabs are in window border color, unless the tab has a custom color assigned, and the background color is used as selected tab color. This IMHO is even consistent with style guides. Using the (text or cell) selection color there is not expected. Drawing a bottom bar same as for colored tabs but in the unselected tab color probably is the better solution, though that still would look odd to me.

However, implementation is in svtools/source/control/tabbar.cxx class TabDrawer drawColorLine() called from drawTab() if (mbCustomColored && mbSelected), that could be adapted to drawColorLine() with maUnselectedColor for not mbCustomColored.
Comment 9 Eike Rathke 2019-01-24 23:07:03 UTC
Caveat, that TabBar is used also in other places, Draw, Base and Basic IDE (git grep svtools/tabbar.hxx). I doubt we want the same behaviour in all places, specifically not if they do not allow multiple selection.
Comment 10 Cor Nouws 2019-04-24 13:10:31 UTC
The current situation is not ideal. However I see no proposal that doesn't introduce a (different) problem. In this situation, I would touch it.
Comment 11 Cor Nouws 2019-04-25 12:43:38 UTC
(In reply to raal from comment #3)
> Created attachment 122430 [details]
> printscreen from windows
Looks more then clear enough for me.
Comment 12 Heiko Tietze 2019-07-12 11:43:10 UTC
*** Bug 125729 has been marked as a duplicate of this bug. ***
Comment 13 Thomas Lendo 2019-08-29 21:59:11 UTC
It seems this was fixed also with fixing of Bug 124572 - tabs in calc (for sheets) and draw (for layer) style.

When selecting different sheet tabs in Calc, the new highlighting looks fine and visually clear.

Therefore I change the status of this bug to WORKSFORME.

Tested with Version:
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: de-AT (de_AT.UTF-8); UI-Language: en-US