Bug 97663 - SVG <tspan> line spacing not correct
Summary: SVG <tspan> line spacing not correct
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.0.2
Keywords: bibisected, bisected, filter:svg, regression
Depends on:
Blocks: SVG-Import
  Show dependency treegraph
 
Reported: 2016-02-08 21:08 UTC by Yousuf Philips (jay) (retired)
Modified: 2022-01-26 11:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (58.75 KB, image/png)
2016-02-08 21:08 UTC, Yousuf Philips (jay) (retired)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2016-02-08 21:08:12 UTC
Created attachment 122462 [details]
screenshot

Steps:
1) Open Writer
2) Insert https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/ny1.svg
3) Notice the spacing between text lines is to large which causes some text to touch or overlap.

Regression as this doesnt happen in 5.1.

Version: 5.1.1.0.0+
Build ID: d6c5a8103b103b80ef171c09ca593e68ae867189
CPU Threads: 2; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:libreoffice-5-1, Time: 2016-01-19_14:22:06
Locale: en-US (en_US.UTF-8)

Version: 5.2.0.0.alpha0+
Build ID: 6d68e88a0fc5a54bbb826379163bd0b9c6eae0fb
CPU Threads: 2; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2016-02-08_08:05:38
Locale: en-US (en_US.UTF-8)
Comment 1 Jacques Guilleron 2016-02-09 15:44:48 UTC
Hi Yousouf,

Reproduced with 
LO 5.2.0.0.alpha0+ Build ID: 76ec54e8c9f3580450bca85236a4f5af0c328588
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-02-09_00:10:35
Locale: en-US (fr_FR)
& Windows 7 Home.
Not reproduced with
LO 5.1.0.3 (x64) Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737
CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; 
Locale : fr-FR (fr_FR)
Comment 2 raal 2016-02-16 14:29:01 UTC
This seems to have begun at the below commit.
Adding Cc: to Xisco Fauli; Could you possibly take a look at this one? Thanks
 1f03d1c9a42a7b0df855f73e55aef2774cf330f8 is the first bad commit
commit 1f03d1c9a42a7b0df855f73e55aef2774cf330f8
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Thu Feb 4 23:01:26 2016 -0800

    source 701324a1e1f7e0c181ff1a50956ced686785ea53

    source 701324a1e1f7e0c181ff1a50956ced686785ea53

:040000 040000 38b092e71dfed5c39cef8046c5b4e73301c53519 de619b848cf45673db5be53de4ae032e0d994e5c M instdir

author	Xisco Fauli <anistenis@gmail.com>	2016-01-26 00:29:22 (GMT)
committer	Noel Grandin <noelgrandin@gmail.com>	2016-01-28 06:47:47 (GMT)
commit 701324a1e1f7e0c181ff1a50956ced686785ea53 (patch)
tree 4b0d053279cd5c4a393df80b1d5d953cedf3997f
parent c06238f28209402a9cbcc2471dd713de0db0fb4b (diff)
SVGIO: tdf#45771: Fix issue when text size is twice its size...
Comment 3 Xisco Faulí 2016-02-16 14:38:10 UTC
Hi raal, thanks for bibisecting. I'll take a look...
Comment 4 Xisco Faulí 2017-09-29 08:51:53 UTC Comment hidden (obsolete)
Comment 5 Roman Kuznetsov 2018-06-20 12:41:39 UTC
still repro in LibreOffice 6.1 beta 2
Comment 6 QA Administrators 2019-06-21 02:54:03 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2021-06-21 03:38:45 UTC Comment hidden (obsolete)
Comment 8 Hossein 2021-12-19 16:26:11 UTC
Still reproducible in 7.2 and 7.4 master.

LibreOffice 7.2.0.4:

Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

LibreOffice 7.4 master:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 7620833fb4c48b9f981c81ea1ae72102c680f1a5
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 9 Commit Notification 2021-12-24 01:01:00 UTC
Hossein committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4e2e57b530544736804ab663f832173ba1d78559

tdf#97663 SVGIO: Fix line spacing for <tspan>

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-12-24 18:36:25 UTC
Hossein committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/8e1aea537ffe35311cc6d43d4b0cef3f4ec82367

tdf#97663 SVGIO: Fix line spacing for <tspan>

It will be available in 7.3.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2022-01-10 09:33:33 UTC
Hi Hossein,
Should this issue be closed as RESOLVED FIXED ?
Comment 12 Hossein 2022-01-26 11:38:33 UTC
(In reply to Xisco Faulí from comment #11)
> Hi Hossein,
> Should this issue be closed as RESOLVED FIXED ?
Yes. This is fixed now.