Created attachment 124125 [details]
The LibreOffice UI while having switched on high-contrast-mode/theming
I started LibreOffice, not one of its applications, on my system with configured high-contrast-mode and chosen high-contrast-#1 theme (yellow text, black background).
The screenshot shows, that the UI ignores high-contrast accessibility in general.
The menu and its dialogs behave acceptable.
Created attachment 124126 [details]
A detail hovering the mouse over a listed item on the left of the LibreOffice UI in high-cotnrast-mode/theming
→ NEW; updating summary for clarity.
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/
2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword
Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa
Thank you for helping us make LibreOffice even better for everyone!
Created attachment 137454 [details]
Screenshot of rendering in high-contrast mode of the start center (LibreOffce 220.127.116.11)
Created attachment 137455 [details]
Colors used for "responsive" design in the start center (LibreOffcie 18.104.22.168) in high-contrast-mode
I tested with LibreOffice version 22.214.171.124 and found still the same rendering issues in high-contrast-mode.
1. Menu bar is black on black and hovering color has insufficient contrast
2. Hovering color over menu items or entries in the left side bar has insufficient contrast
3. The start center uses a light background instead of the system window color (GetSysColor(COLOR_WINDOW)), the default high-contrast-window color.
BTW testing in high-contrast on Windows is not that difficult. The hotkey LeftAlt+LeftShift+PrintScr is normally enabled and toggles the high-contrast-mode with its default or last used high-contrast theme/design.
Created attachment 137456 [details]
Screenshot of hovering color used in the menu bar and menu items in high-contrast-mode (LibreOffice 126.96.36.199)
*** Bug 129725 has been marked as a duplicate of this bug. ***
Code pointer in bug 129725 comment 6; see also bug 129725 comment 15
Please check again with a nightly build (should be available tomorrow). Custom colors have been dropped from the start center, see bug 136555.
(In reply to Heiko Tietze from comment #11)
Either using a dark theme or not using any theme at all - the start center window is still light-colored-looking (master~2020-10-11_00.12.38_LibreOfficeDev_188.8.131.52.alpha0_Win_x86).
Created attachment 166270 [details]
current 20201011 master against 7.1.0 - Win10 HC#1 highcontrast mode
Windows 10 WDM does not adequately pass theme details that LO can apply. And LO does not read the UWP theming overlaid on the WDM. So Windows 10 (or earlier Win7, Win8.1) does pass in an os/DE flag for 'HighContrast' set triggering the switch to Sifr icons and a read of what limited 'theme' details win32s passes.
IIUC getting this accessibility issue corrected on Windows will require the native code work needed for bug 118320
We used to have the StartCenterBackgroundColor and StartCenterTextColor  implemented for consistent SC UI--i.e. "Branding".
But that was recently stripped out for bug 136555  for "better" os/DE theming support, which of course doesn't work for Windows, and not sure if the macOS builds do better.
 for bug 90452 https://gerrit.libreoffice.org/c/core/+/16622/
 for bug 136555 https://gerrit.libreoffice.org/c/core/+/103041
Created attachment 166271 [details]
current 20201011 master against 7.1.0 - Win10 HC#2 highcontrast mode
(In reply to V Stuart Foote from comment #13)
So are there any chances for LO to gain completely dark-themed start center? So far I’ve been using what now You’ve showed that it has been dropped :( . Although it was still a partial solution.
Vision-wise, I have trouble looking at anything which is light-colored. Therefore it was a big positive surprise when I’ve discovered that I can make documents displayed on a complete dark GUI (including color of a page, which does not influence the color on the print). Those same documents, however, are still displayed within the start center in a form of a final printing version, meaning: white pages. I am therefore wondering if this also would be possible to be included: for the start center to display dark documents, regardless of their colors for print.
But this is a little digression, the main thing remains a complete dark theme for the start center window.
(In reply to V Stuart Foote from comment #13)
> Created attachment 166270 [details]
> current 20201011 master against 7.1.0 - Win10 HC#1 highcontrast mode
This looks the same (AKA broken highcontrast) in the build before the patch was merged. Feel free to revert that patch, if you make the setting optional. Just start Writer on Windows, which looks even more broken in multiple ways, because most backgrounds in the toolbars aren't dark. Also the menu text is green, while it's white in notepad. There is simply much more to fix, but mapping the right colors to LO's theming is generally not rocket science (but probably guesswork, because of the huge amount of theming colors in LO, needed or not).
> We used to have the StartCenterBackgroundColor and StartCenterTextColor 
> implemented for consistent SC UI--i.e. "Branding".
> But that was recently stripped out for bug 136555  for "better" os/DE
> theming support, which of course doesn't work for Windows, and not sure if
> the macOS builds do better.
The patch was also a reaction to MacOS based changes, and that author was in the loop. So I guess they are tested on MacOS too.
The start center now uses the colors from the theme for the button area, which uses GetWorkspaceColor, which is supposed to use GetSysColor(COLOR_MENU), but just if officecfg::Office::Common::Accessibility::AutoDetectSystemHC::get(), for whatever reason, instead of always setting it from the theme.
FWIW you can still set the background image for some "branding" of the start center.
(In reply to Jan-Marek Glogowski from comment #16)
> The patch was also a reaction to MacOS based changes, and that author was in
> the loop. So I guess they are tested on MacOS too.
On macOS there is neither a high-contrast mode nor a dark mode. The latter is caused by an incompartibility of current macOS SDKs (not by colors). There are currently no problems with coloring related to Startcenter on macOS.
To me it seems that only menu is wrong, start center is fine.
Start center seems generally working with Win10 high contrast.
Only wrong I see is Recent Documents, which gets green backround and not system one and Templates, which gets grey backround and not the one from system's Selected text color.