Bug 99176 - core/include/basegfx/range/b2dconnectedranges.hxx:200]: (style) Redundant condition
Summary: core/include/basegfx/range/b2dconnectedranges.hxx:200]: (style) Redundant con...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium minor
Assignee: Julien Nabet
URL:
Whiteboard: target:5.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-09 08:35 UTC by dcb314
Modified: 2016-10-25 19:08 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2016-04-09 08:35:19 UTC
core/include/basegfx/range/b2dconnectedranges.hxx:200]: (style) Redundant condition: aNewConnectedComponent.maTotalBounds.isEmpty(). '!A || (A && B)' is equivalent to '!A || B'

Source code is

            OSL_ENSURE( !aNewConnectedComponent.maTotalBounds.isEmpty() ||
                        (aNewConnectedComponent.maTotalBounds.isEmpty() &&
                         aNewConnectedComponent.maComponentList.size() == 1),
                        "B2DConnectedRanges::addRange(): empty ranges must be solitary");
Comment 1 Julien Nabet 2016-04-10 06:14:16 UTC
I submitted a patch to gerrit in master branch (future 5.2.0) here:
https://gerrit.libreoffice.org/#/c/23954/
Comment 2 Commit Notification 2016-04-10 06:51:12 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=79fc3337851994acf813dacd2a518ba408d37581

tdf#99176: Fix redundant condition

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.